
looks interesting, but a warning: when you upgrade, all your previous "nomails" will appear to revert to "off". Not exactly what I expected. (the value is actually "UNKNOWN", which still disables delivery...but it doesn't show up.)
Barry, do you plan to change the option display in the membership list and/or personal pages to something multivalued?...

"DM" == Dan Mick <dmick@utopia.West.Sun.COM> writes:
DM> looks interesting, but a warning: when you upgrade, all your
DM> previous "nomails" will appear to revert to "off". Not
DM> exactly what I expected. (the value is actually "UNKNOWN",
DM> which still disables delivery...but it doesn't show up.)
[...and later...]
DM> Actually, it was worse; the upgrade just cleared everyone's
DM> nomail flag (set them to "ENABLED"). D'oh!..
I'm having a hard time reproducing this, so I need more information. Exactly how did you do the upgrade? Which version of Python are you using? Do you see any errors in logs/error that might be relevant?
Try using bin/dumpdb on both the (old) config.db value and the (new)
config.pck value and check attributes like data_version', and
delivery_status'.
Below is the process I'm using to upgrade a list, see how that compares. I'm going to go ahead and release alpha4 today anyway, so I'm sure if this is a real problem we'll get lots of complaints ;}.
DM> Barry, do you plan to change the option display in the
DM> membership list and/or personal pages to something
DM> multivalued?...
In the personal options page, you'll just see some prose describing the reason your membership has been disabled. The user shouldn't care though, if they want to re-enable their membership it doesn't make a difference why they were disabled.
I thought about it for the membership list admin pages, but I couldn't think of a good u/i that wouldn't clutter up that page even more. And I'm not sure it's worth it. If the admin enables, then re-disables a member's delivery, the flag will change from <whatever> to BYADMIN. This could potentially disrupt disable warning notifications, but I don't think its worth cluttering up that page to deal with what ought to be a rare occurance (and besides, I'd eventually like cron/disabled to handle UNKNOWN, BYADMIN, and BYUSER disables).
-Barry

"Barry A. Warsaw" wrote:
The standard way; config (as me) and "make install" (as root).
Which version of Python are you using?
2.1.1
Do you see any errors in logs/error that might be relevant?
Nothing easily findable, no.
Try using bin/dumpdb on both the (old) config.db value and the (new) config.pck value and check attributes like
data_version', and
delivery_status'.
Where do I find the old and new files?...the new ones are obviously there, but the old ones aren't saved by upgrade, are they?...it'd be nice if they were somewhere I'm missing, because then I could manually fix the problem. (No, I don't have backups.)
Yeah; this is mostly of interest for the admin trying to figure out what's going on with disabling.
A small string under the "nomail" box, if checked, would do it; I'm not sure it would add a lot to the size (but might; haven't futzed with the layout). Given that we're already two vertical spaces because of the "realname" box, it might fit without changing the size.
Yeah; one of the reasons I asked was that I'd had this problem, and initially assumed that the value of the checkbox was not the relevant bit. Now I realize it was relevant that they all got reset.

This doesn't look hideous (in output; the code's a complete hack of course):
Index: admin.py
RCS file: /cvsroot/mailman/mailman/Mailman/Cgi/admin.py,v retrieving revision 2.50 diff -r2.50 admin.py 912c912,915 < cells.append(Center(box).Format())
if opt == 'nomail' and value == 'on': cells.append(Center(box).Format() + '<center>' + ('unknown', '
byuser', 'byadmin', 'bybounce')[mlist.getDeliveryStatus(addr)-1] + '</center>')
else: cells.append(Center(box).Format())
The strings could be shortened of course, perhaps even to one letter.

"DM" == Dan Mick <dmick@utopia.West.Sun.COM> writes:
>> so I need more information. Exactly how did you do the
>> upgrade?
DM> The standard way; config (as me) and "make install" (as root).
Did you install over an existing Mailman 2.0.x installation, or did you do a fresh MM2.1 install and copy list directories over?
>> Which version of Python are you using?
DM> 2.1.1
Cool.
>> Do you see any errors in logs/error that might be relevant?
DM> Nothing easily findable, no.
Okay.
>> Try using bin/dumpdb on both the (old) config.db value and the
>> (new) config.pck value and check attributes like
>> `data_version', and `delivery_status'.
DM> Where do I find the old and new files?...the new ones are
DM> obviously there, but the old ones aren't saved by upgrade, are
DM> they?...it'd be nice if they were somewhere I'm missing,
DM> because then I could manually fix the problem. (No, I don't
DM> have backups.)
All the files should be in lists/<listname>/config.{db,pck}{,.last}
The upgrade procedure doesn't get rid of the .db files.
DM> A small string under the "nomail" box, if checked, would do
DM> it; I'm not sure it would add a lot to the size (but might;
DM> haven't futzed with the layout). Given that we're already two
DM> vertical spaces because of the "realname" box, it might fit
DM> without changing the size.
I'll check out your patch momentarily. Thanks! -Barry

"BAW" == Barry A Warsaw <barry@zope.com> writes:
DM> A small string under the "nomail" box, if checked, would do
DM> it; I'm not sure it would add a lot to the size (but might;
DM> haven't futzed with the layout). Given that we're already two
DM> vertical spaces because of the "realname" box, it might fit
DM> without changing the size.
BAW> I'll check out your patch momentarily. Thanks!
See if you like what I just checked in.
-Barry
P.S. I'll likely be off-line for the next 24 hours or so. I'll try to get back to email, and log onto the #mailman channel after Maryland beats Florida in the Orange Bowl tomorrow night <15 wink>. Go Terps!

"DM" == Dan Mick <dmick@utopia.West.Sun.COM> writes:
DM> looks interesting, but a warning: when you upgrade, all your
DM> previous "nomails" will appear to revert to "off". Not
DM> exactly what I expected. (the value is actually "UNKNOWN",
DM> which still disables delivery...but it doesn't show up.)
[...and later...]
DM> Actually, it was worse; the upgrade just cleared everyone's
DM> nomail flag (set them to "ENABLED"). D'oh!..
I'm having a hard time reproducing this, so I need more information. Exactly how did you do the upgrade? Which version of Python are you using? Do you see any errors in logs/error that might be relevant?
Try using bin/dumpdb on both the (old) config.db value and the (new)
config.pck value and check attributes like data_version', and
delivery_status'.
Below is the process I'm using to upgrade a list, see how that compares. I'm going to go ahead and release alpha4 today anyway, so I'm sure if this is a real problem we'll get lots of complaints ;}.
DM> Barry, do you plan to change the option display in the
DM> membership list and/or personal pages to something
DM> multivalued?...
In the personal options page, you'll just see some prose describing the reason your membership has been disabled. The user shouldn't care though, if they want to re-enable their membership it doesn't make a difference why they were disabled.
I thought about it for the membership list admin pages, but I couldn't think of a good u/i that wouldn't clutter up that page even more. And I'm not sure it's worth it. If the admin enables, then re-disables a member's delivery, the flag will change from <whatever> to BYADMIN. This could potentially disrupt disable warning notifications, but I don't think its worth cluttering up that page to deal with what ought to be a rare occurance (and besides, I'd eventually like cron/disabled to handle UNKNOWN, BYADMIN, and BYUSER disables).
-Barry

"Barry A. Warsaw" wrote:
The standard way; config (as me) and "make install" (as root).
Which version of Python are you using?
2.1.1
Do you see any errors in logs/error that might be relevant?
Nothing easily findable, no.
Try using bin/dumpdb on both the (old) config.db value and the (new) config.pck value and check attributes like
data_version', and
delivery_status'.
Where do I find the old and new files?...the new ones are obviously there, but the old ones aren't saved by upgrade, are they?...it'd be nice if they were somewhere I'm missing, because then I could manually fix the problem. (No, I don't have backups.)
Yeah; this is mostly of interest for the admin trying to figure out what's going on with disabling.
A small string under the "nomail" box, if checked, would do it; I'm not sure it would add a lot to the size (but might; haven't futzed with the layout). Given that we're already two vertical spaces because of the "realname" box, it might fit without changing the size.
Yeah; one of the reasons I asked was that I'd had this problem, and initially assumed that the value of the checkbox was not the relevant bit. Now I realize it was relevant that they all got reset.

This doesn't look hideous (in output; the code's a complete hack of course):
Index: admin.py
RCS file: /cvsroot/mailman/mailman/Mailman/Cgi/admin.py,v retrieving revision 2.50 diff -r2.50 admin.py 912c912,915 < cells.append(Center(box).Format())
if opt == 'nomail' and value == 'on': cells.append(Center(box).Format() + '<center>' + ('unknown', '
byuser', 'byadmin', 'bybounce')[mlist.getDeliveryStatus(addr)-1] + '</center>')
else: cells.append(Center(box).Format())
The strings could be shortened of course, perhaps even to one letter.

"DM" == Dan Mick <dmick@utopia.West.Sun.COM> writes:
>> so I need more information. Exactly how did you do the
>> upgrade?
DM> The standard way; config (as me) and "make install" (as root).
Did you install over an existing Mailman 2.0.x installation, or did you do a fresh MM2.1 install and copy list directories over?
>> Which version of Python are you using?
DM> 2.1.1
Cool.
>> Do you see any errors in logs/error that might be relevant?
DM> Nothing easily findable, no.
Okay.
>> Try using bin/dumpdb on both the (old) config.db value and the
>> (new) config.pck value and check attributes like
>> `data_version', and `delivery_status'.
DM> Where do I find the old and new files?...the new ones are
DM> obviously there, but the old ones aren't saved by upgrade, are
DM> they?...it'd be nice if they were somewhere I'm missing,
DM> because then I could manually fix the problem. (No, I don't
DM> have backups.)
All the files should be in lists/<listname>/config.{db,pck}{,.last}
The upgrade procedure doesn't get rid of the .db files.
DM> A small string under the "nomail" box, if checked, would do
DM> it; I'm not sure it would add a lot to the size (but might;
DM> haven't futzed with the layout). Given that we're already two
DM> vertical spaces because of the "realname" box, it might fit
DM> without changing the size.
I'll check out your patch momentarily. Thanks! -Barry

"BAW" == Barry A Warsaw <barry@zope.com> writes:
DM> A small string under the "nomail" box, if checked, would do
DM> it; I'm not sure it would add a lot to the size (but might;
DM> haven't futzed with the layout). Given that we're already two
DM> vertical spaces because of the "realname" box, it might fit
DM> without changing the size.
BAW> I'll check out your patch momentarily. Thanks!
See if you like what I just checked in.
-Barry
P.S. I'll likely be off-line for the next 24 hours or so. I'll try to get back to email, and log onto the #mailman channel after Maryland beats Florida in the Orange Bowl tomorrow night <15 wink>. Go Terps!

I've been running "latest CVS" for some time, so it was a previous revision of 2.1a.
I thought "last" was the last time anything changed with a list setting? It's got a very recent date.
There *is* "config.pck.backup.dec.30"; is that the one preserved by upgrade/update?
participants (4)
-
barry@zope.com
-
Dan Mick
-
Dan Mick
-
Kathy Baron