On Aug 7, 2009, at 12:08 AM, Mark Sapiro wrote:
The idea is to require the square brackets so a mere "approved:" in
the subject (such as this message) doesn't trigger a match. We only match if we find "Approve:" or "Approved:" followed by a single "word" inside the square brackets and then we remove the brackets and their contents.
As a comparison, Launchpad's code review process allows for commands
in the body of the message. It looks for specific commands prepended
by a space. I don't particularly like that approach though because
the space can be hard to see.
Wrapping the Approve pseudo-header in brackets might be okay, though
ideally, I think Mailman should maintain a set of OpenPGP public keys
and do approval matching based on that. Yes, I know that signing
messages is problematic for a lot of people, but it would certainly be
less ambiguous on Mailman's side.
I think anytime Mailman has to go trolling inside the body of the
message, we're in trouble.
-Barry