Mailman bug or browser behaviour?
![](https://secure.gravatar.com/avatar/8381104a4d879780b22b7a0c595641c2.jpg?s=120&d=mm&r=g)
Hi,
I've noticed an odd thing but am not sure if it's Mailman (2.1.11) or my browser (Lynx 2.8.7dev.9) which is at fault.
I've noticed that if I go to pending Moderator requests and approve a message from a particular user, if I leave the resulting page open which says "Click here to reload this page" and another message from that user comes through which requires approval, if I click to reload the page, the message is automatically approved and I'm told there are no pending requests.
I wondered if perhaps someone else was clearing the queue at the same time, but I've seen this several times now so I'm confident that it's either Mailman or my browser that's to blame here.
Cheers, Geoff.
![](https://secure.gravatar.com/avatar/56f108518d7ee2544412cc80978e3182.jpg?s=120&d=mm&r=g)
Geoff Shang wrote:
I think it is a bug, but I don't think the scenario is exactly as you describe.
I think the second message from the same user arrives after you go to the pending requests page but before you submit the approval.
Then you submit the approval from the summary page which is an approval for all messages from that user, and the second message gets the same action as the one you saw.
If this is the case, you can avoid the problem by clicking the number next to the Subject:, or clicking the "view all messages from <address>" link to get the message detailed view and approve the message(s) from there.
The underlying problem is that the data posted from the summary page says "apply the selected action to all messages from this user" rather than "apply the selected action to all messages from this user that were displayed on the page".
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
![](https://secure.gravatar.com/avatar/56f108518d7ee2544412cc80978e3182.jpg?s=120&d=mm&r=g)
Mark Sapiro wrote:
I have reported this at <https://bugs.launchpad.net/mailman/+bug/533468> and the fix is committed at <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1227>
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
![](https://secure.gravatar.com/avatar/8381104a4d879780b22b7a0c595641c2.jpg?s=120&d=mm&r=g)
Hi,
Reserecting an old thread.
On Sat, 6 Mar 2010, Mark Sapiro wrote:
No. I've confirmed this twice int he last week, once just now. I'd read the Email copies of the new messages before I refreshed the page, so they definitely came in before.
hmmm, doesn't explain why this should be the case if I hit the "Click here to reload this page" link. Shouldn't that just refresh the list of pending tasks without processing anything?
Geoff.
![](https://secure.gravatar.com/avatar/56f108518d7ee2544412cc80978e3182.jpg?s=120&d=mm&r=g)
Geoff Shang wrote:
I think you may be confirming what I said. My scenario is as follows:
Message 1 from user arrives.
You go to the admindb page and see message 1.
Message 2 from user arrives.
You submit the admindb form approving message 1. Due to the bug, message 2 is also approved even though it wasn't displayed on the page.
You click reload this page and there are no requests because both messages were approved when you submitted the original form.
Yes, but if message 2 were approved at the same time as message 1 even though it wasn't displayed on the page, there would be no more pending messages.
The scenario I describe is definitely a bug and is reported at <https://bugs.launchpad.net/mailman/+bug/533468> and the fix is committed at <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1227>.
If you have definitely confirmed a different scenario, i.e.:
Message 1 from user arrives.
You go to the admindb page and see message 1.
You submit the admindb form approving message 1 prior to the arrival of message 2.
Message 2 from user arrives.
You click reload this page and there are no requests.
then this is not the bug I identified, and I don't know what the problem is. As you note, simply clicking the reload this page link does not do any updates, so message 2 had to be approved before you did that.
Note that the difference between this scenario and mine above is whether message 2 arrives after or before the submission of the form approving message 1. In no case did I suggest that message 2 arrived after you refreshed the page.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
![](https://secure.gravatar.com/avatar/56f108518d7ee2544412cc80978e3182.jpg?s=120&d=mm&r=g)
Geoff Shang wrote:
I think it is a bug, but I don't think the scenario is exactly as you describe.
I think the second message from the same user arrives after you go to the pending requests page but before you submit the approval.
Then you submit the approval from the summary page which is an approval for all messages from that user, and the second message gets the same action as the one you saw.
If this is the case, you can avoid the problem by clicking the number next to the Subject:, or clicking the "view all messages from <address>" link to get the message detailed view and approve the message(s) from there.
The underlying problem is that the data posted from the summary page says "apply the selected action to all messages from this user" rather than "apply the selected action to all messages from this user that were displayed on the page".
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
![](https://secure.gravatar.com/avatar/56f108518d7ee2544412cc80978e3182.jpg?s=120&d=mm&r=g)
Mark Sapiro wrote:
I have reported this at <https://bugs.launchpad.net/mailman/+bug/533468> and the fix is committed at <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1227>
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
![](https://secure.gravatar.com/avatar/8381104a4d879780b22b7a0c595641c2.jpg?s=120&d=mm&r=g)
Hi,
Reserecting an old thread.
On Sat, 6 Mar 2010, Mark Sapiro wrote:
No. I've confirmed this twice int he last week, once just now. I'd read the Email copies of the new messages before I refreshed the page, so they definitely came in before.
hmmm, doesn't explain why this should be the case if I hit the "Click here to reload this page" link. Shouldn't that just refresh the list of pending tasks without processing anything?
Geoff.
![](https://secure.gravatar.com/avatar/56f108518d7ee2544412cc80978e3182.jpg?s=120&d=mm&r=g)
Geoff Shang wrote:
I think you may be confirming what I said. My scenario is as follows:
Message 1 from user arrives.
You go to the admindb page and see message 1.
Message 2 from user arrives.
You submit the admindb form approving message 1. Due to the bug, message 2 is also approved even though it wasn't displayed on the page.
You click reload this page and there are no requests because both messages were approved when you submitted the original form.
Yes, but if message 2 were approved at the same time as message 1 even though it wasn't displayed on the page, there would be no more pending messages.
The scenario I describe is definitely a bug and is reported at <https://bugs.launchpad.net/mailman/+bug/533468> and the fix is committed at <http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1227>.
If you have definitely confirmed a different scenario, i.e.:
Message 1 from user arrives.
You go to the admindb page and see message 1.
You submit the admindb form approving message 1 prior to the arrival of message 2.
Message 2 from user arrives.
You click reload this page and there are no requests.
then this is not the bug I identified, and I don't know what the problem is. As you note, simply clicking the reload this page link does not do any updates, so message 2 had to be approved before you did that.
Note that the difference between this scenario and mine above is whether message 2 arrives after or before the submission of the form approving message 1. In no case did I suggest that message 2 arrived after you refreshed the page.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
participants (2)
-
Geoff Shang
-
Mark Sapiro