enhancement patches
I have a patch for mailman 2.1.9 that makes it direct all logging to the system syslog 'maillog'. We have found this useful.
It can be viewed at http://noh.ucsd.edu/~brian/Mailman-syslog-patch
How should I submit this patch for consideration to be included in a future release? - Brian
Brian Kantor wrote:
I have a patch for mailman 2.1.9 that makes it direct all logging to the system syslog 'maillog'. We have found this useful.
It can be viewed at http://noh.ucsd.edu/~brian/Mailman-syslog-patch
How should I submit this patch for consideration to be included in a future release?
We're part way to moving to a new tracker at http://bugs.list.org/ but that is not yet useable and the move seems to be stalled at the moment, so the place for patches is still the sourceforge tracker at http://sourceforge.net/tracker/?group_id=103&atid=300103.
There are some issues with your patch. I looked at it and it seems unnecessarily complex (or maybe just large). Why not do the whole thing in Mailman/Logging/Syslog.py by keeping syslog as the name of the _Syslog instance and importing the system syslog as another name?
Perhaps more importantly, logging has completely changed on the Mailman trunk (now called the 3.0 branch) to use the Python 'logging' module and all the Mailman/Logging/* modules are gone.
-- Mark Sapiro msapiro@value.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Yes, indeed it is probably larger than need be, but after fighting with other approaches, I just did it brute force.
Probably my way of doing it shouldn't be included in a future release, although the capability of using syslog would be very useful here.
Thank you for your comments. - Brian
On Wed, Jul 18, 2007 at 06:24:15PM -0700, Mark Sapiro wrote:
Brian Kantor wrote:
I have a patch for mailman 2.1.9 that makes it direct all logging to the system syslog 'maillog'. We have found this useful.
It can be viewed at http://noh.ucsd.edu/~brian/Mailman-syslog-patch
How should I submit this patch for consideration to be included in a future release?
We're part way to moving to a new tracker at http://bugs.list.org/ but that is not yet useable and the move seems to be stalled at the moment, so the place for patches is still the sourceforge tracker at http://sourceforge.net/tracker/?group_id=103&atid=300103.
There are some issues with your patch. I looked at it and it seems unnecessarily complex (or maybe just large). Why not do the whole thing in Mailman/Logging/Syslog.py by keeping syslog as the name of the _Syslog instance and importing the system syslog as another name?
Perhaps more importantly, logging has completely changed on the Mailman trunk (now called the 3.0 branch) to use the Python 'logging' module and all the Mailman/Logging/* modules are gone.
-- Mark Sapiro msapiro@value.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Mailman-Users mailing list Mailman-Users@python.org http://mail.python.org/mailman/listinfo/mailman-users Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/ Unsubscribe: http://mail.python.org/mailman/options/mailman-users/brian%40ucsd.edu
Security Policy: http://www.python.org/cgi-bin/faqw-mm.py?req=show&file=faq01.027.htp
participants (2)
-
Brian Kantor
-
Mark Sapiro