Probable bug in Bouncers/DSN.py
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hello!
Given a bounce msg with a subpart of:
message/delivery-status: Final-Recipient: rfc822;user@domain.tld Action: failed Status: 5.1.10 Diagnostic-Code: smtp;550 5.1.10 RESOLVER.ADR.RecipientNotFound;
and the code beginning at Bouncers/DSN.py:64
params = [] foundp = False for header in ('original-recipient', 'final-recipient'): for k, v in msgblock.get_params([], header): if k.lower() == 'rfc822': foundp = True else: params.append(k) if foundp: # Note that params should already be unquoted. addrs.extend(params) break
It appears that "params" is never populated and thus the bounce score is never incremented for the user.
I was intending to release a patch for this but my dev system is showing an odd python issue where once "k.lower()" is evaluated the variable v is no longer available. O.o
- -Jim -----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEPxwe8uYBnqxkbORSJxVetMRaJwUFAlsG3PUACgkQJxVetMRa JwVnzA/+NJnsWa2bTEo689I7KsoIubwUlf6KPv1jIGU+98gKecOGFOlc9YAx6dU4 TiWPqkLG6oKYZti7Y/kjVxhmxKvj0Pb6xos8uJBqRikDKJQDbZjo+hVY1yR6zAL7 r1NIVc7BKsvTTQ+U4D4k4Y2D1WdOEGIYWdV0ds3SScc2eq6CM2nulI/YM7U32pdi YB4FTxK51K+8OYK9tprJEtSDgTADPiYjOb/qUTM1Zxnsdx6NK+q6MCTzUFilrgl8 pWOoIrmdrMyytRMgNp40arK8LMbD406P9kmDpuSU9/kPkFE7T98uRuD1II24m7MZ W8QtSPbmQDBWqKbu3/KmnC8OGiIO05KW9PHwt9fNWmqA/nSRbQ7tKZOkywRZIfQt 6RwJGqZnvRR5qk6ltIRNm/Cq3AQgGHD2m40m9ppSrGaeijtfNWfQnTnDCYB3P6d1 hnAxnDJ8UCxK3v4gQUeOf9xsfCaT5hss+vp6C1nZPfM7jupQWQxA4SjGH77Q47Wd SkqZvOPZ0lVajBvFKoNlttdrvXjeDBRki1v5hFvuNSHSMBSJ+yySb0FMuC3aw+2y KKZhKhwYJuoWMHMa6Lmhrtna/x1ywD1xvCg2m0J2mEM3biNFlwIHx7zewYbhn56j wTtX9Ch8ozdKVGakmybxfo91xkbQvRpROpjwIslRWrbxAgbV6r8= =z4V/ -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Argh! This was intended for just Mark, not the whole list. Sigh.
- -Jim P.
On Thu, 2018-05-24 at 11:40 -0400, Jim Popovitch via Mailman-Users wrote:
Hello!
Given a bounce msg with a subpart of:
message/delivery-status: Final-Recipient: rfc822;user@domain.tld Action: failed Status: 5.1.10 Diagnostic-Code: smtp;550 5.1.10 RESOLVER.ADR.RecipientNotFound;
and the code beginning at Bouncers/DSN.py:64
params = [] foundp = False for header in ('original-recipient', 'final-recipient'): for k, v in msgblock.get_params([], header): if k.lower() == 'rfc822': foundp = True else: params.append(k) if foundp: # Note that params should already be unquoted. addrs.extend(params) break
It appears that "params" is never populated and thus the bounce score is never incremented for the user.
I was intending to release a patch for this but my dev system is showing an odd python issue where once "k.lower()" is evaluated the variable v is no longer available. O.o
-Jim
Mailman-Users mailing list Mailman-Users@python.org https://mail.python.org/mailman/listinfo/mailman-users Mailman FAQ: http://wiki.list.org/x/AgA3 Security Policy: http://wiki.list.org/x/QIA9 Searchable Archives: http://www.mail-archive.com/mailman-users%40pyth on.org/ Unsubscribe: https://mail.python.org/mailman/options/mailman-users/ji mpop%40domainmail.org -----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEPxwe8uYBnqxkbORSJxVetMRaJwUFAlsG394ACgkQJxVetMRa JwU9EhAAqmjhVZQl4go2sEfSzcWSqT+DYbqoaotJG3Z7Yl723uPVlt/ybbsDvmSS I2pv4v0dEVJalVxVq5cisqfxNw/vd33o4Qju7pDPtBcahOWljbeNNvc6kWKqzBwc IOJSuAGH8R5V4WAdNPmwZnwcSloomFavnoll2bvuPOgIMsaJzBPAG2Jq1dCgPhTG loojPOlTcCJY2VUHgpwIPT1mKAdCc7MMHiewghRXRrlVkJRRcmSRrlSFwMbDxapZ eQWC/mV8isS9WgYHBepjIBrTyVr1khIrS8jXsIMurHwYsoupveu0qv2qfNY0uOiY ST062iunVtp9lb1uo7vSofbsEaZv8N0rFJgWw1JqdHN3nsZew+HTuc40n2iz5pob MGKsULtUKAkOzf+V5shmk0RheI/dNNL/kw6cu9eI2OysS2Rb413UZR4QxARuv6rQ i37bUDQ/cEQrdhKtwuiT+mtZU70vQCDfsxcvSZX2ITr8D+7c0Dw9wUtIv7Ofop13 nLDHXJ2psBUDV3Ui3kpjazbDEhS/3LAOFuD/o2f97boOcXuEI2Ub4KZ7JO40pPzM qZLHcdXt1W8BMToYJnORUewyHbQkwgzlN1UvzYQD0jn9xttNTGohJhae9fSQ0fdJ RXXOooLt/OhGYoeGyLaQIi0jxJEQoJUiRs3OlxLp5I9ba5WEfa0= =iWpM -----END PGP SIGNATURE-----
participants (1)
-
Jim Popovitch