On the one hand it does seem like `ma` versions of these functions, especially `ones_like` and `zeros_like`, are sensible additions given that they should be relatively straightforward extensions of the core functions. OTOH in my experience "relatively straightforward changes" to the masked array package tend to add/hit a lot of subtle corner cases. If the *only* motivation is fixing broken doc links in the ma package, I'd propose to solve this by instead taking a closer look at the [`_convert2ma`]( https://github.com/numpy/numpy/blob/45bc13e6d922690eea43b9d807d476e0f243f836...) class to see if it'd be possible to fix broken See Also links with some additional docstring munging.
However, if others think these creation functions add utility for users then I'm +1 on adding.
~Ross
On Mon, Aug 8, 2022 at 9:43 AM Matti Picus matti.picus@gmail.com wrote:
PR 21998 [0] adds methods "ones_like", "zeros_like", "dsplit","split", and "vsplit" for MaskedArrays. The motivation was to clean up broken documentation links, and it seemed logical to add the interfaces. As far as I can tell we do not have users asking for these methods. Should we add them (expanding the np.ma namespace) or find another way to fix the broken documentation links?
Matti
[0] https://github.com/numpy/numpy/pull/21998
NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-leave@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/ Member address: rossbar@berkeley.edu