30 Sep
2008
30 Sep
'08
1:23 a.m.
On Mon, Sep 29, 2008 at 11:14 AM, Pauli Virtanen
Mon, 29 Sep 2008 11:05:09 -0600, Charles R Harris wrote: [clip: assert in tests]
Using assert for this sort of thing is a bug, assert goes away with the -OO options. This needs to be fixed.
"assert FOO" is used in quite many of Numpy's test cases, and it appears Nose endorses using assert (and uses it in its own tests).
Should we go ahead and change all "assert FOO" in Numpy's tests to something like 'self.failUnless'?
I fixed the np.testing functions to use if (foo) : raise AssertionError("Da Bomb") That way no changes to exception catching are needed, but the error will still be raised when the -OO option is used. Strictly speaking, it isn't quite right, but so it goes... Chuck