Change done.
All tests pass.
Should I document the change somewhere ? Although it's a small change, I'm guessing it could be very annoying to debug for someone depending on the previous behavior.
David Huard wrote:
> Hi,
>
> The current behavior of numpy's binary_repr is the following:
>
> >>> binary_repr(1,width=2)
> '01'
>
> >>> binary_repr(0,width=2)
> '0'
>
> This seems inconsistent and I'd suggest always padding with zeros to
> make sure that the return string always has length=width.
>
> Objections ?
>
This sounds like a good idea. I don't think it would break anything,
but it would be good to test.
-Travis O.
> ------------------------------------------------------------------------
>
> _______________________________________________
> Numpy-discussion mailing list
> Numpy-discussion@scipy.org
> http://projects.scipy.org/mailman/listinfo/numpy-discussion
>
_______________________________________________
Numpy-discussion mailing list
Numpy-discussion@scipy.org
http://projects.scipy.org/mailman/listinfo/numpy-discussion