On Thu, Feb 8, 2018 at 11:32 AM, Peter Cock <p.j.a.cock@googlemail.com> wrote:
On Thu, Feb 8, 2018 at 11:22 AM, Ralf Gommers <ralf.gommers@gmail.com> wrote:
On Wed, Feb 7, 2018 at 11:29 PM, Stefan van der Walt < stefanv@berkeley.edu> wrote:
For scikit-image, we've started a policy of pushing minor edits (spelling corrections, sentence restructuring, etc.) directly to the PR branch, instead of flagging those during a review (we also have a PEP8 bot that mentions PEP8 issues, which makes the human reviews less nitpicky).
+1. Especially useful for docstring formatting, that doesn't get picked up by a PEP8 bot
Ralf
Were is the current NumPy PEP8 bot setup? I don't see flake8 or similar under the TravisCI or AppVeyor setup - which is where I am using a flake8 plugin to at least partially validate RST docstrings [*] (and catch things automatically in pull requests).
Good question. It's missing, I confused it with the scipy version: https://github.com/scipy/scipy/blob/master/.travis.yml#L18. We should copy that build matrix entry for numpy. Ralf
Peter
[*] My plugin:
https://github.com/peterjc/flake8-rst-docstrings https://pypi.python.org/pypi/flake8-rst-docstrings _______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion