last call for numpy 1.8.2 bugfixes
hi, as numpy 1.9 is going to be a relative hard upgrade as indexing changes expose a couple bugs in third party packages and the large amount of small little incompatibilities I will create a numpy 1.8.2 release tomorrow with a couple of important or hard to work around bugfixes. The most important bugfix is fixing the wrong result partition with multiple selections could produce if selections ended up in an equal range, see https://github.com/numpy/numpy/issues/4836 (if the crash is still unreproducable, help appreciated). the rest of the fixes are small ones listed below. If I have missed one or you consider one of the fixes to invasive for a bugfix release please speak up now. As the number of fixes is small I will skip a release candidate. Make fftpack._raw_fft threadsafe https://github.com/numpy/numpy/issues/4656 Prevent division by zero https://github.com/numpy/numpy/issues/650 Fix lack of NULL check in array_richcompare https://github.com/numpy/numpy/issues/4613 incorrect argument order to _copyto in in np.nanmax, np.nanmin https://github.com/numpy/numpy/issues/4628 Hold GIL for types with fields, fixes https://github.com/numpy/numpy/issues/4642 svd ufunc typo https://github.com/numpy/numpy/issues/4733 check alignment of strides for byteswap https://github.com/numpy/numpy/issues/4774 add missing elementsize alignment check for simd reductions https://github.com/numpy/numpy/issues/4853 ifort has issues with optimization flag /O2 https://github.com/numpy/numpy/issues/4602
Hi, On Mon, Aug 4, 2014 at 3:05 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
hi, as numpy 1.9 is going to be a relative hard upgrade as indexing changes expose a couple bugs in third party packages and the large amount of small little incompatibilities I will create a numpy 1.8.2 release tomorrow with a couple of important or hard to work around bugfixes.
The most important bugfix is fixing the wrong result partition with multiple selections could produce if selections ended up in an equal range, see https://github.com/numpy/numpy/issues/4836 (if the crash is still unreproducable, help appreciated).
the rest of the fixes are small ones listed below. If I have missed one or you consider one of the fixes to invasive for a bugfix release please speak up now. As the number of fixes is small I will skip a release candidate.
Make fftpack._raw_fft threadsafe https://github.com/numpy/numpy/issues/4656
Prevent division by zero https://github.com/numpy/numpy/issues/650
Fix lack of NULL check in array_richcompare https://github.com/numpy/numpy/issues/4613
incorrect argument order to _copyto in in np.nanmax, np.nanmin https://github.com/numpy/numpy/issues/4628
Hold GIL for types with fields, fixes https://github.com/numpy/numpy/issues/4642
svd ufunc typo https://github.com/numpy/numpy/issues/4733
check alignment of strides for byteswap https://github.com/numpy/numpy/issues/4774
add missing elementsize alignment check for simd reductions https://github.com/numpy/numpy/issues/4853
ifort has issues with optimization flag /O2 https://github.com/numpy/numpy/issues/4602
Any chance of a RC to give us some time to test? Cheers, Matthew
On 05.08.2014 00:09, Matthew Brett wrote:
Hi,
On Mon, Aug 4, 2014 at 3:05 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
hi, as numpy 1.9 is going to be a relative hard upgrade as indexing changes expose a couple bugs in third party packages and the large amount of small little incompatibilities I will create a numpy 1.8.2 release tomorrow with a couple of important or hard to work around bugfixes. ...
Any chance of a RC to give us some time to test?
I hope I have only selected fixes that are safe and do not require a RC. sure we could do one, but if there are issues we can also just make a quick 1.8.3 release follow up. the main backport PR is: https://github.com/numpy/numpy/pull/4949
On Mon, Aug 4, 2014 at 11:12 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
On 05.08.2014 00:09, Matthew Brett wrote:
Hi,
On Mon, Aug 4, 2014 at 3:05 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
hi, as numpy 1.9 is going to be a relative hard upgrade as indexing changes expose a couple bugs in third party packages and the large amount of small little incompatibilities I will create a numpy 1.8.2 release tomorrow with a couple of important or hard to work around bugfixes. ...
Any chance of a RC to give us some time to test?
I hope I have only selected fixes that are safe and do not require a RC. sure we could do one, but if there are issues we can also just make a quick 1.8.3 release follow up.
the main backport PR is: https://github.com/numpy/numpy/pull/4949
It's probably better to just make an RC if it's not too much trouble... it's always possible to misjudge what issues arise, if there's a real-but-non-catastrophic issue then people 1.8.2 will remain in use even if 1.8.3 is released afterwards and force downstream libraries to work around the issues, and just in general it's good to have and follow standard processes because special cases lead to errors. -n -- Nathaniel J. Smith Postdoctoral researcher - Informatics - University of Edinburgh http://vorpus.org
On Mon, Aug 4, 2014 at 3:25 PM, Nathaniel Smith <njs@pobox.com> wrote:
On Mon, Aug 4, 2014 at 11:12 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
On 05.08.2014 00:09, Matthew Brett wrote:
Hi,
On Mon, Aug 4, 2014 at 3:05 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
hi, as numpy 1.9 is going to be a relative hard upgrade as indexing changes expose a couple bugs in third party packages and the large amount of small little incompatibilities I will create a numpy 1.8.2 release tomorrow with a couple of important or hard to work around bugfixes. ...
Any chance of a RC to give us some time to test?
I hope I have only selected fixes that are safe and do not require a RC. sure we could do one, but if there are issues we can also just make a quick 1.8.3 release follow up.
A few days to test would be fine, I'd prefer an RC too, Cheers, Matthew
On 05.08.2014 00:27, Matthew Brett wrote:
On Mon, Aug 4, 2014 at 3:25 PM, Nathaniel Smith <njs@pobox.com> wrote:
On Mon, Aug 4, 2014 at 11:12 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
On 05.08.2014 00:09, Matthew Brett wrote:
Hi,
On Mon, Aug 4, 2014 at 3:05 PM, Julian Taylor <jtaylor.debian@googlemail.com> wrote:
hi, as numpy 1.9 is going to be a relative hard upgrade as indexing changes expose a couple bugs in third party packages and the large amount of small little incompatibilities I will create a numpy 1.8.2 release tomorrow with a couple of important or hard to work around bugfixes. ...
Any chance of a RC to give us some time to test?
I hope I have only selected fixes that are safe and do not require a RC. sure we could do one, but if there are issues we can also just make a quick 1.8.3 release follow up.
A few days to test would be fine, I'd prefer an RC too,
alright I'll make an RC tomorrow and planning for release this weekend then.
participants (3)
-
Julian Taylor -
Matthew Brett -
Nathaniel Smith