Travis E. Oliphant wrote:

Jim Vickroy wrote:

...

Hello,

While using the PIL interface to numpy, I rediscovered a logic error in the PIL.Image.fromarray() procedure. The problem (and a solution) was mentioned earlier at:

* http://projects.scipy.org/pipermail/numpy-discussion/2006-December/024903.html

There does not seem to be a formal way to report errors to the PIL project, and I was told that the PIL/numpy interface was contributed by the numpy developers so I'm reporting it here.

Please let me know if there is something additional I should do.

I would suggest making a patch and submitting it to the PIL.

I did post a suggested patch (one-liner) to the PIL group, but a couple of PIL respondents suggested that I submit the problem here. I have followed the PIL group postings for some time, and my impression is that it is somewhat difficult to get reader-submitted patches acknowledged.

-Travis

---

Numpy-discussion mailing list Numpy-discussion@scipy.org http://projects.scipy.org/mailman/listinfo/numpy-discussion

Robert Kern wrote:

On Mon, Nov 24, 2008 at 11:26, Jim Vickroy Jim.Vickroy@noaa.gov wrote:

...

Travis E. Oliphant wrote:

Jim Vickroy wrote:

Hello,

While using the PIL interface to numpy, I rediscovered a logic error in the PIL.Image.fromarray() procedure. The problem (and a solution) was mentioned earlier at:

*

http://projects.scipy.org/pipermail/numpy-discussion/2006-December/024903.ht...

There does not seem to be a formal way to report errors to the PIL project, and I was told that the PIL/numpy interface was contributed by the numpy developers so I'm reporting it here.

Please let me know if there is something additional I should do.

I would suggest making a patch and submitting it to the PIL.

I did post a suggested patch (one-liner) to the PIL group, but a couple of PIL respondents suggested that I submit the problem here. I have followed the PIL group postings for some time, and my impression is that it is somewhat difficult to get reader-submitted patches acknowledged.

Tell them that we approve of the change. We don't have commit access to PIL, so I believe that our approval is the only reason they could possibly send you over here.

Thank-you, Robert. I will do so.

2008/11/24 Chris Barker Chris.Barker@noaa.gov:

Robert Kern wrote:

...

...

Jim Vickroy wrote: While using the PIL interface to numpy, I rediscovered a logic error in the PIL.Image.fromarray() procedure. The problem (and a solution) was mentioned earlier at:

...

Tell them that we approve of the change. We don't have commit access to PIL, so I believe that our approval is the only reason they could possibly send you over here.

Just for the record, it was me that "sent him over here". I thought it would be good for a numpy dev to check out the patch for correctnesses -- it looked like a numpy API issue, and I figured Fredrik wouldn't want to look too hard at it to determine if it was correct.

so if you "approval" means you've looked at the fix and think it's correct, great!

I also submitted an issue in 2007:

http://mail.python.org/pipermail/image-sig/2007-August/004570.html

I recently reminded Frederik, who replied:

"The NumPy support was somewhat broken and has been partially rewritten for PIL 1.2; I'll compare those fixes with your patch when I find the time."

So, I guess we should try the latest PIL and see if the problems are still there?

Cheers Stéfan