Hi! Found this thing that looks like a bug in core/src/multiarray/dtype_transfer.c diff -ru site/numpy/core/src/multiarray/dtype_transfer.c amd64_ubuntu1004-intel-acml/numpy/core/src/multiarray/dtype_transfer.c --- site/numpy/core/src/multiarray/dtype_transfer.c 2011-07-20 20:25:28.000000000 +0200 +++ amd64_ubuntu1004-intel-acml/numpy/core/src/multiarray/dtype_transfer.c 2013-03-14 22:09:38.000000000 +0100 @@ -1064,7 +1064,7 @@ _one_to_n_data *d = (_one_to_n_data *)data; PyArray_StridedTransferFn *subtransfer = d->stransfer, *stransfer_finish_src = d->stransfer_finish_src; - void *subdata = d->data, *data_finish_src = data_finish_src; + void *subdata = d->data, *data_finish_src = d->data_finish_src; npy_intp subN = d->N, dst_itemsize = d->dst_itemsize; while (N > 0) { -- Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden Internet: ake@hpc2n.umu.se Phone: +46 90 7866134 Fax: +46 90 7866126 Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
That does look unlikely yeah... Does this have any consequences that you've found? Is there a test case that fails before the patch but works after? -n On 15 Mar 2013 09:19, "Ake Sandgren" <ake.sandgren@hpc2n.umu.se> wrote:
Hi!
Found this thing that looks like a bug in core/src/multiarray/dtype_transfer.c
diff -ru site/numpy/core/src/multiarray/dtype_transfer.c amd64_ubuntu1004-intel-acml/numpy/core/src/multiarray/dtype_transfer.c --- site/numpy/core/src/multiarray/dtype_transfer.c 2011-07-20 20:25:28.000000000 +0200 +++ amd64_ubuntu1004-intel-acml/numpy/core/src/multiarray/dtype_transfer.c 2013-03-14 22:09:38.000000000 +0100 @@ -1064,7 +1064,7 @@ _one_to_n_data *d = (_one_to_n_data *)data; PyArray_StridedTransferFn *subtransfer = d->stransfer, *stransfer_finish_src = d->stransfer_finish_src; - void *subdata = d->data, *data_finish_src = data_finish_src; + void *subdata = d->data, *data_finish_src = d->data_finish_src; npy_intp subN = d->N, dst_itemsize = d->dst_itemsize;
while (N > 0) {
-- Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden Internet: ake@hpc2n.umu.se Phone: +46 90 7866134 Fax: +46 90 7866126 Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
On Fri, 2013-03-15 at 09:44 +0000, Nathaniel Smith wrote:
That does look unlikely yeah... Does this have any consequences that you've found? Is there a test case that fails before the patch but works after?
No, just found it during compilation with the intel compiler. It complained about use before initialize on it. And it's still there in 1.7.0
On Fri, Mar 15, 2013 at 9:52 AM, Ake Sandgren <ake.sandgren@hpc2n.umu.se> wrote:
On Fri, 2013-03-15 at 09:44 +0000, Nathaniel Smith wrote:
That does look unlikely yeah... Does this have any consequences that you've found? Is there a test case that fails before the patch but works after?
No, just found it during compilation with the intel compiler. It complained about use before initialize on it.
And it's still there in 1.7.0
Clever compiler. Since no-one has jumped up to investigate yet, can you file a bug on the github tracker, so at least it doesn't get lost entirely before someone finds the time to do that? -n
participants (2)
-
Ake Sandgren -
Nathaniel Smith