assert_allclose equal_nan default value.
Hi All, Just a heads up that there is a PR changing the default value of `equal_nan` to `True` in the `assert_allclose` test function. The `equal_nan` argument was previously ineffective due to a bug that has recently been fixed. The current default value of `False` is not backward compatible and causes test failures in scipy. See the extended argument at https://github.com/numpy/numpy/pull/8184. I think this change is the right thing to do but want to make sure everyone is aware of it. Chuck
Agreed, especially given the prevalence of using this function in downstream test suites: https://github.com/search?utf8=%E2%9C%93&q=numpy+assert_allclose&type=Code&ref=searchresults On Thu, Oct 20, 2016 at 12:16 PM, Charles R Harris < charlesr.harris@gmail.com> wrote:
Good, that means I can revert some changes to astropy, which made the tests less readable. -- Marten
Agreed, especially given the prevalence of using this function in downstream test suites: https://github.com/search?utf8=%E2%9C%93&q=numpy+assert_allclose&type=Code&ref=searchresults On Thu, Oct 20, 2016 at 12:16 PM, Charles R Harris < charlesr.harris@gmail.com> wrote:
Good, that means I can revert some changes to astropy, which made the tests less readable. -- Marten
participants (4)
-
Benjamin Root -
Charles R Harris -
Marten van Kerkwijk -
Nathan Goldbaum