Feedback requested for new NumPy feature PR
Hi everyone, I recently opened a PR adding support for an offset argument to diagonal helper functions so they can operate on diagonals above or below the main diagonal. https://github.com/numpy/numpy/pull/31493 During the review, I was asked to send a quick note here to gather broader feedback before the PR moves forward. If anyone has concerns, suggestions, or feedback on the feature or API, I'd be happy to hear them. Thanks! Ricardo Santos
On Sun, Jul 5, 2026 at 6:11 AM ricas28 via NumPy-Discussion < numpy-discussion@python.org> wrote:
Hi everyone,
I recently opened a PR adding support for an offset argument to diagonal helper functions so they can operate on diagonals above or below the main diagonal. https://github.com/numpy/numpy/pull/31493
During the review, I was asked to send a quick note here to gather broader feedback before the PR moves forward.
If anyone has concerns, suggestions, or feedback on the feature or API, I'd be happy to hear them.
Probably worth linking to the issue, which has extra context and a link to a prior mailing list post about this. https://github.com/numpy/numpy/issues/28310 Thanks!
Ricardo Santos _______________________________________________ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-leave@python.org https://mail.python.org/mailman3//lists/numpy-discussion.python.org Member address: nathan12343@gmail.com
participants (2)
-
Nathan -
ricas28