Correct error of invalid axis arguments.
Hi All,
At the moment there are two error types raised when invalid axis arguments are encountered: IndexError and ValueError. I prefer ValueError for arguments, IndexError seems more appropriate when the bad axis value is used as an index. In any case, having mixed error types is inconvenient, but also inconvenient to change. Should we worry about that? If so, what should the error be? Note that some of the mixup arises because the axis values are not checked before use, in which case IndexError is raised.
Chuck
On Mo, 20160905 at 11:54 0600, Charles R Harris wrote:
Hi All,
At the moment there are two error types raised when invalid axis arguments are encountered: IndexError and ValueError. I prefer ValueError for arguments, IndexError seems more appropriate when the bad axis value is used as an index. In any case, having mixed error types is inconvenient, but also inconvenient to change. Should we worry about that? If so, what should the error be? Note that some of the mixup arises because the axis values are not checked before use, in which case IndexError is raised.
I am not too bothered about it myself, but yes, it is a bit annoying. My gut feeling on it would be to not worry about it much, unless we implement some more general input validator for the python side (which possibly could do even more like validate/convert input arrays all in one go). Putting explicit guards to every single python side function is of course possible too, but I am not quite convinced its worth the trouble.
 Sebastian
Chuck _______________________________________________ NumPyDiscussion mailing list NumPyDiscussion@scipy.org https://mail.scipy.org/mailman/listinfo/numpydiscussion
participants (2)

Charles R Harris

Sebastian Berg