Re: [Numpy-discussion] Closing resolved good-first-issues
Fri, 1 May 2020 18:05:14 Ralf Gommers
Hi Tina, thanks for pointing that out. I have added you to the triage
team,
so you are able to close issues that you already noticed are fixed. I'll have a look at labelling some new ones now.
These are the issues that have pull requests merged but still open, Please let me know if I am wrong else we can close these issues: - Issue #9476 https://github.com/numpy/numpy/issues/9476 - Issue #2802 https://github.com/numpy/numpy/issues/2802 - Issue #11875 https://github.com/numpy/numpy/issues/11875 - Issue #13114 https://github.com/numpy/numpy/issues/13114 - Issue #13758 https://github.com/numpy/numpy/issues/13758 Thanks and Regards Tina
On 3/5/20 1:39 pm, Tina Oberoi wrote:
These are the issues that have pull requests merged but still open, Please let me know if I am wrong else we can close these issues: - Issue #9476 https://github.com/numpy/numpy/issues/9476 - Issue #2802 https://github.com/numpy/numpy/issues/2802 - Issue #11875 https://github.com/numpy/numpy/issues/11875 - Issue #13114 https://github.com/numpy/numpy/issues/13114 - Issue #13758 https://github.com/numpy/numpy/issues/13758
Thanks and Regards Tina
Tina it would be helpful to directly comment on the issues in question. If you are unsure the issues are actually resolved, you can add a comment "Can we close this, probably resolved by ...". If you are sure they are resolved, go ahead and close them with a message "Resolved by ...". If it appears they are too complicated for the "good first issue" label, you can just remove the label. Matti
On Mon, May 4, 2020 at 8:40 AM Matti Picus
On 3/5/20 1:39 pm, Tina Oberoi wrote:
These are the issues that have pull requests merged but still open, Please let me know if I am wrong else we can close these issues: - Issue #9476 https://github.com/numpy/numpy/issues/9476 - Issue #2802 https://github.com/numpy/numpy/issues/2802 - Issue #11875 https://github.com/numpy/numpy/issues/11875 - Issue #13114 https://github.com/numpy/numpy/issues/13114 - Issue #13758 https://github.com/numpy/numpy/issues/13758
Thanks and Regards Tina
Thanks for this list Tina!
Tina it would be helpful to directly comment on the issues in question. If you are unsure the issues are actually resolved, you can add a comment "Can we close this, probably resolved by ...". If you are sure they are resolved, go ahead and close them with a message "Resolved by ...".
I agree with that advice, if it's clear-cut you can do this. Most cases were pretty complicated though to assess. If it appears they are too complicated for the "good first issue"
label, you can just remove the label.
A request to maintainers as well: please keep "good first issue" for actually easy things. 3 of these were easy (one of which turned into a hard one during the conversation), but 2 were definitely not. Cheers, Ralf
participants (3)
-
Matti Picus -
Ralf Gommers -
Tina Oberoi