Weird Travis-CI bugs in the release 1.7.x branch
Hi, I started to work on the release again and noticed weird failures at Travis-CI: https://github.com/numpy/numpy/pull/2782 The first commit (8a18fc7) should not trigger this failure: ====================================================================== FAIL: test_iterator.test_iter_array_cast ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/nose/case.py", line 197, in runTest self.test(*self.arg) File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py", line 836, in test_iter_array_cast assert_equal(i.operands[0].strides, (-96,8,-32)) File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py", line 252, in assert_equal assert_equal(actual[k], desired[k], 'item=%r\n%s' % (k,err_msg), verbose) File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py", line 314, in assert_equal raise AssertionError(msg) AssertionError: Items are not equal: item=0 ACTUAL: 96 DESIRED: -96 So I pushed a whitespace commit into the PR (516b478) yet it has the same failure. So it's there, it's not some random fluke at Travis. I created this testing PR: https://github.com/numpy/numpy/pull/2783 to try to nail it down. But I can't see what could have caused this, because the release branch was passing all tests last time I worked on it. Any ideas? Btw, I managed to reproduce the SPARC64 bug: https://github.com/numpy/numpy/issues/2668 so that's good. Now I just need to debug it. Ondrej P.S. My thesis was finally approved by the grad school today, doing some final changes took more time than expected, but I think that I am done now.
On 4 Dec 2012 02:27, "Ondřej Čertík" <ondrej.certik@gmail.com> wrote:
Hi,
I started to work on the release again and noticed weird failures at
Travis-CI: […]
File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
The problem is that Travis started installing numpy in all python virtualenvs by default, and our Travis build script just runs setup.py install, which is too dumb to notice that there is a numpy already installed and just overwrites it. The file mentioned above doesn't even exist in 1.7, it's left over from the 1.6 install. I did a PR to fix this in master a few days ago, you want to back port that. (Sorry for lack of link, I'm on my phone.)
P.S. My thesis was finally approved by the grad school today, doing some final changes took more time than expected, but I think that I am done now.
Congratulations Dr. Čertík! -n
On Mon, Dec 3, 2012 at 7:10 PM, Nathaniel Smith <njs@pobox.com> wrote:
On 4 Dec 2012 02:27, "Ondřej Čertík" <ondrej.certik@gmail.com> wrote:
Hi,
I started to work on the release again and noticed weird failures at Travis-CI:
[…]
File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
The problem is that Travis started installing numpy in all python virtualenvs by default, and our Travis build script just runs setup.py install, which is too dumb to notice that there is a numpy already installed and just overwrites it. The file mentioned above doesn't even exist in 1.7, it's left over from the 1.6 install.
I did a PR to fix this in master a few days ago, you want to back port that. (Sorry for lack of link, I'm on my phone.)
Thanks! I backported it in: https://github.com/numpy/numpy/pull/2786 Nice, I was not aware of the fact that "pip install ." fixes this problem with setup.py --- I've burned myself with this so many times already and I always forget about this bug.
P.S. My thesis was finally approved by the grad school today, doing some final changes took more time than expected, but I think that I am done now.
Congratulations Dr. Čertík!
Thanks. I am glad it's over. Ondrej
On Tue, Dec 4, 2012 at 8:14 AM, Ondřej Čertík <ondrej.certik@gmail.com> wrote:
On Mon, Dec 3, 2012 at 7:10 PM, Nathaniel Smith <njs@pobox.com> wrote:
On 4 Dec 2012 02:27, "Ondřej Čertík" <ondrej.certik@gmail.com> wrote:
Hi,
I started to work on the release again and noticed weird failures at Travis-CI:
[…]
File "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
The problem is that Travis started installing numpy in all python virtualenvs by default, and our Travis build script just runs setup.py install, which is too dumb to notice that there is a numpy already installed and just overwrites it. The file mentioned above doesn't even exist in 1.7, it's left over from the 1.6 install.
I did a PR to fix this in master a few days ago, you want to back port that. (Sorry for lack of link, I'm on my phone.)
Thanks! I backported it in:
https://github.com/numpy/numpy/pull/2786
Nice, I was not aware of the fact that "pip install ." fixes this problem with setup.py --- I've burned myself with this so many times already and I always forget about this bug.
It's fixed in the release branch now. So both master and the release branch pass all tests on Travis again. Thanks for your help. Ondrej
participants (2)
-
Nathaniel Smith -
Ondřej Čertík