Mailman 3 April 2016 - Pandas-dev

Re: [Pandas-dev] Thoughts on adopting a 1-PR-1-commit policy?
by Wes McKinney June 8, 2016

June 8, 2016

hey Jan, I'm adding the mailing list back. Several comments inline On Sun, Jan 17, 2016 at 1:09 AM, Jan Schulz <jasc(a)gmx.net> wrote: > Hi, > > Just a different opinion: I like having commits do one logical thing > and not squash multiple "logical complete"things together (this means > that commit is a logical step, not the PR and that the commits should > be clean and not contain "fixup", "typo" style commits). During the > categorical work, I found that a few times I regretted that I couldn't > go back to look up the specific change in a commit and look up what > and why that commit was done because it was all mixed up with the rest > of the squashed commits in that PR. > I'm not suggesting that you should have to squash your commits inside the PR. This only concerns how *patches are applied to pandas's master branch". Ideally, no squashing occurs inside the developer branch (so the "story", so to speak, about the patch is preserved), but what the Apache patch tool does is - Turns a multi-commit PR into a single-commit patch - Puts the individual commit hashes in the commit message; so you can always visit the original commits - Puts the description from the PR into the commit message - Cherry-picks instead of merging, so you can observe evolution of pandas/master in a clear and linear way > My feeling was always that squashes are performed because the rebases > are so hard because of multiple PRs fixing stuff in the same files at > the same time. If this refactorings come through (both better > separation of backend-frontend specific code and the suggested split > up of frame.py, etc), I think this is not so much a problem anymore. > > I'm not sure where the commit history with merges is a problem: during > balme (in github, never used git itself), I don't see any merges?! > Here is something that would be very hard: create release notes given the commit history. > So my suggestion would go in a different direction: better commits in > the PRs with proper commit messages (not only the headline but also > explanations in the message. > > Jan > -- > Jan Schulz > mail: jasc(a)gmx.net > web: http://www.katzien.de > > > On 17 January 2016 at 07:29, Wes McKinney <wesmckinn(a)gmail.com> wrote: >> The script performs the squashing automatically, so users can squash >> manually if they wish or let us do it. >> >> On Sat, Jan 16, 2016 at 8:11 PM, Jeff Reback <jeffreback(a)gmail.com> wrote: >>> seems find to use the cherry picking script >>> >>> though I don't think should relax users from squashing >>> >>>> On Jan 16, 2016, at 6:46 PM, Wes McKinney <wesmckinn(a)gmail.com> wrote: >>>> >>>> Copying the mailing list. Indeed makes rebasing unnecessary if there >>>> are no cherry-pick conflicts. >>>> >>>> On Sat, Jan 16, 2016 at 3:34 PM, Tom Augspurger >>>> <tom.augspurger88(a)gmail.com> wrote: >>>>> Rebasing can be tough for new contributors, so for that alone I'd say let's try it. >>>>> >>>>> -Tom >>>>> >>>>>> On Jan 16, 2016, at 5:20 PM, Wes McKinney <wesmckinn(a)gmail.com> wrote: >>>>>> >>>>>> I've grown very fond of the PR cherry-picking style used in many >>>>>> Apache projects. >>>>>> >>>>>> Here's an example of a very large commit to Apache Spark that was >>>>>> performed in this fashion: >>>>>> >>>>>> https://github.com/apache/spark/commit/2fe0a1aaeebbf7f60bd4130847d738c29f1e… >>>>>> >>>>>> If you compare pandas's commit history with a project like this, >>>>>> you'll see it is much easier to follow because there is one commit for >>>>>> each patch to the project, rather than a merge commit plus 1 or more >>>>>> merged commits (depending on whether the person merging the PR did an >>>>>> interactive rebase). >>>>>> >>>>>> The script to do this is not too complex, and is even less complex for >>>>>> pandas because we do not use JIRA: >>>>>> >>>>>> https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py >>>>>> >>>>>> I've been using a pared down version of the script in Ibis: >>>>>> >>>>>> https://github.com/cloudera/ibis/blob/master/dev/merge-pr.py >>>>>> >>>>>> Here is an example of what a merge commit with multiple subcommits >>>>>> looks like using this tool: >>>>>> >>>>>> https://github.com/cloudera/ibis/commit/eafabe060dcaaea0a6076342eaa374929b9… >>>>>> >>>>>> It's pretty easy to use: run the script and enter the PR # you are >>>>>> merging. It automatically squashes and closes the merged PR. >>>>>> >>>>>> Let me know if this is something that would interest the team. I know >>>>>> there are varying opinions on the GitHub Green Button =) >>>>>> >>>>>> - Wes >>>>>> _______________________________________________ >>>>>> Pandas-dev mailing list >>>>>> Pandas-dev(a)python.org >>>>>> https://mail.python.org/mailman/listinfo/pandas-dev >>>> _______________________________________________ >>>> Pandas-dev mailing list >>>> Pandas-dev(a)python.org >>>> https://mail.python.org/mailman/listinfo/pandas-dev >> _______________________________________________ >> Pandas-dev mailing list >> Pandas-dev(a)python.org >> https://mail.python.org/mailman/listinfo/pandas-dev

5 12

Empty table datasets in HDF5 (pytables)
by Damion Wilson April 22, 2016

April 22, 2016

In 2012, there was this issue: https://github.com/pydata/pandas/issues/1707 Which was patched: https://github.com/pydata/pandas/commit/603e5ae9f8c6dc7bd17e86f556c01820c6f… It now appears that this ability has been explicitly disabled, such that the pytables interface now checks for empty datasets and silently refuses to create the underlying HDF5 objects. The offending code is in pandas/io/pytables.py:_write_to_group() # we don't want to store a table node at all if are object is 0-len # as there are not dtypes if getattr(value, 'empty', None) and (format == 'table' or append): return I'm preparing a patch and pull request, but this is such a deliberate step that I'd like some clarification as to why this is so. Reenabling this behaviour in our production environment has the expected results with no obvious downsides. Can anyone provide a rationale for not introducing the patch/reenabling the behaviour ? Thanks in advance, Damion K. Wilson

1 0

Re: [Pandas-dev] Pandas-dev Digest, Vol 36, Issue 3
by s.celles＠gmail.com April 5, 2016

April 5, 2016

Hi, I'd be pleased to have a sticker too ;-) Kind regards Sébastien 2016-04-05 18:00 GMT+02:00 <pandas-dev-request(a)python.org>: > Send Pandas-dev mailing list submissions to > pandas-dev(a)python.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://mail.python.org/mailman/listinfo/pandas-dev > or, via email, send a message with subject or body 'help' to > pandas-dev-request(a)python.org > > You can reach the person managing the list at > pandas-dev-owner(a)python.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Pandas-dev digest..." > > > Today's Topics: > > 1. Re: Fwd: pandas logo (Sin Hrks) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Tue, 5 Apr 2016 12:27:36 +0900 > From: Sin Hrks <sinhrks(a)gmail.com> > To: Stephan Hoyer <shoyer(a)gmail.com> > Cc: Jeff Reback <jeff(a)reback.net>, "pandas-dev(a)python.org" > <pandas-dev(a)python.org> > Subject: Re: [Pandas-dev] Fwd: pandas logo > Message-ID: <8ABFEF97-A0ED-4905-947F-21EC601BC9B8(a)gmail.com> > Content-Type: text/plain; charset="us-ascii" > > I want it too! Looks nice:) > > > On Apr 5, 2016, at 9:14 AM, Stephan Hoyer <shoyer(a)gmail.com> wrote: > > > > Looks great -- much cleaner than the old one! Please send me a sticker > ;). > > > >> On Mon, Apr 4, 2016 at 4:08 PM, Jeff Reback <jeffreback(a)gmail.com> > wrote: > >> > >> > >> So the folks at NUMFocus needed stickers and our current pandas logo > was only an old .png that could be reproduced in > >> a vectorized graphic format. So they redid the logo to make a > vectorized graphic that would print. > >> > >> Attached are all of the logo graphics. > >> > >> Its pretty close to the old one and now comes in stacked/horizontal > formats. > >> > >> <pandas_horizontal_web.png><pandas-wht-stacked.png> > >> > >> > >> _______________________________________________ > >> Pandas-dev mailing list > >> Pandas-dev(a)python.org > >> https://mail.python.org/mailman/listinfo/pandas-dev > > > > _______________________________________________ > > Pandas-dev mailing list > > Pandas-dev(a)python.org > > https://mail.python.org/mailman/listinfo/pandas-dev >

2 1

Fwd: pandas logo
by Jeff Reback April 5, 2016

April 5, 2016

So the folks at NUMFocus needed stickers and our current pandas logo was only an old .png that could be reproduced in a vectorized graphic format. So they redid the logo to make a vectorized graphic that would print. Attached are all of the logo graphics. Its pretty close to the old one and now comes in stacked/horizontal formats. [image: Inline image 1][image: Inline image 2]

3 2