Thanks all for your comments here, some good points have been raised! The maintainers' guide <https://pandas.pydata.org/docs/dev/development/maintaining.html> doesn't have any guidelines around "needs triage", so I'll put something together based on the points brought up here On Wed, May 3, 2023 at 2:19 PM <pandas-dev-request@python.org> wrote:
Send Pandas-dev mailing list submissions to pandas-dev@python.org
To subscribe or unsubscribe via the World Wide Web, visit https://mail.python.org/mailman/listinfo/pandas-dev or, via email, send a message with subject or body 'help' to pandas-dev-request@python.org
You can reach the person managing the list at pandas-dev-owner@python.org
When replying, please edit your Subject line so it is more specific than "Re: Contents of Pandas-dev digest..."
Today's Topics:
1. Re: Triage (Richard Shadrach) 2. Re: Triage (Simon Hawkins)
----------------------------------------------------------------------
Message: 1 Date: Wed, 3 May 2023 08:05:18 -0400 From: Richard Shadrach <rhshadrach@gmail.com> To: Dea Mar?a <deamarialeon@gmail.com> Cc: Marc Garcia <garcia.marc@gmail.com>, pandas-dev <pandas-dev@python.org> Subject: Re: [Pandas-dev] Triage Message-ID: <CAJ= 56RJxsvWn+zbh_RCExq7LeMPvxQCKahy2oEUhLBo0xPFNHQ@mail.gmail.com> Content-Type: text/plain; charset="utf-8"
I've always thought triage is more than labeling an issue. If it's a bug, I consider triage as confirming it (a) exists on main (even if the user says they did) and (b) confirming it is indeed undesired behavior. If it's reported as a regression then in addition I think it should be confirmed it does exist on the previous version of pandas.
All of this can be time intensive. However, I can quickly go through the recently reported issues and appropriately label them so that they are more visible to other developers who specialize in those areas of the code. When I do this but not the above steps, I leave the Needs Triage on.
I'm interested to hear thoughts and feedback here, and if there is a more desirable way.
Best, Richard
On Wed, May 3, 2023, 06:07 Dea Mar?a <deamarialeon@gmail.com> wrote:
I just meant that in many cases people forget to remove the ?needs triage? label after having done the triage.
On Wed, May 3, 2023 at 11:43?AM Marc Garcia <garcia.marc@gmail.com> wrote:
Not sure if other set the label manually, but I assumed in most cases the label is applied automatically by our issue templates. Regular users can't set labels themselves afaik. And if I set labels manually, I consider I already did the triage so I don't set that label.
Thanks for letting us know, this is helpful, if you still find the issue after the message, it may be worth discussing the workflow with the exact person (in the issue log you should be able to see who changes the labels.
On Wed, May 3, 2023, 10:21 Dea Mar?a <deamarialeon@gmail.com> wrote:
Dear All,
If you are helping with triage, it would be nice if you could also remove the ?needs triage? label after labelling the issue.
Sometimes the person who reported the issue also sets the labels. So, it is not obvious if the labeling was done by a core-dev or not until I open the issue.
Sure, it only takes a few seconds to find that my ?extremely important? help ;-) is not needed. But newcomers? time is also valuable.
Please help us help you. :)
Thanks,
Dea _______________________________________________ Pandas-dev mailing list Pandas-dev@python.org https://mail.python.org/mailman/listinfo/pandas-dev
_______________________________________________ Pandas-dev mailing list Pandas-dev@python.org https://mail.python.org/mailman/listinfo/pandas-dev
Maybe worth expanding on confirming the bug bit... If a bug is in recently added behaviour, then probably worth cc the author of the enhancement otherwise if the bug looks to be long-standing, then chances are that it has been reported before or that something related has been discussed. Although it can be time consuming to search/review other issues during the triage process (and sometimes a rabbit hole), closing duplicates or consolidation of issues is worthwhile. On Wed, 3 May 2023 at 16:10, Marco Gorelli <m.e.gorelli@gmail.com> wrote:
Thanks all for your comments here, some good points have been raised!
The maintainers' guide <https://pandas.pydata.org/docs/dev/development/maintaining.html> doesn't have any guidelines around "needs triage", so I'll put something together based on the points brought up here
On Wed, May 3, 2023 at 2:19 PM <pandas-dev-request@python.org> wrote:
Send Pandas-dev mailing list submissions to pandas-dev@python.org
To subscribe or unsubscribe via the World Wide Web, visit https://mail.python.org/mailman/listinfo/pandas-dev or, via email, send a message with subject or body 'help' to pandas-dev-request@python.org
You can reach the person managing the list at pandas-dev-owner@python.org
When replying, please edit your Subject line so it is more specific than "Re: Contents of Pandas-dev digest..."
Today's Topics:
1. Re: Triage (Richard Shadrach) 2. Re: Triage (Simon Hawkins)
----------------------------------------------------------------------
Message: 1 Date: Wed, 3 May 2023 08:05:18 -0400 From: Richard Shadrach <rhshadrach@gmail.com> To: Dea Mar?a <deamarialeon@gmail.com> Cc: Marc Garcia <garcia.marc@gmail.com>, pandas-dev <pandas-dev@python.org> Subject: Re: [Pandas-dev] Triage Message-ID: <CAJ= 56RJxsvWn+zbh_RCExq7LeMPvxQCKahy2oEUhLBo0xPFNHQ@mail.gmail.com> Content-Type: text/plain; charset="utf-8"
I've always thought triage is more than labeling an issue. If it's a bug, I consider triage as confirming it (a) exists on main (even if the user says they did) and (b) confirming it is indeed undesired behavior. If it's reported as a regression then in addition I think it should be confirmed it does exist on the previous version of pandas.
All of this can be time intensive. However, I can quickly go through the recently reported issues and appropriately label them so that they are more visible to other developers who specialize in those areas of the code. When I do this but not the above steps, I leave the Needs Triage on.
I'm interested to hear thoughts and feedback here, and if there is a more desirable way.
Best, Richard
On Wed, May 3, 2023, 06:07 Dea Mar?a <deamarialeon@gmail.com> wrote:
I just meant that in many cases people forget to remove the ?needs triage? label after having done the triage.
On Wed, May 3, 2023 at 11:43?AM Marc Garcia <garcia.marc@gmail.com> wrote:
Not sure if other set the label manually, but I assumed in most cases the label is applied automatically by our issue templates. Regular users can't set labels themselves afaik. And if I set labels manually, I consider I already did the triage so I don't set that label.
Thanks for letting us know, this is helpful, if you still find the issue after the message, it may be worth discussing the workflow with the exact person (in the issue log you should be able to see who changes the labels.
On Wed, May 3, 2023, 10:21 Dea Mar?a <deamarialeon@gmail.com> wrote:
Dear All,
If you are helping with triage, it would be nice if you could also remove the ?needs triage? label after labelling the issue.
Sometimes the person who reported the issue also sets the labels. So, it is not obvious if the labeling was done by a core-dev or not until I open the issue.
Sure, it only takes a few seconds to find that my ?extremely important? help ;-) is not needed. But newcomers? time is also valuable.
Please help us help you. :)
Thanks,
Dea _______________________________________________ Pandas-dev mailing list Pandas-dev@python.org https://mail.python.org/mailman/listinfo/pandas-dev
_______________________________________________ Pandas-dev mailing list Pandas-dev@python.org https://mail.python.org/mailman/listinfo/pandas-dev
participants (2)
-
Marco Gorelli -
Simon Hawkins