I think we can include 'lib' in so_prefix of all Posix platforms, is
that right?
I still have noI think it’s because `rpython.translator.platform.Platform._finish_linking` function doesn’t include `so_prefixes` on the platform in the first place, so for tests like `test_lib_on_libpaths` will generate a shared library called `c_file.dylib`. Then in `get_ctypes_callable` function it prepends the library name with the currently empty prefix on Darwin platform, it can find the shared library file with the constructed absolute path. So the proposed fix will still work because it includes both ‘lib’ and empty prefix.
clue why all our tests still pass on OS/X
On 6 Dec. 2016, at 20:48, Armin Rigo <armin.rigo@gmail.com> wrote:
Hi John,
On 6 December 2016 at 03:06, John Zhang <John.Zhang@anu.edu.au> wrote:
So I think it’s right to make a simple fix as suggested in the patch to
include ‘lib’ in the so_prefix on Darwin platforms.
I think we can include 'lib' in so_prefix of all Posix platforms, is
that right? It's already in linux, bsd and cygwin. I still have no
clue why all our tests still pass on OS/X (apart from the skipped one
you found) but I guess that's a fine fix anyway.
A bientôt,
Armin.