[pypy-dev] src/pypy/module/test/test_sysmodule.py

July 5, 2004

      Over here we have somebody who likes to write unittests like this:

    def test_sys_in_modules(self):
        import sys
        modules = sys.modules
        self.failUnless('sys' in modules, "An entry for sys "
                                        "is not in sys.modules.")
        sys2 = sys.modules['sys']
        self.failUnless(sys is sys2, "import sys is not sys.modules[sys].")
    def test_builtin_in_modules(self):
        import sys
        modules = sys.modules
        self.failUnless('__builtin__' in modules, "An entry for __builtin__ "
                                                    "is not in sys.modules.")
        import __builtin__
        builtin2 = sys.modules['__builtin__']
        self.failUnless(__builtin__ is builtin2, "import __builtin__ "
                                            "is not sys.modules[__builtin__].")

see the fail messages that are two strings, not separated by anything, on 2 separate
lines.

My poor program converts them to:

    def test_sys_in_modules(self):
        import sys
        modules = sys.modules
        assert 'sys' in modules, "An entry for sys "
                                        "is not in sys.modules."

I propose we consider src/pypy/module/test/test_sysmodule.py broken, and we fix that
file, rather than make my program wrap them in parentheses.

Any objections?

Laura

[pypy-dev] src/pypy/module/test/test_sysmodule.py

Laura Creighton