Hi Carl,

At the moment this shouldn't affect anything, this function is only called in other places with loops. However, this is based on the same logic we used in getnextframe_nohidden, and I believe is a first step in making sys.exc_info() not explode stuff :)

Alex


On Thu, Jan 31, 2013 at 11:44 PM, Carl Friedrich Bolz <cfbolz@gmx.de> wrote:

Hi Alex,

This needs a corresponding test in test_pypy_c.py

Cheers,

Carl Friedrich



alex_gaynor <noreply@buildbot.pypy.org> wrote:
Author: Alex Gaynor <alex.gaynor@gmail.com>
Branch:
Changeset: r60800:9aeefdb4841d
Date: 2013-01-31 17:54 -0800
http://bitbucket.org/pypy/pypy/changeset/9aeefdb4841d/

Log: hidden frames are fairly rare, it's ok to unroll this

diff --git a/pypy/interpreter/executioncontext.py b/pypy/interpreter/executioncontext.py
--- a/pypy/interpreter/executioncontext.py
+++ b/pypy/interpreter/executioncontext.py
@@ -40,6 +40,7 @@
def gettopframe(self):
return self.topframeref()

+ @jit.unroll_safe
def gettopframe_nohidden(self):
frame = self.topframeref()
while frame and frame.hide():





_______________________________________________
pypy-dev mailing list
pypy-dev@python.org
http://mail.python.org/mailman/listinfo/pypy-dev




--
"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero