On 21/11/18 7:30 am, Donald Stufft wrote:
On Nov 20, 2018, at 11:29 PM, Armin Rigo <armin.rigo@gmail.com <mailto:armin.rigo@gmail.com>> wrote:
Hi Matti,
On 20/11/2018, Matti Picus <matti.picus@gmail.com <mailto:matti.picus@gmail.com>> wrote:
On 16/11/18 4:50 pm, Donald Stufft wrote: If you have extra time, maybe you could even try the unicode-utf8-py3 nightly, http://buildbot.pypy.org/nightly/unicode-utf8-py3 which is a WIP to use utf8 internally everywhere without converting back and forth to unicode. It would be nice to know if that is any faster (or even works).
That's even assuming the slow-down is in any way related to unicodes. I think we might as well assume that the slowdown is not related to any change in the code and due to other random effects. If we want to know more precisely what is going on, the first step would be to get the real code that is unexpectedly slower on one pypy than on the other, and try to run it ourselves---e.g. inside gdb, to start with.
It’s in a branch on Github https://github.com/pypa/warehouse/pull/5057 which runs everything in docker, ``make build`` then ``make serve``, and then in another terminal ``make tests`` runs the tests. That may make it. A lot harder to get a gdb going though :( It’s easy to switch what Nightly is being used though, that’s just a line in the Dockerfile to pick what download from PyPy to use.
I’m going to go ahead and test those other nightlies later today though.
it seems my call to test the unicode-utf8 branch may have been premature, it crashes on lib-python tests having to do with test_codeencodings_*.py. Maybe not worth your time yet. Matti