Scott Dial wrote:
Maciek Fijalkowski wrote:
Ok, I'm coming back to issue. I didn't find on windows status page any failures related to that :-(
Could you point me to some? Also seems that examples doesn't work on windows. Bad.
I've not tried to actually run the examples myself, so I hadn't realized that. With respect to failures, the underlying failures that would cause the need for PDB to run have been corrected. I think it would be silly to introduce an intentionally erroring test case for this purpose, so you'll have to trust me on the logic being broken.
The problem as I see it is that configuration parameters are not being passed around in a consistent way. And the logic of rpython2javascript() is to use whatever "use_pdb" says ignoring the "jsconfig" entirely. It would perhaps make enough sense to say that they both have to be True for the debugger to be run. However, I think there is a larger issue here with the reason "use_pdb" needs to exist at all.
-Scott
Ah, I think I got it (finally!). Ok, the idea was to have use_pdb override value in config, to be sure that in some places this config is not used, even though it defines use_pdb=False. I'll try to fix the logic than to use jsconfig.use_pdb in first place and override it. Thanks, Fijal