On Fri, 20 Jul 2007 14:52:54 +0200 Armin Rigo wrote:

Hi Simon,

On Thu, Jul 19, 2007 at 06:31:17PM -0700, Simon Burton wrote:

...

The lltype's are very strict about types.

Indeed, it seems worthwhile to loosen this restriction at least for the purpose of calling external functions... Not sure how, but there are possible hacks at least.

Following some hints from Samuele, I am trying to wrap such functions in another function that does some casting. Here is my first attempt. It does no casting, but i already can't get it to work. def softwrapper(funcptr, arg_tps): unrolling_arg_tps = unrolling_iterable(enumerate(arg_tps)) def softfunc(*args): real_args = tuple([args[i] for i, tp in unrolling_arg_tps]) result = funcptr(*real_args) return softfunc where funcptr comes from a call to llexternal. It seems the tuple construction should not work (each args[i] is a different type), but instead i get: CallPatternTooComplex': '*' argument must be SomeTuple. Um.. My only guess now is to malloc a TUPLE_TYPE.. ?!? no idea.. (I am really sick of code generation and hope it doesn't come to that). Simon.

Simon Burton wrote:

On Wed, 22 Aug 2007 15:23:40 -0700 Simon Burton wrote:

...

Following some hints from Samuele, I am trying to wrap such functions in another function that does some casting.

Here is the latest:

def softwrapper(funcptr, arg_tps): unrolling_arg_tps = unrolling_iterable(enumerate(arg_tps)) def softfunc(*args): real_args = () for i, tp in unrolling_arg_tps: real_args = real_args + (args[i],) result = funcptr(*real_args) return result return softfunc

When applied to llexternal's that have pointer-to-struct args the generated c code breaks; it decides to declare&use anonymous structs:

long pypy_g_softfunc_star2_1(struct pypy__cairo_surface0 *l_stararg0_7, struct pypy_array3 *l_stararg1_7) { long l_v492;

block0: l_v492 = cairo_surface_write_to_png(l_stararg0_7, l_stararg1_7); goto block1;

block1: RPY_DEBUG_RETURN(); return l_v492; }

where cairo_surface_write_to_png is declared:

cairo_surface_write_to_png (cairo_surface_t *surface, const char *filename);

I wonder if the annotator is getting confused by the real_args tuple growing... _______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev

:.

You need to create the structure which you push by hand. As well as array argument. :.

Simon Burton wrote:

On Thu, 23 Aug 2007 19:13:26 +0200 Maciek Fijalkowski wrote:

...

You need to create the structure which you push by hand. As well as array argument.

No, structure comes from a call to another llexternal. It makes no sense to clone it. It should be an opaque struct anyway.

Simon.

There is a COpaque and COpaquePtr for opaque structures. cheers, fijal :.