First off, mea culpa. I'm not sure how unpardonable a sin this is, but I now realize that my recent checkins make the test_all.py script fail. This (probably) isn't as bad as it sounds. Firstly, it works fine for the trivial object space - it only has problems with StdObjSpace. Secondly, it's only one file that has problems (test_exec.py), and it seems that the problems were there before the checkin, it was just that the unittest wasn't picking them up. (It was running at interpreter level, not at application level as it should be - and no surprise here; CPython handles the exec statement perfectly :) I'd try to fix the errors, but they seem to be complex, and not directly due to the EXEC_STMT opcode - as I said, TrivialObjSpace passes. You can run test_all for yourself on revision 839+, but here is a synopsis of the errors: * The StdObjSpace dictionary does not have a "has_key" function attribute. * You get a "Type Error: an integer is required" when executing a code object. This error message occurs twice in the standard obj space [objspace.py, concretespace.py], and an unknown number of times in CPython. - We need more specific error messages. * An exception within an exec statement does not bubble up to the caller. - AppTestCase needs more specific messages with self.AssertRaises calls. - Currently it only gives a blank AssertionError (with no message). * Don't pass an integer as the local dictionary to the exec statement. (but an integer for the global dict works fine) That's about as far as I can go for now. I hope nobody minds that I checked in code that gives error messages. The best I can say in my defense is that it was broken before the checkin. Safe travels to all the sprinters, -Rocco __________________________________________________________________ McAfee VirusScan Online from the Netscape Network. Comprehensive protection for your entire computer. Get your free trial today! http://channels.netscape.com/ns/computing/mcafee/index.jsp?promo=393397 Get AOL Instant Messenger 5.1 free of charge. Download Now! http://aim.aol.com/aimnew/Aim/register.adp?promo=380455
roccomoretti@netscape.net (Rocco Moretti) writes:
First off, mea culpa.
I'm not sure how unpardonable a sin this is, but I now realize that my recent checkins make the test_all.py script fail. This (probably) isn't as bad as it sounds. Firstly, it works fine for the trivial object space - it only has problems with StdObjSpace. Secondly, it's only one file that has problems (test_exec.py), and it seems that the problems were there before the checkin, it was just that the unittest wasn't picking them up. (It was running at interpreter level, not at application level as it should be - and no surprise here; CPython handles the exec statement perfectly :)
I'd try to fix the errors, but they seem to be complex, and not directly due to the EXEC_STMT opcode - as I said, TrivialObjSpace passes.
Can you drop into IRC? #pypy on irc.openproject.net. I'm not doing much right now, we can try and fix this. Or maybe you have already? I don't see any failures.
You can run test_all for yourself on revision 839+, but here is a synopsis of the errors:
* The StdObjSpace dictionary does not have a "has_key" function attribute. * You get a "Type Error: an integer is required" when executing a code object. This error message occurs twice in the standard obj space [objspace.py, concretespace.py], and an unknown number of times in CPython. - We need more specific error messages. * An exception within an exec statement does not bubble up to the caller. - AppTestCase needs more specific messages with self.AssertRaises calls. - Currently it only gives a blank AssertionError (with no message).
I have changes for this that need polishing. As they're on my peecee and not my laptop, it would probably be a good idea if I checked them in before leaving :-) Cheers, M. -- For every complex problem, there is a solution that is simple, neat, and wrong. -- H. L. Mencken
Michael Hudson <mwh@python.net> writes:
roccomoretti@netscape.net (Rocco Moretti) writes:
First off, mea culpa.
I'm not sure how unpardonable a sin this is, but I now realize that my recent checkins make the test_all.py script fail. This (probably) isn't as bad as it sounds. Firstly, it works fine for the trivial object space - it only has problems with StdObjSpace. Secondly, it's only one file that has problems (test_exec.py), and it seems that the problems were there before the checkin, it was just that the unittest wasn't picking them up. (It was running at interpreter level, not at application level as it should be - and no surprise here; CPython handles the exec statement perfectly :)
I'd try to fix the errors, but they seem to be complex, and not directly due to the EXEC_STMT opcode - as I said, TrivialObjSpace passes.
Can you drop into IRC? #pypy on irc.openproject.net. I'm not doing much right now, we can try and fix this.
Or maybe you have already? I don't see any failures.
Oh, now I do. I wonder what the test was doing there? I don't usually run the appspace tests, as some of them take so long.
I have changes for this that need polishing. As they're on my peecee and not my laptop, it would probably be a good idea if I checked them in before leaving :-)
Done -- try running the tests now, I think you'll like the changes :-) Cheers, M. --
so python will fork if activestate starts polluting it? I find it more relevant to speculate on whether Python would fork if the merpeople start invading our cities riding on the backs of giant king crabs. -- Brian Quinlan, comp.lang.python
roccomoretti@netscape.net (Rocco Moretti) writes:
I'd try to fix the errors, but they seem to be complex, and not directly due to the EXEC_STMT opcode - as I said, TrivialObjSpace passes.
I have fixed the errors, and you were right :-) Cheers, M. -- Well, you pretty much need Microsoft stuff to get misbehaviours bad enough to actually tear the time-space continuum. Luckily for you, MS Internet Explorer is available for Solaris. -- Calle Dybedahl, alt.sysadmin.recovery
participants (2)
-
Michael Hudson -
roccomoretti＠netscape.net