Re: [pypy-dev] [pypy-commit] pypy py3k: disable interp level W_IntObject tests
why is W_IntObject not used in py3k? it should just have a different typedef On Fri, Apr 5, 2013 at 3:10 AM, pjenvey <noreply@buildbot.pypy.org> wrote:
Author: Philip Jenvey <pjenvey@underboss.org> Branch: py3k Changeset: r63038:b0b275ecce2a Date: 2013-04-04 18:08 -0700 http://bitbucket.org/pypy/pypy/changeset/b0b275ecce2a/
Log: disable interp level W_IntObject tests
diff --git a/pypy/objspace/std/test/test_intobject.py b/pypy/objspace/std/test/test_intobject.py --- a/pypy/objspace/std/test/test_intobject.py +++ b/pypy/objspace/std/test/test_intobject.py @@ -5,8 +5,10 @@ from rpython.rlib.rarithmetic import r_uint, is_valid_int from rpython.rlib.rbigint import rbigint
+class TestW_IntObject:
-class TestW_IntObject: + def setup_class(cls): + py.test.skip("W_IntObject was replaced w/ W_LongObject in py3k")
def _longshiftresult(self, x): """ calculate an overflowing shift """ _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit
At one point it was still used like that but it was a bit of a mess So we've killed its usage so everything works sanely around W_LongObject, then we'll need to introduce either it back without the accompanying mess, or more likely introduce a W_LongObject variant as a replacement. We already have a 'SmallLong' variant but it's a larger longlong, (SmallerLong?). -- Philip Jenvey On Apr 5, 2013, at 2:08 AM, Maciej Fijalkowski wrote:
why is W_IntObject not used in py3k? it should just have a different typedef
On Fri, Apr 5, 2013 at 3:10 AM, pjenvey <noreply@buildbot.pypy.org> wrote:
Author: Philip Jenvey <pjenvey@underboss.org> Branch: py3k Changeset: r63038:b0b275ecce2a Date: 2013-04-04 18:08 -0700 http://bitbucket.org/pypy/pypy/changeset/b0b275ecce2a/
Log: disable interp level W_IntObject tests
diff --git a/pypy/objspace/std/test/test_intobject.py b/pypy/objspace/std/test/test_intobject.py --- a/pypy/objspace/std/test/test_intobject.py +++ b/pypy/objspace/std/test/test_intobject.py @@ -5,8 +5,10 @@ from rpython.rlib.rarithmetic import r_uint, is_valid_int from rpython.rlib.rbigint import rbigint
+class TestW_IntObject:
-class TestW_IntObject: + def setup_class(cls): + py.test.skip("W_IntObject was replaced w/ W_LongObject in py3k")
def _longshiftresult(self, x): """ calculate an overflowing shift """ _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit
pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
It shouldn't have a different typedef, they should just share the same typedef, and use that indirect_method thing you created. Alex On Fri, Apr 5, 2013 at 1:26 PM, Philip Jenvey <pjenvey@underboss.org> wrote:
At one point it was still used like that but it was a bit of a mess
So we've killed its usage so everything works sanely around W_LongObject, then we'll need to introduce either it back without the accompanying mess, or more likely introduce a W_LongObject variant as a replacement. We already have a 'SmallLong' variant but it's a larger longlong, (SmallerLong?).
-- Philip Jenvey
On Apr 5, 2013, at 2:08 AM, Maciej Fijalkowski wrote:
why is W_IntObject not used in py3k? it should just have a different typedef
Author: Philip Jenvey <pjenvey@underboss.org> Branch: py3k Changeset: r63038:b0b275ecce2a Date: 2013-04-04 18:08 -0700 http://bitbucket.org/pypy/pypy/changeset/b0b275ecce2a/
Log: disable interp level W_IntObject tests
diff --git a/pypy/objspace/std/test/test_intobject.py b/pypy/objspace/std/test/test_intobject.py --- a/pypy/objspace/std/test/test_intobject.py +++ b/pypy/objspace/std/test/test_intobject.py @@ -5,8 +5,10 @@ from rpython.rlib.rarithmetic import r_uint, is_valid_int from rpython.rlib.rbigint import rbigint
+class TestW_IntObject:
-class TestW_IntObject: + def setup_class(cls): + py.test.skip("W_IntObject was replaced w/ W_LongObject in
On Fri, Apr 5, 2013 at 3:10 AM, pjenvey <noreply@buildbot.pypy.org> wrote: py3k")
def _longshiftresult(self, x): """ calculate an overflowing shift """ _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit
_______________________________________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
_______________________________________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
-- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: 125F 5C67 DFE9 4084
participants (3)
-
Alex Gaynor -
Maciej Fijalkowski -
Philip Jenvey