ndarray-subtype branch looking for review
The ndarray-branch passes tests both translated and untranslated. I ran it through the numpy test suite as well, specifically the matrix class tests, and it seems to pass them. Would anyone like to review, or should I just go ahead and merge? Specifically, I may have missed some w_ prefixes on app-level instances, or may not have tested all the code paths, and I had to hack the FakeSpace in compile.py to allow subclassing. Matti
I could do it. Is there a way to get a full diff of the changes about to be merged? 2013/7/16 Matti Picus <matti.picus@gmail.com>
The ndarray-branch passes tests both translated and untranslated. I ran it through the numpy test suite as well, specifically the matrix class tests, and it seems to pass them. Would anyone like to review, or should I just go ahead and merge? Specifically, I may have missed some w_ prefixes on app-level instances, or may not have tested all the code paths, and I had to hack the FakeSpace in compile.py to allow subclassing. Matti ______________________________**_________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/**mailman/listinfo/pypy-dev<http://mail.python.org/mailman/listinfo/pypy-dev>
-- Amaury Forgeot d'Arc
2013/7/16 Amaury Forgeot d'Arc <amauryfa@gmail.com>
I could do it. Is there a way to get a full diff of the changes about to be merged?
Ok, found it. https://bitbucket.org/pypy/pypy/compare/ndarray-subtype..default#diff -- Amaury Forgeot d'Arc
you go to your checkout (default), you do hg merge <branch name> and then hg diff. if you don't like it, you do hg up -C to clean stuff up. Easy to do in a separate dir (I suggest hg share for that) On Tue, Jul 16, 2013 at 7:17 PM, Amaury Forgeot d'Arc <amauryfa@gmail.com> wrote:
I could do it. Is there a way to get a full diff of the changes about to be merged?
2013/7/16 Matti Picus <matti.picus@gmail.com>
The ndarray-branch passes tests both translated and untranslated. I ran it through the numpy test suite as well, specifically the matrix class tests, and it seems to pass them. Would anyone like to review, or should I just go ahead and merge? Specifically, I may have missed some w_ prefixes on app-level instances, or may not have tested all the code paths, and I had to hack the FakeSpace in compile.py to allow subclassing. Matti _______________________________________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
-- Amaury Forgeot d'Arc
_______________________________________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
2013/7/17 Maciej Fijalkowski <fijall@gmail.com>
you go to your checkout (default), you do hg merge <branch name> and then hg diff. if you don't like it, you do hg up -C to clean stuff up. Easy to do in a separate dir (I suggest hg share for that)
Actually I created a Pull Request: https://bitbucket.org/pypy/pypy/pull-request/164/ndarray-subtype-branch-revi... Easy to comment on each diff line. -- Amaury Forgeot d'Arc
On 07/17/2013 06:36 PM, Amaury Forgeot d'Arc wrote:
2013/7/17 Maciej Fijalkowski <fijall@gmail.com <mailto:fijall@gmail.com>>
you go to your checkout (default), you do hg merge <branch name> and then hg diff. if you don't like it, you do hg up -C to clean stuff up. Easy to do in a separate dir (I suggest hg share for that)
Actually I created a Pull Request: https://bitbucket.org/pypy/pypy/pull-request/164/ndarray-subtype-branch-revi... Easy to comment on each diff line.
-- Amaury Forgeot d'Arc Thanks for the review. How do I commit changes? Can I just commit to the branch, or should I do something on the pull request? Matti
participants (3)
-
Amaury Forgeot d'Arc -
Maciej Fijalkowski -
Matti Picus