Re: [pypy-dev] [pypy-svn] r66150 - pypy/trunk/pypy/tool
fijal@codespeak.net wrote:
try: - BaseException + BaseException = BaseException except NameError: BaseException = Exception
this clearly show that you didn't write a test (or you didn't run it, if it's already there). Could you please try to follow tdd a bit more closely, especially on trunk?
On Wed, Jul 8, 2009 at 9:24 AM, Antonio Cuni<anto.cuni@gmail.com> wrote:
fijal@codespeak.net wrote:
try: - BaseException + BaseException = BaseException except NameError: BaseException = Exception
this clearly show that you didn't write a test (or you didn't run it, if it's already there). Could you please try to follow tdd a bit more closely, especially on trunk?
It's about 2.4 vs 2.5. I have no clue how to test it correctly.
On Wed, Jul 08, 2009 at 10:02 -0600, Maciej Fijalkowski wrote:
On Wed, Jul 8, 2009 at 9:24 AM, Antonio Cuni<anto.cuni@gmail.com> wrote:
fijal@codespeak.net wrote:
try: - BaseException + BaseException = BaseException except NameError: BaseException = Exception
this clearly show that you didn't write a test (or you didn't run it, if it's already there). Could you please try to follow tdd a bit more closely, especially on trunk?
It's about 2.4 vs 2.5. I have no clue how to test it correctly.
there is py.builtin.BaseException which maybe can help. holger
On Wed, Jul 8, 2009 at 1:15 PM, holger krekel<holger@merlinux.eu> wrote:
On Wed, Jul 08, 2009 at 10:02 -0600, Maciej Fijalkowski wrote:
On Wed, Jul 8, 2009 at 9:24 AM, Antonio Cuni<anto.cuni@gmail.com> wrote:
fijal@codespeak.net wrote:
try: - BaseException + BaseException = BaseException except NameError: BaseException = Exception
this clearly show that you didn't write a test (or you didn't run it, if it's already there). Could you please try to follow tdd a bit more closely, especially on trunk?
It's about 2.4 vs 2.5. I have no clue how to test it correctly.
there is py.builtin.BaseException which maybe can help.
holger
ah cool. I was looking at py.compat and didn't find it. Cool, we can remove it now :)
participants (3)
-
Antonio Cuni
-
holger krekel
-
Maciej Fijalkowski