Hi all, apparently i am one of the people who happily add spaces at the end of lines (more or less unconciously but i think it also relates to my vim usage patterns, whatever). I remember Armin complained once about these extra spaces. The main problem with these extra spaces is that if a someone's editor automatically scraps those whitespaces (like apparently, Armin's emacs did) then that someone will produce large unmeaningful diffs. Now my question is, do we want to "enforce" or at least state in our coding-style document one policy or the other? I see two options: 1. you should NOT use editor settings that scrap trailing whitespace on source code or documentation. You will note "wrong" editor settings when you see 'svn diff's ala:: - some line content + some line content which indicate that you only changed whitespace. or 2. you should use editor settings that scrap trailing whitespace on source code and documentation Obviously, the second option should be accompanied by a monster-commit changing all those lines in one go. What do you think? cheers, holger
hpk@trillke.net (holger krekel) writes:
Now my question is, do we want to "enforce" or at least state in our coding-style document one policy or the other? I see two options:
1. you should NOT use editor settings that scrap trailing whitespace on source code or documentation. You will note "wrong" editor settings when you see 'svn diff's ala::
- some line content + some line content
which indicate that you only changed whitespace.
or
2. you should use editor settings that scrap trailing whitespace on source code and documentation
Obviously, the second option should be accompanied by a monster-commit changing all those lines in one go.
What do you think?
Option 2), with the added detail of running the reindent.py script over the entire codebase every so often (as Tim does for Python). I've wanted to do this for ages, but have always been too chicken :) Cheers, mwh -- It is time-consuming to produce high-quality software. However, that should not alone be a reason to give up the high standards of Python development. -- Martin von Loewis, python-dev
On Thu, Apr 21, 2005 at 19:52 +0100, Michael Hudson wrote:
hpk@trillke.net (holger krekel) writes:
2. you should use editor settings that scrap trailing whitespace on source code and documentation
Obviously, the second option should be accompanied by a monster-commit changing all those lines in one go.
What do you think?
Option 2), with the added detail of running the reindent.py script over the entire codebase every so often (as Tim does for Python).
Is there a reason to not run it more or less immediately after each checkin? This way a commiter could be appropriately embarassed.
I've wanted to do this for ages, but have always been too chicken :)
same here, even more after trying it for fun on the pypy-tree. cheers, holger
On 21 Apr 2005, at 20:19, holger krekel wrote:
On Thu, Apr 21, 2005 at 19:52 +0100, Michael Hudson wrote:
hpk@trillke.net (holger krekel) writes:
2. you should use editor settings that scrap trailing whitespace on source code and documentation
Obviously, the second option should be accompanied by a monster-commit changing all those lines in one go.
What do you think?
Option 2), with the added detail of running the reindent.py script over the entire codebase every so often (as Tim does for Python).
Is there a reason to not run it more or less immediately after each checkin? This way a commiter could be appropriately embarassed.
If it could be so arranged, that sounds good.
I've wanted to do this for ages, but have always been too chicken :)
same here, even more after trying it for fun on the pypy-tree.
It was 3000 lines of diff 18 months ago... Cheers, mwh
torsdag 21 april 2005 20.52 skrev Michael Hudson:
hpk@trillke.net (holger krekel) writes:
Now my question is, do we want to "enforce" or at least state in our coding-style document one policy or the other? I see two options:
1. you should NOT use editor settings that scrap trailing whitespace on source code or documentation. You will note "wrong" editor settings when you see 'svn diff's ala::
- some line content + some line content
which indicate that you only changed whitespace.
or
2. you should use editor settings that scrap trailing whitespace on source code and documentation
Obviously, the second option should be accompanied by a monster-commit changing all those lines in one go.
What do you think?
Option 2), with the added detail of running the reindent.py script over the entire codebase every so often (as Tim does for Python).
+2 (one for me and one for Laura) Jacob
Jacob Hallen wrote: ...
Option 2), with the added detail of running the reindent.py script over the entire codebase every so often (as Tim does for Python).
+2 (one for me and one for Laura)
+1 from me, too -- Christian Tismer :^) <mailto:tismer@stackless.com> tismerysoft GmbH : Have a break! Take a ride on Python's Johannes-Niemeyer-Weg 9A : *Starship* http://starship.python.net/ 14109 Berlin : PGP key -> http://wwwkeys.pgp.net/ work +49 30 802 86 56 mobile +49 173 24 18 776 fax +49 30 80 90 57 05 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/
Hi, On Thu, Apr 21, 2005 at 08:28:21PM +0200, holger krekel wrote:
Now my question is, do we want to "enforce" or at least state in our coding-style document one policy or the other?
I'm not too concerned about a few dummy diff entries, even though I'm usually avoiding to kill trailing whitespace. I don't see the point of strict policies as long as the source code base is roughly consistent, and I think that it is. This is both about trailing whitespace and indentation -- I mean, we know that indentation is 4 spaces and we all follow that rule By contrast I'd not enjoy enforced editor configurations, and really despise a monster check-in that would render svn blame useless (which, I may add, I find extremely useful to find not necessary who but when and with which log message a particular line was written). Armin
On Sun, Apr 24, 2005 at 13:51 +0100, Armin Rigo wrote:
On Thu, Apr 21, 2005 at 08:28:21PM +0200, holger krekel wrote:
Now my question is, do we want to "enforce" or at least state in our coding-style document one policy or the other?
I'm not too concerned about a few dummy diff entries, even though I'm usually avoiding to kill trailing whitespace. I don't see the point of strict policies as long as the source code base is roughly consistent, and I think that it is. This is both about trailing whitespace and indentation -- I mean, we know that indentation is 4 spaces and we all follow that rule
indeed.
By contrast I'd not enjoy enforced editor configurations, and really despise a monster check-in that would render svn blame useless (which, I may add, I find extremely useful to find not necessary who but when and with which log message a particular line was written).
good point. Hum. holger
Hi, Just FYI, reindent.py removes trailing whitespace on a line. Cheers, Riaan. Armin Rigo wrote:
Hi,
On Thu, Apr 21, 2005 at 08:28:21PM +0200, holger krekel wrote:
Now my question is, do we want to "enforce" or at least state in our coding-style document one policy or the other?
I'm not too concerned about a few dummy diff entries, even though I'm usually avoiding to kill trailing whitespace. I don't see the point of strict policies as long as the source code base is roughly consistent, and I think that it is. This is both about trailing whitespace and indentation -- I mean, we know that indentation is 4 spaces and we all follow that rule
By contrast I'd not enjoy enforced editor configurations, and really despise a monster check-in that would render svn blame useless (which, I may add, I find extremely useful to find not necessary who but when and with which log message a particular line was written).
Armin _______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev
Riaan Booysen wrote:
Hi,
Just FYI, reindent.py removes trailing whitespace on a line.
Hi Riaan! nice to see you again, Mr. Boa!!! :-) -- Christian Tismer :^) <mailto:tismer@stackless.com> tismerysoft GmbH : Have a break! Take a ride on Python's Johannes-Niemeyer-Weg 9A : *Starship* http://starship.python.net/ 14109 Berlin : PGP key -> http://wwwkeys.pgp.net/ work +49 30 802 86 56 mobile +49 173 24 18 776 fax +49 30 80 90 57 05 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/
participants (7)
-
Armin Rigo -
Christian Tismer -
holger krekel -
hpk＠trillke.net
-
Jacob Hallen -
Michael Hudson -
Riaan Booysen