Re: [pypy-dev] [pypy-commit] pypy vmprof: uh
uh, I really don't think this checkin is correct (it was meant to seek to the end, not 2 bytes) On Sun, Mar 8, 2015 at 7:03 PM, arigo <noreply@buildbot.pypy.org> wrote:
Author: Armin Rigo <arigo@tunes.org> Branch: vmprof Changeset: r76280:4c0fa46303da Date: 2015-03-08 18:03 +0100 http://bitbucket.org/pypy/pypy/changeset/4c0fa46303da/
Log: uh
diff --git a/pypy/module/__pypy__/interp_magic.py b/pypy/module/__pypy__/interp_magic.py --- a/pypy/module/__pypy__/interp_magic.py +++ b/pypy/module/__pypy__/interp_magic.py @@ -141,4 +141,4 @@ try: return space.wrap(ec.code_info_file.read()) finally: - ec.code_info_file.seek(2, 0) + ec.code_info_file.seek(0, 2) _______________________________________________ pypy-commit mailing list pypy-commit@python.org https://mail.python.org/mailman/listinfo/pypy-commit
Hi Fijal, On 9 March 2015 at 09:21, Maciej Fijalkowski <fijall@gmail.com> wrote:
uh, I really don't think this checkin is correct (it was meant to seek to the end, not 2 bytes)
- ec.code_info_file.seek(2, 0) + ec.code_info_file.seek(0, 2)
Sorry, I may be missing something, but it seems to me that "seek(0, 2)" is the order you need for "seek to the end"... A bientôt, Armin.
May I suggest we use the `os.SEEK_*` constants for this; not all of us have memorized POSIX :-) Alex On Mon, Mar 9, 2015 at 8:42 AM, Armin Rigo <arigo@tunes.org> wrote:
Hi Fijal,
On 9 March 2015 at 09:21, Maciej Fijalkowski <fijall@gmail.com> wrote:
uh, I really don't think this checkin is correct (it was meant to seek to the end, not 2 bytes)
- ec.code_info_file.seek(2, 0) + ec.code_info_file.seek(0, 2)
Sorry, I may be missing something, but it seems to me that "seek(0, 2)" is the order you need for "seek to the end"...
A bientôt,
Armin. _______________________________________________ pypy-dev mailing list pypy-dev@python.org https://mail.python.org/mailman/listinfo/pypy-dev
-- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: 125F 5C67 DFE9 4084
participants (3)
-
Alex Gaynor -
Armin Rigo -
Maciej Fijalkowski