Re: [pypy-dev] [pypy-svn] r73627 - pypy/branch/cpython-extension/pypy/module/cpyext/include
Why? I think we do support that. On Sat, Apr 10, 2010 at 8:31 AM, <jandem@codespeak.net> wrote:
Author: jandem Date: Sat Apr 10 16:31:22 2010 New Revision: 73627
Modified: pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h Log: Comment out PyObject_REALLOC
Modified: pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h ============================================================================== --- pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h (original) +++ pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h Sat Apr 10 16:31:22 2010 @@ -7,7 +7,8 @@
/* XXX use obmalloc like cpython and pypy do, otherwise we might get segfaults */ #define PyObject_MALLOC PyMem_MALLOC -#define PyObject_REALLOC PyMem_REALLOC +// we won't support this +// #define PyObject_REALLOC PyMem_REALLOC #define PyObject_FREE PyMem_FREE
#define PyMem_Malloc PyMem_MALLOC _______________________________________________ pypy-svn mailing list pypy-svn@codespeak.net http://codespeak.net/mailman/listinfo/pypy-svn
On Mon, Apr 12, 2010 at 7:18 PM, Maciej Fijalkowski <fijall@gmail.com> wrote:
Why? I think we do support that.
On IRC xorAxAx asked me to comment it out again. I don't know the exact reason, he can probably tell you more about it :)
On Sat, Apr 10, 2010 at 8:31 AM, <jandem@codespeak.net> wrote:
Author: jandem Date: Sat Apr 10 16:31:22 2010 New Revision: 73627
Modified: pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h Log: Comment out PyObject_REALLOC
Modified: pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h ============================================================================== --- pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h (original) +++ pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h Sat Apr 10 16:31:22 2010 @@ -7,7 +7,8 @@
/* XXX use obmalloc like cpython and pypy do, otherwise we might get segfaults */ #define PyObject_MALLOC PyMem_MALLOC -#define PyObject_REALLOC PyMem_REALLOC +// we won't support this +// #define PyObject_REALLOC PyMem_REALLOC #define PyObject_FREE PyMem_FREE
#define PyMem_Malloc PyMem_MALLOC _______________________________________________ pypy-svn mailing list pypy-svn@codespeak.net http://codespeak.net/mailman/listinfo/pypy-svn
_______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev
On Mon, Apr 12, 2010 at 2:29 PM, Jan de Mooij <jandemooij@gmail.com> wrote:
On Mon, Apr 12, 2010 at 7:18 PM, Maciej Fijalkowski <fijall@gmail.com> wrote:
Why? I think we do support that.
On IRC xorAxAx asked me to comment it out again. I don't know the exact reason, he can probably tell you more about it :)
Fair enough :) Maybe he can speak up here.
On Sat, Apr 10, 2010 at 8:31 AM, <jandem@codespeak.net> wrote:
Author: jandem Date: Sat Apr 10 16:31:22 2010 New Revision: 73627
Modified: pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h Log: Comment out PyObject_REALLOC
Modified: pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h ============================================================================== --- pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h (original) +++ pypy/branch/cpython-extension/pypy/module/cpyext/include/pymem.h Sat Apr 10 16:31:22 2010 @@ -7,7 +7,8 @@
/* XXX use obmalloc like cpython and pypy do, otherwise we might get segfaults */ #define PyObject_MALLOC PyMem_MALLOC -#define PyObject_REALLOC PyMem_REALLOC +// we won't support this +// #define PyObject_REALLOC PyMem_REALLOC #define PyObject_FREE PyMem_FREE
#define PyMem_Malloc PyMem_MALLOC _______________________________________________ pypy-svn mailing list pypy-svn@codespeak.net http://codespeak.net/mailman/listinfo/pypy-svn
_______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev
On Mon, 12 Apr 2010 14:54:06 -0600, Maciej Fijalkowski <fijall@gmail.com> wrote:
On Mon, Apr 12, 2010 at 2:29 PM, Jan de Mooij <jandemooij@gmail.com> wrote:
On Mon, Apr 12, 2010 at 7:18 PM, Maciej Fijalkowski <fijall@gmail.com> wrote:
Why? I think we do support that.
On IRC xorAxAx asked me to comment it out again. I don't know the exact reason, he can probably tell you more about it :)
Fair enough :) Maybe he can speak up here.
PyObject_* need to go through lltype.malloc, unlike they do now (as PyObject_New also uses lltype.malloc). Because there is no realloc operation in PyPy, we cannot support it. Kind regards, Alexander
participants (3)
-
Alexander Schremmer -
Jan de Mooij -
Maciej Fijalkowski