A small bug in cppyy's setup.py
Hi, In cppyy 0.3.1, there is a bug in setup.py for systems where pypy is not detected. I believe an incomplete patch is: ========== $ diff -U5 setup.py.original setup.py --- setup.py.original 2017-10-11 11:36:54.632924969 +0100 +++ setup.py 2017-10-11 11:38:08.732492901 +0100 @@ -18,10 +18,11 @@ else: requirements = ['cppyy-backend'] add_pkg = ['cppyy'] except ImportError: requirements = ['CPyCppyy'] + add_pkg = [] setup( name='cppyy', version='0.3.1', ========== Without this assignment to define add_pkg, the reference to "add_pkg" fails in the setup() call. I describe the patch as incomplete because I'm not sure what the array should contain. I do see that the relevant direction contains both a "cppyy" and a "cppyy_compat" directory. Any clarification welcomed. Thanks, Shaheed P.S. If a bug report, or a PR is preferred, please advise.
Shaheed, yes, or rather: + add_pkg = ['cppyy'] Anyway, is in, thanks! I was off on a tangent now that PyPy 5.9 is released. For that matter, the cppyy-backend package has been updated, too. PyPy 5.7-5.9 will have the 0.2.x branch, later is now 0.3.x. Change is minor, but needed for templated constructors (as is the case for the boost example on the intro page of the documentation). I'm currently trying to fix up all I want for PyPy, to get it in early and be on-time for the next release. :) I was hoping to get more into 5.9, but sat on it for too long. It's all minor stuff: naming etc. to get consistent results between PyPy and CPython in things like help() and exceptions, but these small differences can get very annoying very quickly. After that, first priority will be to setup nightly builds, to catch things like the above. I hardly ever run p3 myself, for example.
P.S. If a bug report, or a PR is preferred, please advise.
Well, this is a CPython/cppyy specific problem, so it's highly unlikely to be of interest on pypy-dev. Therefore, I'd recommend using: https://bitbucket.org/wlav/cppyy/issues Or e-mail me directly. Thanks! Best regards, Wim -- WLavrijsen@lbl.gov -- +1 (510) 486 6411 -- www.lavrijsen.net
participants (2)
-
Shaheed Haque -
wlavrijsen＠lbl.gov