Hi, So just to get a quick sanity check before I start. We are missing lzma in py3.3 (or to be more precise we have the beginnings of the module, but it's not passing any tests yet). Philip hinted to me recently that it would make sense to integrate lzmaffi. I would like to work on that, but I will probably get stuck a few times, so I'm planning to do some writeups on my blog as I go along (both for note taking and debugging). Since it's an external project I was planning to follow the same procedure that we use for stdlib, which is described in stdlib-upgrade.txt. So start out with vendor/lzmaffi, then branch off to py3.3-lzmaffi for integration work, finally merge into py3.3. Does that seem like a good approach? Martin 2014-07-23 19:20 GMT+02:00 Peter Cock <p.j.a.cock@googlemail.com>:
Hi Martin, On 23 August 2014 22:03, Martin Matusiak <numerodix@gmail.com> wrote:
No, that's unnecessarily complicated. Depending on the level of completion of lzmaffi, you either don't need a lot more, or you do; if you do, then first complete it independently of PyPy, e.g. in a fork of lzmaffi or in your own repository. Import the py3.3 tests, test on top of CPython and PyPy, and so on. When it's done, you can simply copy it into pypy in the branch py3.3 and kill the beginnings of pypy/module/lzma/. It's probably just a pull request at this point. A bientôt, Armin.
Hi Martin, On 23 August 2014 22:03, Martin Matusiak <numerodix@gmail.com> wrote:
No, that's unnecessarily complicated. Depending on the level of completion of lzmaffi, you either don't need a lot more, or you do; if you do, then first complete it independently of PyPy, e.g. in a fork of lzmaffi or in your own repository. Import the py3.3 tests, test on top of CPython and PyPy, and so on. When it's done, you can simply copy it into pypy in the branch py3.3 and kill the beginnings of pypy/module/lzma/. It's probably just a pull request at this point. A bientôt, Armin.
participants (2)
-
Armin Rigo -
Martin Matusiak