Re: [pypy-dev] [pypy-svn] r73628 - in pypy/branch/cpython-extension/pypy/module/cpyext: . test
I probably have missed some part of discussion, but - shouldn't we have it present the same interface as lib/array.py? If lib/array.py is not needed, since we use the C version, how about killing lib/array?
Maciej Fijalkowski wrote:
I probably have missed some part of discussion, but - shouldn't we have it present the same interface as lib/array.py? If lib/array.py is not needed, since we use the C version, how about killing lib/array?
lib/array is needed by OO backends, which can't use the C version
Good point. But anyway we should not expose 2 different array types on C version. On Mon, Apr 12, 2010 at 11:26 AM, Antonio Cuni <anto.cuni@gmail.com> wrote:
Maciej Fijalkowski wrote:
I probably have missed some part of discussion, but - shouldn't we have it present the same interface as lib/array.py? If lib/array.py is not needed, since we use the C version, how about killing lib/array?
lib/array is needed by OO backends, which can't use the C version
Hi fijal, On Mon, Apr 12, 2010 at 6:15 PM, Maciej Fijalkowski <fijall@gmail.com> wrote:
I probably have missed some part of discussion, but - shouldn't we have it present the same interface as lib/array.py? If lib/array.py is not needed, since we use the C version, how about killing lib/array?
I added it only to the test directory as it's not yet ready. We need suport for __setitem__ and iterators (should be easy though) and some other pieces. Once that's done it can probably replace lib/array.py on pypy-c. It would be interesting to benchmark it against CPython to test cpyext overhead.
_______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev
Sounds reasonable to me. On Mon, Apr 12, 2010 at 2:22 PM, Jan de Mooij <jandemooij@gmail.com> wrote:
Hi fijal,
On Mon, Apr 12, 2010 at 6:15 PM, Maciej Fijalkowski <fijall@gmail.com> wrote:
I probably have missed some part of discussion, but - shouldn't we have it present the same interface as lib/array.py? If lib/array.py is not needed, since we use the C version, how about killing lib/array?
I added it only to the test directory as it's not yet ready. We need suport for __setitem__ and iterators (should be easy though) and some other pieces. Once that's done it can probably replace lib/array.py on pypy-c. It would be interesting to benchmark it against CPython to test cpyext overhead.
_______________________________________________ pypy-dev@codespeak.net http://codespeak.net/mailman/listinfo/pypy-dev
participants (3)
-
Antonio Cuni -
Jan de Mooij -
Maciej Fijalkowski