Hi dear list, I have hard time to fork the project thus I m sendng this little patch to fix FreeBSD build. Hope it is helpful. Kind regards.
Hello, Disclaimer: I'm not sure I know what I'm talking about, I'm not really a pypy dev, so take my below questions with that in mind. They may be completely wrong. On Fri, May 18, 2018 at 4:09 PM, David CARLIER <devnexen@gmail.com> wrote:
Hi dear list, I have hard time to fork the project thus I m sendng this little patch to fix FreeBSD build.
Are you sure your startswith('amd64') should not be a == 'amd64' Looks like you enable more than just "freebsd-*/amd64" with this change, are the other combinations tested / working ? Thanks -- Vincent Legoll
Hi and thanks for the feedback; indeed == amd64 is the good expression. On 18 May 2018 at 14:27, Vincent Legoll <vincent.legoll@gmail.com> wrote:
Hello,
Disclaimer: I'm not sure I know what I'm talking about, I'm not really a pypy dev, so take my below questions with that in mind. They may be completely wrong.
On Fri, May 18, 2018 at 4:09 PM, David CARLIER <devnexen@gmail.com> wrote:
Hi dear list, I have hard time to fork the project thus I m sendng this little patch to fix FreeBSD build.
Are you sure your startswith('amd64') should not be a == 'amd64'
Looks like you enable more than just "freebsd-*/amd64" with this change, are the other combinations tested / working ?
Thanks
-- Vincent Legoll
Hi David, On 18 May 2018 at 16:09, David CARLIER <devnexen@gmail.com> wrote:
Hi dear list, I have hard time to fork the project thus I m sendng this little patch to fix FreeBSD build.
As far as I can see, the function ``detect_cpu.autodetect()`` never returns the string 'amd64'. Are you sure this part of the patch is meaningful? A bientôt, Armin.
participants (3)
-
Armin Rigo -
David CARLIER -
Vincent Legoll