Filtering build triggers
Would it be possible to add a filter to the build trigger that would skip documentation only changes like the configuration for AppVeyor? (see .github/appveyor.yml) To my knowledge, we don't have any tests dependent on the contents of documentation sources. This would really increase the availability of the workers (especially the slower ones).
Ideally, this could be implemented server-side so as to eliminate "false" successes. I would think that this would help those watching the buildbots (Victor!) for erroneous commits.
-- Jeremy Kloth
On Sat, Jun 9, 2018 at 1:34 AM, Jeremy Kloth <jeremy.kloth@gmail.com> wrote:
Would it be possible to add a filter to the build trigger that would skip documentation only changes like the configuration for AppVeyor? (see .github/appveyor.yml) To my knowledge, we don't have any tests dependent on the contents of documentation sources. This would really increase the availability of the workers (especially the slower ones).
Ideally, this could be implemented server-side so as to eliminate "false" successes. I would think that this would help those watching the buildbots (Victor!) for erroneous commits.
This should already be implemented. See here: https://github.com/python/buildmaster-config/blob/56aa6ddc4333cb0829eb90847a...
-- Zach
On Sat, Jun 9, 2018 at 8:48 AM Zachary Ware <zachary.ware+pydev@gmail.com> wrote:
This should already be implemented. See here: https://github.com/python/buildmaster-config/blob/56aa6ddc4333cb0829eb90847a...
Ah, I did miss that. However it is a different set of filters than exist in the travis and appveyor configs. Most notably it does miss *.rst files not residing in those directories.
Here is a list of (some) of the doc-only changes missed by the current filter implementation:
http://buildbot.python.org/all/#/builders/17/builds/114 http://buildbot.python.org/all/#/builders/130/builds/30 http://buildbot.python.org/all/#/builders/130/builds/29 http://buildbot.python.org/all/#/builders/40/builds/414 http://buildbot.python.org/all/#/builders/17/builds/116
-- Jeremy Kloth
On Sat, Jun 9, 2018 at 10:15 AM, Jeremy Kloth <jeremy.kloth@gmail.com> wrote:
On Sat, Jun 9, 2018 at 8:48 AM Zachary Ware <zachary.ware+pydev@gmail.com> wrote:
This should already be implemented. See here: https://github.com/python/buildmaster-config/blob/56aa6ddc4333cb0829eb90847a...
Ah, I did miss that. However it is a different set of filters than exist in the travis and appveyor configs. Most notably it does miss *.rst files not residing in those directories.
Here is a list of (some) of the doc-only changes missed by the current filter implementation:
http://buildbot.python.org/all/#/builders/17/builds/114 http://buildbot.python.org/all/#/builders/130/builds/30 http://buildbot.python.org/all/#/builders/130/builds/29 http://buildbot.python.org/all/#/builders/40/builds/414 http://buildbot.python.org/all/#/builders/17/builds/116
Good point. I've expanded the definition of an unimportant file, see https://github.com/python/buildmaster-config/pull/38/files which is now deployed.
-- Zach
On Sat, Jun 9, 2018 at 11:56 AM Zachary Ware <zachary.ware+pydev@gmail.com> wrote:
Good point. I've expanded the definition of an unimportant file, see https://github.com/python/buildmaster-config/pull/38/files which is now deployed.
Thanks, that should eliminate most all false builds.
-- Jeremy Kloth
participants (2)
-
Jeremy Kloth
-
Zachary Ware