Mailman 3 June 2006 - Python-checkins

buildbot failure in PPC64 Debian 2.4
by buildbot＠python.org June 29, 2006

June 29, 2006

The Buildbot has detected a new failure of PPC64 Debian 2.4. Full details are available at: http://www.python.org/dev/buildbot/all/PPC64%2520Debian%25202.4/builds/36 Buildbot URL: http://www.python.org/dev/buildbot/all/ Build Reason: Build Source Stamp: [branch branches/release24-maint] HEAD Blamelist: fred.drake BUILD FAILED: failed failed slave lost sincerely, -The Buildbot

1 0

r47155 - in python/branches/release24-maint/Lib: sgmllib.py test/test_sgmllib.py
by fred.drake June 29, 2006

June 29, 2006

Author: fred.drake Date: Thu Jun 29 02:52:32 2006 New Revision: 47155 Modified: python/branches/release24-maint/Lib/sgmllib.py python/branches/release24-maint/Lib/test/test_sgmllib.py Log: SF bug #1504333: sgmlib should allow angle brackets in quoted values (modified patch by Sam Ruby; changed to use separate REs for start and end tags to reduce matching cost for end tags; extended tests; updated to avoid breaking previous changes to support IPv6 addresses in unquoted attribute values) Modified: python/branches/release24-maint/Lib/sgmllib.py ============================================================================== --- python/branches/release24-maint/Lib/sgmllib.py (original) +++ python/branches/release24-maint/Lib/sgmllib.py Thu Jun 29 02:52:32 2006 @@ -29,7 +29,12 @@ shorttagopen = re.compile('<[a-zA-Z][-.a-zA-Z0-9]*/') shorttag = re.compile('<([a-zA-Z][-.a-zA-Z0-9]*)/([^/]*)/') piclose = re.compile('>') -endbracket = re.compile('[<>]') +starttag = re.compile(r'<[a-zA-Z][-_.:a-zA-Z0-9]*\s*(' + r'\s*([a-zA-Z_][-:.a-zA-Z_0-9]*)(\s*=\s*' + r'(\'[^\']*\'|"[^"]*"|[-a-zA-Z0-9./,:;+*%?!&$_#=~@]' + r'[][\-a-zA-Z0-9./,:;+*%?!&$_#=~\'"@]*(?=[\s>/<])))?' + r')*\s*/?\s*(?=[<>])') +endtag = re.compile(r'</?[a-zA-Z][-_.:a-zA-Z0-9]*\s*/?\s*(?=[<>])') tagfind = re.compile('[a-zA-Z][-_.a-zA-Z0-9]*') attrfind = re.compile( r'\s*([a-zA-Z_][-:.a-zA-Z_0-9]*)(\s*=\s*' @@ -245,11 +250,10 @@ self.finish_shorttag(tag, data) self.__starttag_text = rawdata[start_pos:match.end(1) + 1] return k - # XXX The following should skip matching quotes (' or ") - match = endbracket.search(rawdata, i+1) + match = starttag.match(rawdata, i) if not match: return -1 - j = match.start(0) + j = match.end(0) # Now parse the data between i+1 and j into a tag and attrs attrs = [] if rawdata[i:i+2] == '<>': @@ -283,10 +287,10 @@ # Internal -- parse endtag def parse_endtag(self, i): rawdata = self.rawdata - match = endbracket.search(rawdata, i+1) + match = endtag.match(rawdata, i) if not match: return -1 - j = match.start(0) + j = match.end(0) tag = rawdata[i+2:j].strip().lower() if rawdata[j] == '>': j = j+1 Modified: python/branches/release24-maint/Lib/test/test_sgmllib.py ============================================================================== --- python/branches/release24-maint/Lib/test/test_sgmllib.py (original) +++ python/branches/release24-maint/Lib/test/test_sgmllib.py Thu Jun 29 02:52:32 2006 @@ -214,6 +214,21 @@ ("starttag", "e", [("a", "rgb(1,2,3)")]), ]) + def test_attr_values_quoted_markup(self): + """Multi-line and markup in attribute values""" + self.check_events("""<a title='foo\n<br>bar'>text</a>""", + [("starttag", "a", [("title", "foo\n<br>bar")]), + ("data", "text"), + ("endtag", "a")]) + self.check_events("""<a title='less < than'>text</a>""", + [("starttag", "a", [("title", "less < than")]), + ("data", "text"), + ("endtag", "a")]) + self.check_events("""<a title='greater > than'>text</a>""", + [("starttag", "a", [("title", "greater > than")]), + ("data", "text"), + ("endtag", "a")]) + def test_attr_funky_names(self): self.check_events("""<a a.b='v' c:d=v e-f=v>""", [ ("starttag", "a", [("a.b", "v"), ("c:d", "v"), ("e-f", "v")]),

1 0

r47154 - in python/trunk/Lib: sgmllib.py test/test_sgmllib.py
by fred.drake June 29, 2006

June 29, 2006

Author: fred.drake Date: Thu Jun 29 02:51:53 2006 New Revision: 47154 Modified: python/trunk/Lib/sgmllib.py python/trunk/Lib/test/test_sgmllib.py Log: SF bug #1504333: sgmlib should allow angle brackets in quoted values (modified patch by Sam Ruby; changed to use separate REs for start and end tags to reduce matching cost for end tags; extended tests; updated to avoid breaking previous changes to support IPv6 addresses in unquoted attribute values) Modified: python/trunk/Lib/sgmllib.py ============================================================================== --- python/trunk/Lib/sgmllib.py (original) +++ python/trunk/Lib/sgmllib.py Thu Jun 29 02:51:53 2006 @@ -29,7 +29,12 @@ shorttagopen = re.compile('<[a-zA-Z][-.a-zA-Z0-9]*/') shorttag = re.compile('<([a-zA-Z][-.a-zA-Z0-9]*)/([^/]*)/') piclose = re.compile('>') -endbracket = re.compile('[<>]') +starttag = re.compile(r'<[a-zA-Z][-_.:a-zA-Z0-9]*\s*(' + r'\s*([a-zA-Z_][-:.a-zA-Z_0-9]*)(\s*=\s*' + r'(\'[^\']*\'|"[^"]*"|[-a-zA-Z0-9./,:;+*%?!&$_#=~@]' + r'[][\-a-zA-Z0-9./,:;+*%?!&$_#=~\'"@]*(?=[\s>/<])))?' + r')*\s*/?\s*(?=[<>])') +endtag = re.compile(r'</?[a-zA-Z][-_.:a-zA-Z0-9]*\s*/?\s*(?=[<>])') tagfind = re.compile('[a-zA-Z][-_.a-zA-Z0-9]*') attrfind = re.compile( r'\s*([a-zA-Z_][-:.a-zA-Z_0-9]*)(\s*=\s*' @@ -249,14 +254,10 @@ self.finish_shorttag(tag, data) self.__starttag_text = rawdata[start_pos:match.end(1) + 1] return k - # XXX The following should skip matching quotes (' or ") - # As a shortcut way to exit, this isn't so bad, but shouldn't - # be used to locate the actual end of the start tag since the - # < or > characters may be embedded in an attribute value. - match = endbracket.search(rawdata, i+1) + match = starttag.match(rawdata, i) if not match: return -1 - j = match.start(0) + j = match.end(0) # Now parse the data between i+1 and j into a tag and attrs attrs = [] if rawdata[i:i+2] == '<>': @@ -305,10 +306,10 @@ # Internal -- parse endtag def parse_endtag(self, i): rawdata = self.rawdata - match = endbracket.search(rawdata, i+1) + match = endtag.match(rawdata, i) if not match: return -1 - j = match.start(0) + j = match.end(0) tag = rawdata[i+2:j].strip().lower() if rawdata[j] == '>': j = j+1 Modified: python/trunk/Lib/test/test_sgmllib.py ============================================================================== --- python/trunk/Lib/test/test_sgmllib.py (original) +++ python/trunk/Lib/test/test_sgmllib.py Thu Jun 29 02:51:53 2006 @@ -286,6 +286,21 @@ ('codepoint', 'convert', 42), ]) + def test_attr_values_quoted_markup(self): + """Multi-line and markup in attribute values""" + self.check_events("""<a title='foo\n<br>bar'>text</a>""", + [("starttag", "a", [("title", "foo\n<br>bar")]), + ("data", "text"), + ("endtag", "a")]) + self.check_events("""<a title='less < than'>text</a>""", + [("starttag", "a", [("title", "less < than")]), + ("data", "text"), + ("endtag", "a")]) + self.check_events("""<a title='greater > than'>text</a>""", + [("starttag", "a", [("title", "greater > than")]), + ("data", "text"), + ("endtag", "a")]) + def test_attr_funky_names(self): self.check_events("""<a a.b='v' c:d=v e-f=v>""", [ ("starttag", "a", [("a.b", "v"), ("c:d", "v"), ("e-f", "v")]),

1 0

buildbot warnings in PPC64 Debian trunk
by buildbot＠python.org June 28, 2006

June 28, 2006

The Buildbot has detected a new failure of PPC64 Debian trunk. Full details are available at: http://www.python.org/dev/buildbot/all/PPC64%2520Debian%2520trunk/builds/252 Buildbot URL: http://www.python.org/dev/buildbot/all/ Build Reason: Build Source Stamp: [branch trunk] HEAD Blamelist: andrew.kuchling,georg.brandl Build Had Warnings: warnings failed slave lost sincerely, -The Buildbot

1 0

r47153 - python/trunk/Misc/NEWS
by trent.mick June 28, 2006

June 28, 2006

Author: trent.mick Date: Wed Jun 28 22:30:41 2006 New Revision: 47153 Modified: python/trunk/Misc/NEWS Log: Mention the expat upgrade and pyexpat fix I put in 2.5b1. Modified: python/trunk/Misc/NEWS ============================================================================== --- python/trunk/Misc/NEWS (original) +++ python/trunk/Misc/NEWS Wed Jun 28 22:30:41 2006 @@ -141,6 +141,10 @@ Extension Modules ----------------- +- Bug #1295808: expat symbols should be namespaced in pyexpat + +- Patch #1462338: Upgrade pyexpat to expat 2.0.0 + - Change binascii.hexlify to accept a read-only buffer instead of only a char buffer and actually follow its documentation.

1 0

r47152 - peps/trunk/pep-0356.txt
by trent.mick June 28, 2006

June 28, 2006

Author: trent.mick Date: Wed Jun 28 22:28:56 2006 New Revision: 47152 Modified: peps/trunk/pep-0356.txt Log: The expat 2.0 upgrade was done for 2.5b1 Modified: peps/trunk/pep-0356.txt ============================================================================== --- peps/trunk/pep-0356.txt (original) +++ peps/trunk/pep-0356.txt Wed Jun 28 22:28:56 2006 @@ -105,6 +105,9 @@ support naive introspection (e.g. having f.__name__ return the original function name). + - Upgrade pyexpat to use expat 2.0. + + Possible features for 2.5 Each feature below should implemented prior to beta1 or @@ -112,9 +115,6 @@ - Modules under consideration for inclusion: - - Upgrade pyexpat to use expat 2.0? - (Patch by Trent Mick, #1462338) - - Add new icons for MacOS and Unix with the new Python logo? (Owner: ???) MacOS: http://hcs.harvard.edu/~jrus/python/prettified-py-icons.png

1 0

r47151 - in python/trunk: Lib/lib-tk/turtle.py Misc/NEWS
by georg.brandl June 28, 2006

June 28, 2006

Author: georg.brandl Date: Wed Jun 28 22:23:25 2006 New Revision: 47151 Modified: python/trunk/Lib/lib-tk/turtle.py python/trunk/Misc/NEWS Log: Fix end_fill(). Modified: python/trunk/Lib/lib-tk/turtle.py ============================================================================== --- python/trunk/Lib/lib-tk/turtle.py (original) +++ python/trunk/Lib/lib-tk/turtle.py Wed Jun 28 22:23:25 2006 @@ -721,7 +721,7 @@ def write(arg, move=0): _getpen().write(arg, move) def fill(flag): _getpen().fill(flag) def begin_fill(): _getpen().begin_fill() -def end_fill(): _getpen.end_fill() +def end_fill(): _getpen().end_fill() def circle(radius, extent=None): _getpen().circle(radius, extent) def goto(*args): _getpen().goto(*args) def heading(): return _getpen().heading() Modified: python/trunk/Misc/NEWS ============================================================================== --- python/trunk/Misc/NEWS (original) +++ python/trunk/Misc/NEWS Wed Jun 28 22:23:25 2006 @@ -19,6 +19,8 @@ Library ------- +- Fix a bug in the turtle module's end_fill function. + - Bug #1510580: The 'warnings' module improperly required that a Warning category be either a types.ClassType and a subclass of Warning. The proper check is just that it is a subclass with Warning as the documentation states.

1 0

r47150 - peps/trunk/pep-3103.txt
by trent.mick June 28, 2006

June 28, 2006

Author: trent.mick Date: Wed Jun 28 18:26:17 2006 New Revision: 47150 Modified: peps/trunk/pep-3103.txt Log: I presume that this was the intent of this sentence. Modified: peps/trunk/pep-3103.txt ============================================================================== --- peps/trunk/pep-3103.txt (original) +++ peps/trunk/pep-3103.txt Wed Jun 28 18:26:17 2006 @@ -127,7 +127,7 @@ else: SUITE -The hope of this alternative is that is will upset the auto-indent +The hope of this alternative is that it will not upset the auto-indent logic of the average Python-aware text editor less. But it looks strange to me.

1 0

r47149 - peps/trunk/pep-3103.txt
by guido.van.rossum June 28, 2006

June 28, 2006

Author: guido.van.rossum Date: Wed Jun 28 16:41:23 2006 New Revision: 47149 Modified: peps/trunk/pep-3103.txt Log: Introducing school IIb -- duplicate cases resolved by case order, not errors. Modified: peps/trunk/pep-3103.txt ============================================================================== --- peps/trunk/pep-3103.txt (original) +++ peps/trunk/pep-3103.txt Wed Jun 28 16:41:23 2006 @@ -390,10 +390,38 @@ unflagged, when the dict-based dispatch implementation makes it so easy to trap this. +However, there are some use cases for overlapping/duplicate cases. +Suppose you're switching on some OS-specific constants (e.g. exported +by the os module or some module like that). You have a case for each. +But on some OS, two different constants have the same value (since on +that OS they are implemented the same way -- like O_TEXT and O_BINARY +on Unix). If duplicate cases are flagged as errors, your switch +wouldn't work at all on that OS. It would be much better if you could +arrange the cases so that one case has preference over another. + +There's also the (more likely) use case where you have a set of cases +to be treated the same, but one member of the set must be treated +differently. It would be convenient to put the exception in an +earlier case and be done with it. + +(Yes, it seems a shame not to be able to diagnose dead code due to +accidental case duplication. Maybe that's less important, and +pychecker can deal with it? After all we don't diagnose duplicate +method definitions either.) + +This suggests school IIb: like school II but redundant cases must be +resolved by choosing the first match. This is trivial to implement +when building the dispatch dict (skip keys already present). + +(An alternative would be to introduce new syntax to indicate "okay to +have overlapping cases" or "ok if this case is dead code" but I find +that overkill.) + Personally, I'm in school II: I believe that the dict-based dispatch is the one true implementation for switch statements and that we should face the limitiations up front, so that we can reap maximal -benefits. +benefits. I'm leaning towards school IIb -- duplicate cases should be +resolved by the ordering of the cases instead of flagged as errors. When to Freeze the Dispatch Dict --------------------------------

1 0

r47148 - python/trunk/Doc/lib/lib.tex
by andrew.kuchling June 28, 2006

June 28, 2006

Author: andrew.kuchling Date: Wed Jun 28 16:27:21 2006 New Revision: 47148 Modified: python/trunk/Doc/lib/lib.tex Log: [Bug #1508766] Add docs for uuid module; this puts the module in the 'Internet Protocols' section. Arguably this module could also have gone in the chapters on strings or encodings, maybe even the crypto chapter. Fred, please move if you see fit. Modified: python/trunk/Doc/lib/lib.tex ============================================================================== --- python/trunk/Doc/lib/lib.tex (original) +++ python/trunk/Doc/lib/lib.tex Wed Jun 28 16:27:21 2006 @@ -303,6 +303,7 @@ \input{libsmtplib} \input{libsmtpd} \input{libtelnetlib} +\input{libuuid} \input{liburlparse} \input{libsocksvr} \input{libbasehttp}

1 0