Mailman 3 May 2008 - Python-checkins

r63805 - python/trunk/Python/bltinmodule.c
by raymond.hettinger May 30, 2008

May 30, 2008

Author: raymond.hettinger Date: Fri May 30 08:37:27 2008 New Revision: 63805 Log: Issue 2784: fix leaks in exception exit. Modified: python/trunk/Python/bltinmodule.c Modified: python/trunk/Python/bltinmodule.c ============================================================================== --- python/trunk/Python/bltinmodule.c (original) +++ python/trunk/Python/bltinmodule.c Fri May 30 08:37:27 2008 @@ -2305,14 +2305,14 @@ return PyFloat_FromDouble(f_result); } if (PyFloat_CheckExact(item)) { - PyFPE_START_PROTECT("add", return 0) + PyFPE_START_PROTECT("add", Py_DECREF(item); Py_DECREF(iter); return 0) f_result += PyFloat_AS_DOUBLE(item); PyFPE_END_PROTECT(f_result) Py_DECREF(item); continue; } if (PyInt_CheckExact(item)) { - PyFPE_START_PROTECT("add", return 0) + PyFPE_START_PROTECT("add", Py_DECREF(item); Py_DECREF(iter); return 0) f_result += (double)PyInt_AS_LONG(item); PyFPE_END_PROTECT(f_result) Py_DECREF(item);

1 0

Re: [Python-checkins] r63788 - in python/trunk: Doc/library/ftplib.rst Doc/library/httplib.rst Doc/library/poplib.rst Doc/library/smtplib.rst Doc/library/socket.rst Doc/library/telnetlib.rst Doc/library/urllib2.rst Lib/ftplib.py Lib/httplib.py Lib/po
by Neal Norwitz May 30, 2008

May 30, 2008

On Thu, May 29, 2008 at 9:39 AM, facundo.batista <python-checkins(a)python.org> wrote: > Author: facundo.batista > Date: Thu May 29 18:39:26 2008 > New Revision: 63788 > > Log: > > Fixed the semantic of timeout for socket.create_connection and > all the upper level libraries that use it, including urllib2. > Added and fixed some tests, and changed docs correspondingly. > Thanks to John J Lee for the patch and the pusing, :) > Modified: python/trunk/Lib/ftplib.py > ============================================================================== > --- python/trunk/Lib/ftplib.py (original) > +++ python/trunk/Lib/ftplib.py Thu May 29 18:39:26 2008 > @@ -44,6 +44,7 @@ > from socket import getfqdn; socket.getfqdn = getfqdn; del getfqdn > except ImportError: > import socket > +from socket import _GLOBAL_DEFAULT_TIMEOUT > > __all__ = ["FTP","Netrc"] > > @@ -71,7 +72,6 @@ > # Line terminators (we always output CRLF, but accept any of CRLF, CR, LF) > CRLF = '\r\n' > > - > # The class itself > class FTP: > > @@ -109,14 +109,15 @@ > # Initialize host to localhost, port to standard ftp port > # Optional arguments are host (for connect()), > # and user, passwd, acct (for login()) > - def __init__(self, host='', user='', passwd='', acct='', timeout=None): > + def __init__(self, host='', user='', passwd='', acct='', > + timeout=_GLOBAL_DEFAULT_TIMEOUT): > self.timeout = timeout > if host: > self.connect(host) > if user: > self.login(user, passwd, acct) > > - def connect(self, host='', port=0, timeout=None): > + def connect(self, host='', port=0, timeout=-999): > '''Connect to host. Arguments are: > - host: hostname to connect to (string, default previous host) > - port: port to connect to (integer, default previous port) > @@ -125,7 +126,7 @@ > self.host = host > if port > 0: > self.port = port > - if timeout is not None: > + if timeout != -999: > self.timeout = timeout > self.sock = socket.create_connection((self.host, self.port), self.timeout) > self.af = self.sock.family Why is a magic number used here, but in all other places I saw _GLOBAL_DEFAULT_TIMEOUT is used? Can't this code also use _GLOBAL_DEFAULT_TIMEOUT? n

1 0

buildbot failure in amd64 XP trunk
by buildbot＠python.org May 30, 2008

May 30, 2008

The Buildbot has detected a new failure of amd64 XP trunk. Full details are available at: http://www.python.org/dev/buildbot/all/amd64%20XP%20trunk/builds/1405 Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: heller-windows-amd64 Build Reason: Build Source Stamp: [branch trunk] HEAD Blamelist: brett.cannon,mark.dickinson BUILD FAILED: failed test failed slave lost Excerpt from the test logfile: 4 tests failed: test_pickletools test_pydoc test_site test_winsound ====================================================================== FAIL: test_html_doc (test.test_pydoc.PyDocDocTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_pydoc.py", line 220, in test_html_doc self.fail("outputs are not equal, see diff above") AssertionError: outputs are not equal, see diff above ====================================================================== FAIL: test_text_doc (test.test_pydoc.PyDocDocTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_pydoc.py", line 228, in test_text_doc self.fail("outputs are not equal, see diff above") AssertionError: outputs are not equal, see diff above ====================================================================== FAIL: test_s_option (test.test_site.HelperFunctionsTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_site.py", line 105, in test_s_option self.assertEqual(rc, 1) AssertionError: 0 != 1 ====================================================================== ERROR: test_alias_asterisk (test.test_winsound.PlaySoundTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_winsound.py", line 86, in test_alias_asterisk winsound.PlaySound('SystemAsterisk', winsound.SND_ALIAS) RuntimeError: Failed to play sound ====================================================================== ERROR: test_alias_exclamation (test.test_winsound.PlaySoundTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_winsound.py", line 96, in test_alias_exclamation winsound.PlaySound('SystemExclamation', winsound.SND_ALIAS) RuntimeError: Failed to play sound ====================================================================== ERROR: test_alias_exit (test.test_winsound.PlaySoundTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_winsound.py", line 106, in test_alias_exit winsound.PlaySound('SystemExit', winsound.SND_ALIAS) RuntimeError: Failed to play sound ====================================================================== ERROR: test_alias_hand (test.test_winsound.PlaySoundTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_winsound.py", line 116, in test_alias_hand winsound.PlaySound('SystemHand', winsound.SND_ALIAS) RuntimeError: Failed to play sound ====================================================================== ERROR: test_alias_question (test.test_winsound.PlaySoundTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot\trunk.heller-windows-amd64\build\lib\test\test_winsound.py", line 126, in test_alias_question winsound.PlaySound('SystemQuestion', winsound.SND_ALIAS) RuntimeError: Failed to play sound sincerely, -The Buildbot

1 0

r63802 - python/trunk/Lib/test/test_math.py
by mark.dickinson May 30, 2008

May 30, 2008

Author: mark.dickinson Date: Fri May 30 04:46:53 2008 New Revision: 63802 Log: Fix typo in testSum Modified: python/trunk/Lib/test/test_math.py Modified: python/trunk/Lib/test/test_math.py ============================================================================== --- python/trunk/Lib/test/test_math.py (original) +++ python/trunk/Lib/test/test_math.py Fri May 30 04:46:53 2008 @@ -740,7 +740,7 @@ OverflowError), ([2.**1023, 2.**1023, -1e307], OverflowError), ([1e16, 1., 1e-16], 10000000000000002.0), - ([1e16-2., 1.-2.**53, -(1e16-2.), -(1.-2.**53)], 0.0), + ([1e16-2., 1.-2.**-53, -(1e16-2.), -(1.-2.**-53)], 0.0), ] for i, (vals, s) in enumerate(test_values):

1 0

buildbot failure in S-390 Debian 3.0
by buildbot＠python.org May 30, 2008

May 30, 2008

The Buildbot has detected a new failure of S-390 Debian 3.0. Full details are available at: http://www.python.org/dev/buildbot/all/S-390%20Debian%203.0/builds/418 Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: klose-debian-s390 Build Reason: Build Source Stamp: [branch branches/py3k] HEAD Blamelist: benjamin.peterson,brett.cannon BUILD FAILED: failed test Excerpt from the test logfile: 1 test failed: test_builtin make: *** [buildbottest] Error 1 sincerely, -The Buildbot

1 0

r63800 - python/trunk/Doc/library/userdict.rst
by brett.cannon May 29, 2008

May 29, 2008

Author: brett.cannon Date: Thu May 29 23:28:55 2008 New Revision: 63800 Log: Note that UserList and UserString were moved to 'collections' in 3.0. Modified: python/trunk/Doc/library/userdict.rst Modified: python/trunk/Doc/library/userdict.rst ============================================================================== --- python/trunk/Doc/library/userdict.rst (original) +++ python/trunk/Doc/library/userdict.rst Thu May 29 23:28:55 2008 @@ -100,6 +100,12 @@ defaulting to the empty list ``[]``. *list* can be any iterable, e.g. a real Python list or a :class:`UserList` object. + .. note:: + The :class:`UserList` class has been moved to the :mod:`collections` + module in Python 3.0. The :term:`2to3` tool will automatically adapt + imports when converting your sources to 3.0. + + In addition to supporting the methods and operations of mutable sequences (see section :ref:`typesseq`), :class:`UserList` instances provide the following attribute: @@ -167,6 +173,12 @@ :class:`UserString` (or a subclass) or an arbitrary sequence which can be converted into a string using the built-in :func:`str` function. + .. note:: + The :class:`UserString` class has been moved to the :mod:`collections` + module in Python 3.0. The :term:`2to3` tool will automatically adapt + imports when converting your sources to 3.0. + + .. class:: MutableString([sequence])

1 0

r63799 - python/trunk/setup.py
by brett.cannon May 29, 2008

May 29, 2008

Author: brett.cannon Date: Thu May 29 23:23:33 2008 New Revision: 63799 Log: Turn off debugging output for building bsddb. Modified: python/trunk/setup.py Modified: python/trunk/setup.py ============================================================================== --- python/trunk/setup.py (original) +++ python/trunk/setup.py Thu May 29 23:23:33 2008 @@ -842,8 +842,9 @@ if db_setup_debug: print "db lib: ", dblib, "not found" except db_found: - print "bsddb using BerkeleyDB lib:", db_ver, dblib - print "bsddb lib dir:", dblib_dir, " inc dir:", db_incdir + if db_setup_debug: + print "bsddb using BerkeleyDB lib:", db_ver, dblib + print "bsddb lib dir:", dblib_dir, " inc dir:", db_incdir db_incs = [db_incdir] dblibs = [dblib] # We add the runtime_library_dirs argument because the

1 0

buildbot failure in S-390 Debian 3.0
by buildbot＠python.org May 29, 2008

May 29, 2008

The Buildbot has detected a new failure of S-390 Debian 3.0. Full details are available at: http://www.python.org/dev/buildbot/all/S-390%20Debian%203.0/builds/416 Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: klose-debian-s390 Build Reason: Build Source Stamp: [branch branches/py3k] HEAD Blamelist: thomas.heller BUILD FAILED: failed test Excerpt from the test logfile: 1 test failed: test_builtin make: *** [buildbottest] Error 1 sincerely, -The Buildbot

1 0

r63797 - peps/trunk/pep-0000.txt
by georg.brandl May 29, 2008

May 29, 2008

Author: georg.brandl Date: Thu May 29 23:14:46 2008 New Revision: 63797 Log: Formatting nits. Modified: peps/trunk/pep-0000.txt Modified: peps/trunk/pep-0000.txt ============================================================================== --- peps/trunk/pep-0000.txt (original) +++ peps/trunk/pep-0000.txt Thu May 29 23:14:46 2008 @@ -276,8 +276,8 @@ SR 3130 Access to Current Module/Class/Function Jewett SR 3133 Introducing Roles Winter SR 3136 Labeled break and continue Chisholm - SR 3139 Cleaning out sys and the "interpreter" module Peterson - SR 3140 str(container) should call str(item), not repr(item) Broytmann, Jewett + SR 3139 Cleaning out sys and the "interpreter" module Peterson + SR 3140 str(container) should call str(item), not repr(item) Broytmann, Jewett Numerical Index @@ -521,8 +521,8 @@ SR 3136 Labeled break and continue Chisholm SA 3137 Immutable Bytes and Mutable Buffer GvR S 3138 String representation in Python 3000 Ishimoto - SR 3139 Cleaning out sys and the "interpreter" module Peterson - SR 3140 str(container) should call str(item), not repr(item) Broytmann, Jewett + SR 3139 Cleaning out sys and the "interpreter" module Peterson + SR 3140 str(container) should call str(item), not repr(item) Broytmann, Jewett SA 3141 A Type Hierarchy for Numbers Yasskin

1 0

r63794 - in peps/trunk: pep-0000.txt pep-3140.txt
by benjamin.peterson May 29, 2008

May 29, 2008

Author: benjamin.peterson Date: Thu May 29 23:03:57 2008 New Revision: 63794 Log: add PEP 3140 (rejected): str(container) should call str(item), not repr(item) Added: peps/trunk/pep-3140.txt Modified: peps/trunk/pep-0000.txt Modified: peps/trunk/pep-0000.txt ============================================================================== --- peps/trunk/pep-0000.txt (original) +++ peps/trunk/pep-0000.txt Thu May 29 23:03:57 2008 @@ -277,6 +277,7 @@ SR 3133 Introducing Roles Winter SR 3136 Labeled break and continue Chisholm SR 3139 Cleaning out sys and the "interpreter" module Peterson + SR 3140 str(container) should call str(item), not repr(item) Broytmann, Jewett Numerical Index @@ -520,7 +521,8 @@ SR 3136 Labeled break and continue Chisholm SA 3137 Immutable Bytes and Mutable Buffer GvR S 3138 String representation in Python 3000 Ishimoto - SR 3139 Cleaning out sys and the "interpreter" module Peterson + SR 3139 Cleaning out sys and the "interpreter" module Peterson + SR 3140 str(container) should call str(item), not repr(item) Broytmann, Jewett SA 3141 A Type Hierarchy for Numbers Yasskin @@ -554,6 +556,7 @@ Bellman, Thomas bellman+pep-divmod(a)lysator.liu.se Bethard, Steven steven.bethard(a)gmail.com Brandl, Georg georg(a)python.org + Broytmann, Oleg phd(a)phd.pp.ru Cannon, Brett brett(a)python.org Carlson, Josiah jcarlson(a)uci.edu Carroll, W Isaac icarroll(a)pobox.com Added: peps/trunk/pep-3140.txt ============================================================================== --- (empty file) +++ peps/trunk/pep-3140.txt Thu May 29 23:03:57 2008 @@ -0,0 +1,205 @@ +PEP: 3140 +Title: str(container) should call str(item), not repr(item) +Version: $Revision$ +Last-Modified: $Date: 2008-05-28 20:38:33 -0600 (Thu, 28 May 2008)$ +Author: Oleg Broytmann <phd(a)phd.pp.ru>, + Jim Jewett <jimjjewett(a)gmail.com> +Discussions-To: python-3000(a)python.org +Status: Rejected +Type: Standards Track +Content-Type: text/plain +Created: 27-May-2008 +Post-History: 28-May-2008 + + +Rejection + + Guido said this would cause too much disturbance too close to beta. See + http://mail.python.org/pipermail/python-3000/2008-May/013876.html. + + +Abstract + + This document discusses the advantages and disadvantages of the + current implementation of str(container). It also discusses the + pros and cons of a different approach - to call str(item) instead + of repr(item). + + +Motivation + + Currently str(container) calls repr on items. Arguments for it: + -- containers refuse to guess what the user wants to see on + str(container) - surroundings, delimiters, and so on; + -- repr(item) usually displays type information - apostrophes + around strings, class names, etc. + + Arguments against: + -- it's illogical; str() is expected to call __str__ if it exists, + not __repr__; + -- there is no standard way to print a container's content calling + items' __str__, that's inconvenient in cases where __str__ and + __repr__ return different results; + -- repr(item) sometimes do wrong things (hex-escapes non-ascii + strings, e.g.) + + This PEP proposes to change how str(container) works. It is + proposed to mimic how repr(container) works except one detail + - call str on items instead of repr. This allows a user to choose + what results she want to get - from item.__repr__ or item.__str__. + + +Current situation + + Most container types (tuples, lists, dicts, sets, etc.) do not + implement __str__ method, so str(container) calls + container.__repr__, and container.__repr__, once called, forgets + it is called from str and always calls repr on the container's + items. + + This behaviour has advantages and disadvantages. One advantage is + that most items are represented with type information - strings + are surrounded by apostrophes, instances may have both class name + and instance data: + + >>> print([42, '42']) + [42, '42'] + >>> print([Decimal('42'), datetime.now()]) + [Decimal("42"), datetime.datetime(2008, 5, 27, 19, 57, 43, 485028)] + + The disadvantage is that __repr__ often returns technical data + (like '<object at address>') or unreadable string (hex-encoded + string if the input is non-ascii string): + + >>> print(['тест']) + ['\xd4\xc5\xd3\xd4'] + + One of the motivations for PEP 3138 is that neither repr nor str + will allow the sensible printing of dicts whose keys are non-ascii + text strings. Now that unicode identifiers are allowed, it + includes Python's own attribute dicts. This also includes JSON + serialization (and caused some hoops for the json lib). + + PEP 3138 proposes to fix this by breaking the "repr is safe ASCII" + invariant, and changing the way repr (which is used for + persistence) outputs some objects, with system-dependent failures. + + Changing how str(container) works would allow easy debugging in + the normal case, and retrain the safety of ASCII-only for the + machine-readable case. The only downside is that str(x) and + repr(x) would more often be different -- but only in those cases + where the current almost-the-same version is insufficient. + + It also seems illogical that str(container) calls repr on items + instead of str. It's only logical to expect following code + + class Test: + def __str__(self): + return "STR" + + def __repr__(self): + return "REPR" + + + test = Test() + print(test) + print(repr(test)) + print([test]) + print(str([test])) + + to print + + STR + REPR + [STR] + [STR] + + where it actually prints + + STR + REPR + [REPR] + [REPR] + + Especially it is illogical to see that print in Python 2 uses str + if it is called on what seems to be a tuple: + + >>> print Decimal('42'), datetime.now() + 42 2008-05-27 20:16:22.534285 + + where on an actual tuple it prints + + >>> print((Decimal('42'), datetime.now())) + (Decimal("42"), datetime.datetime(2008, 5, 27, 20, 16, 27, 937911)) + + +A different approach - call str(item) + + For example, with numbers it is often only the value that people + care about. + + >>> print Decimal('3') + 3 + + But putting the value in a list forces users to read the type + information, exactly as if repr had been called for the benefit of + a machine: + + >>> print [Decimal('3')] + [Decimal("3")] + + After this change, the type information would not clutter the str + output: + + >>> print "%s".format([Decimal('3')]) + [3] + >>> str([Decimal('3')]) # == + [3] + + But it would still be available if desired: + + >>> print "%r".format([Decimal('3')]) + [Decimal('3')] + >>> repr([Decimal('3')]) # == + [Decimal('3')] + + There is a number of strategies to fix the problem. The most + radical is to change __repr__ so it accepts a new parameter (flag) + "called from str, so call str on items, not repr". The + drawback of the proposal is that every __repr__ implementation + must be changed. Introspection could help a bit (inspect __repr__ + before calling if it accepts 2 or 3 parameters), but introspection + doesn't work on classes written in C, like all builtin containers. + + Less radical proposal is to implement __str__ methods for builtin + container types. The obvious drawback is a duplication of effort + - all those __str__ and __repr__ implementations are only differ + in one small detail - if they call str or repr on items. + + The most conservative proposal is not to change str at all but + to allow developers to implement their own application- or + library-specific pretty-printers. The drawback is again + a multiplication of effort and proliferation of many small + specific container-traversal algorithms. + + +Backward compatibility + + In those cases where type information is more important than + usual, it will still be possible to get the current results by + calling repr explicitly. + + +Copyright + + This document has been placed in the public domain. + + + +Local Variables: +mode: indented-text +indent-tabs-mode: nil +sentence-end-double-space: t +fill-column: 70 +coding: utf-8 +End:

1 0