Mailman 3 April 2013 - Python-checkins

peps: Rename run() -> run_forever(), and explain why.
by guido.van.rossum April 24, 2013

April 24, 2013

http://hg.python.org/peps/rev/0b8251cdfbac changeset: 4856:0b8251cdfbac user: Guido van Rossum <guido(a)python.org> date: Wed Apr 24 16:59:39 2013 -0700 summary: Rename run() -> run_forever(), and explain why. files: pep-3156.txt | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/pep-3156.txt b/pep-3156.txt --- a/pep-3156.txt +++ b/pep-3156.txt @@ -207,8 +207,13 @@ A conforming event loop object has the following methods: -- ``run()``. Runs the event loop until ``stop()`` is called. This - cannot be called when the event loop is already running. +- ``run_forever()``. Runs the event loop until ``stop()`` is called. + This cannot be called when the event loop is already running. (This + has a long name in part to avoid confusion with earlier versions of + this PEP, where ``run()`` had different behavior, in part because + there are already too many APIs that have a method named ``run()``, + and in part because there shouldn't be many places where this is + called anyway. - ``run_until_complete(future, timeout=None)``. Runs the event loop until the Future is done. If a timeout is given, it waits at most -- Repository URL: http://hg.python.org/peps

1 0

cpython (2.7): Issue #17835: Fix test_io when the default OS pipe buffer size is larger than
by antoine.pitrou April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/09811ecd5df1 changeset: 83519:09811ecd5df1 branch: 2.7 parent: 83505:a389700fbc74 user: Antoine Pitrou <solipsis(a)pitrou.net> date: Wed Apr 24 23:31:38 2013 +0200 summary: Issue #17835: Fix test_io when the default OS pipe buffer size is larger than one million bytes. files: Lib/test/test_io.py | 4 ++-- Lib/test/test_support.py | 9 +++++++++ Misc/NEWS | 3 +++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py --- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -2880,7 +2880,7 @@ # The buffered IO layer must check for pending signal # handlers, which in this case will invoke alarm_interrupt(). self.assertRaises(ZeroDivisionError, - wio.write, item * (3 * 1000 * 1000)) + wio.write, item * (support.PIPE_MAX_SIZE // len(item) + 1)) t.join() # We got one byte, get another one and check that it isn't a # repeat of the first one. @@ -2978,7 +2978,7 @@ select = support.import_module("select") # A quantity that exceeds the buffer size of an anonymous pipe's # write end. - N = 1024 * 1024 + N = support.PIPE_MAX_SIZE r, w = os.pipe() fdopen_kwargs["closefd"] = False # We need a separate thread to read from the pipe and allow the diff --git a/Lib/test/test_support.py b/Lib/test/test_support.py --- a/Lib/test/test_support.py +++ b/Lib/test/test_support.py @@ -400,6 +400,15 @@ return (len(x) > len(y)) - (len(x) < len(y)) return (x > y) - (x < y) + +# A constant likely larger than the underlying OS pipe buffer size, to +# make writes blocking. +# Windows limit seems to be around 512 B, and many Unix kernels have a +# 64 KiB pipe buffer size or 16 * PAGE_SIZE: take a few megs to be sure. +# (see issue #17835 for a discussion of this number). +PIPE_MAX_SIZE = 4 *1024 * 1024 + 1 + + try: unicode have_unicode = True diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -131,6 +131,9 @@ Tests ----- +- Issue #17835: Fix test_io when the default OS pipe buffer size is larger + than one million bytes. + - Issue #17531: Fix tests that thought group and user ids were always the int type. Also, always allow -1 as a valid group and user id. -- Repository URL: http://hg.python.org/cpython

1 0

cpython (merge 3.3 -> default): Issue #17835: Fix test_io when the default OS pipe buffer size is larger than
by antoine.pitrou April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/de35eae9048a changeset: 83518:de35eae9048a parent: 83516:0803a28dca3c parent: 83517:4b4ed1e11fd0 user: Antoine Pitrou <solipsis(a)pitrou.net> date: Wed Apr 24 23:33:20 2013 +0200 summary: Issue #17835: Fix test_io when the default OS pipe buffer size is larger than one million bytes. files: Lib/test/support.py | 10 ++++++---- Lib/test/test_io.py | 4 ++-- Misc/NEWS | 3 +++ 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Lib/test/support.py b/Lib/test/support.py --- a/Lib/test/support.py +++ b/Lib/test/support.py @@ -575,10 +575,12 @@ IPV6_ENABLED = _is_ipv6_enabled() -# A constant likely larger than the underlying OS pipe buffer size. -# Windows limit seems to be around 512B, and many Unix kernels have a 64K pipe -# buffer size or 16*PAGE_SIZE: take a few megs to be sure. This -PIPE_MAX_SIZE = 3 * 1000 * 1000 +# A constant likely larger than the underlying OS pipe buffer size, to +# make writes blocking. +# Windows limit seems to be around 512 B, and many Unix kernels have a +# 64 KiB pipe buffer size or 16 * PAGE_SIZE: take a few megs to be sure. +# (see issue #17835 for a discussion of this number). +PIPE_MAX_SIZE = 4 *1024 * 1024 + 1 # decorator for skipping tests on non-IEEE 754 platforms diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py --- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -3069,7 +3069,7 @@ # The buffered IO layer must check for pending signal # handlers, which in this case will invoke alarm_interrupt(). self.assertRaises(ZeroDivisionError, - wio.write, item * (support.PIPE_MAX_SIZE // len(item))) + wio.write, item * (support.PIPE_MAX_SIZE // len(item) + 1)) t.join() # We got one byte, get another one and check that it isn't a # repeat of the first one. @@ -3168,7 +3168,7 @@ select = support.import_module("select") # A quantity that exceeds the buffer size of an anonymous pipe's # write end. - N = 1024 * 1024 + N = support.PIPE_MAX_SIZE r, w = os.pipe() fdopen_kwargs["closefd"] = False # We need a separate thread to read from the pipe and allow the diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -153,6 +153,9 @@ Tests ----- +- Issue #17835: Fix test_io when the default OS pipe buffer size is larger + than one million bytes. + - Issue #17065: Use process-unique key for winreg tests to avoid failures if test is run multiple times in parallel (eg: on a buildbot host). -- Repository URL: http://hg.python.org/cpython

1 0

cpython (3.3): Issue #17835: Fix test_io when the default OS pipe buffer size is larger than
by antoine.pitrou April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/4b4ed1e11fd0 changeset: 83517:4b4ed1e11fd0 branch: 3.3 parent: 83512:601570064725 user: Antoine Pitrou <solipsis(a)pitrou.net> date: Wed Apr 24 23:31:38 2013 +0200 summary: Issue #17835: Fix test_io when the default OS pipe buffer size is larger than one million bytes. files: Lib/test/support.py | 10 ++++++---- Lib/test/test_io.py | 4 ++-- Misc/NEWS | 3 +++ 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Lib/test/support.py b/Lib/test/support.py --- a/Lib/test/support.py +++ b/Lib/test/support.py @@ -573,10 +573,12 @@ IPV6_ENABLED = _is_ipv6_enabled() -# A constant likely larger than the underlying OS pipe buffer size. -# Windows limit seems to be around 512B, and many Unix kernels have a 64K pipe -# buffer size or 16*PAGE_SIZE: take a few megs to be sure. This -PIPE_MAX_SIZE = 3 * 1000 * 1000 +# A constant likely larger than the underlying OS pipe buffer size, to +# make writes blocking. +# Windows limit seems to be around 512 B, and many Unix kernels have a +# 64 KiB pipe buffer size or 16 * PAGE_SIZE: take a few megs to be sure. +# (see issue #17835 for a discussion of this number). +PIPE_MAX_SIZE = 4 *1024 * 1024 + 1 # decorator for skipping tests on non-IEEE 754 platforms diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py --- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -3061,7 +3061,7 @@ # The buffered IO layer must check for pending signal # handlers, which in this case will invoke alarm_interrupt(). self.assertRaises(ZeroDivisionError, - wio.write, item * (support.PIPE_MAX_SIZE // len(item))) + wio.write, item * (support.PIPE_MAX_SIZE // len(item) + 1)) t.join() # We got one byte, get another one and check that it isn't a # repeat of the first one. @@ -3160,7 +3160,7 @@ select = support.import_module("select") # A quantity that exceeds the buffer size of an anonymous pipe's # write end. - N = 1024 * 1024 + N = support.PIPE_MAX_SIZE r, w = os.pipe() fdopen_kwargs["closefd"] = False # We need a separate thread to read from the pipe and allow the diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -132,6 +132,9 @@ Tests ----- +- Issue #17835: Fix test_io when the default OS pipe buffer size is larger + than one million bytes. + - Issue #17065: Use process-unique key for winreg tests to avoid failures if test is run multiple times in parallel (eg: on a buildbot host). -- Repository URL: http://hg.python.org/cpython

1 0

cpython: Issue #17244: Windows doesn't let you set permissions on directories.
by brett.cannon April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/0803a28dca3c changeset: 83516:0803a28dca3c user: Brett Cannon <brett(a)python.org> date: Wed Apr 24 16:34:07 2013 -0400 summary: Issue #17244: Windows doesn't let you set permissions on directories. files: Lib/test/test_py_compile.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Lib/test/test_py_compile.py b/Lib/test/test_py_compile.py --- a/Lib/test/test_py_compile.py +++ b/Lib/test/test_py_compile.py @@ -55,6 +55,8 @@ self.assertTrue(os.path.exists(self.pyc_path)) self.assertFalse(os.path.exists(self.cache_path)) + @unittest.skipIf(os.name == 'nt', + 'cannot control directory permissions on Windows') def test_exceptions_propagate(self): # Make sure that exceptions raised thanks to issues with writing # bytecode. -- Repository URL: http://hg.python.org/cpython

1 0

cpython: Issue #17832: fix a compilation warning about a function prototype.
by antoine.pitrou April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/6eacc6c134a5 changeset: 83515:6eacc6c134a5 user: Antoine Pitrou <solipsis(a)pitrou.net> date: Wed Apr 24 20:17:53 2013 +0200 summary: Issue #17832: fix a compilation warning about a function prototype. Also, make the private function static. files: Python/pythonrun.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Python/pythonrun.c b/Python/pythonrun.c --- a/Python/pythonrun.c +++ b/Python/pythonrun.c @@ -36,7 +36,8 @@ #endif #ifdef Py_REF_DEBUG -void _print_total_refs() { +static +void _print_total_refs(void) { PyObject *xoptions, *key, *value; xoptions = PySys_GetXOptions(); if (xoptions == NULL) -- Repository URL: http://hg.python.org/cpython

1 0

cpython: Revert c9674421d78e, leaving an additional comment
by eli.bendersky April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/e022cc026afc changeset: 83514:e022cc026afc user: Eli Bendersky <eliben(a)gmail.com> date: Wed Apr 24 05:34:07 2013 -0700 summary: Revert c9674421d78e, leaving an additional comment files: Modules/_elementtree.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c --- a/Modules/_elementtree.c +++ b/Modules/_elementtree.c @@ -278,25 +278,30 @@ static PyObject* get_attrib_from_keywords(PyObject *kwds) { - const char* ATTRIB_KEY = "attrib"; - PyObject *attrib = PyDict_GetItemString(kwds, ATTRIB_KEY); + PyObject *attrib_str = PyUnicode_FromString("attrib"); + PyObject *attrib = PyDict_GetItem(kwds, attrib_str); if (attrib) { /* If attrib was found in kwds, copy its value and remove it from * kwds */ if (!PyDict_Check(attrib)) { + Py_DECREF(attrib_str); PyErr_Format(PyExc_TypeError, "attrib must be dict, not %.100s", Py_TYPE(attrib)->tp_name); return NULL; } attrib = PyDict_Copy(attrib); - PyDict_DelItemString(kwds, ATTRIB_KEY); + PyDict_DelItem(kwds, attrib_str); } else { attrib = PyDict_New(); } - assert(attrib); - PyDict_Update(attrib, kwds); + + Py_DECREF(attrib_str); + + /* attrib can be NULL if PyDict_New failed */ + if (attrib) + PyDict_Update(attrib, kwds); return attrib; } -- Repository URL: http://hg.python.org/cpython

1 0

cpython (3.3): backported rev 79713 from 3.4, test_recursion_limit skipped for -O0
by lukasz.langa April 24, 2013

April 24, 2013

http://hg.python.org/cpython/rev/9755036c81d0 changeset: 83510:9755036c81d0 branch: 3.3 parent: 83508:44d764238f0d user: Łukasz Langa <lukasz(a)langa.pl> date: Wed Apr 24 01:29:26 2013 +0200 summary: backported rev 79713 from 3.4, test_recursion_limit skipped for -O0 files: Lib/test/test_threading.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -754,7 +754,8 @@ lock = threading.Lock() self.assertRaises(RuntimeError, lock.release) - @unittest.skipUnless(sys.platform == 'darwin', 'test macosx problem') + @unittest.skipUnless(sys.platform == 'darwin' and test.support.python_is_optimized(), + 'test macosx problem') def test_recursion_limit(self): # Issue 9670 # test that excessive recursion within a non-main thread causes -- Repository URL: http://hg.python.org/cpython

2 2

Daily reference leaks (360216aacfda): sum=4
by solipsis＠pitrou.net April 24, 2013

April 24, 2013

results for 360216aacfda on branch "default" -------------------------------------------- test_concurrent_futures leaked [2, 1, 1] memory blocks, sum=4 Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', '3:3:/home/antoine/cpython/refleaks/reflogv3eNC9', '-x']

1 0

cpython (merge 3.3 -> default): clean the environment from pre-existing PYTHONWARNINGS for test_warnings
by lukasz.langa April 23, 2013

April 23, 2013

http://hg.python.org/cpython/rev/360216aacfda changeset: 83513:360216aacfda parent: 83511:7d48e7087a62 parent: 83512:601570064725 user: Łukasz Langa <lukasz(a)langa.pl> date: Wed Apr 24 01:51:42 2013 +0200 summary: clean the environment from pre-existing PYTHONWARNINGS for test_warnings files: Lib/unittest/test/test_runner.py | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/Lib/unittest/test/test_runner.py b/Lib/unittest/test/test_runner.py --- a/Lib/unittest/test/test_runner.py +++ b/Lib/unittest/test/test_runner.py @@ -137,6 +137,18 @@ class Test_TextTestRunner(unittest.TestCase): """Tests for TextTestRunner.""" + def setUp(self): + # clean the environment from pre-existing PYTHONWARNINGS to make + # test_warnings results consistent + self.pythonwarnings = os.environ.get('PYTHONWARNINGS') + if self.pythonwarnings: + del os.environ['PYTHONWARNINGS'] + + def tearDown(self): + # bring back pre-existing PYTHONWARNINGS if present + if self.pythonwarnings: + os.environ['PYTHONWARNINGS'] = self.pythonwarnings + def test_init(self): runner = unittest.TextTestRunner() self.assertFalse(runner.failfast) -- Repository URL: http://hg.python.org/cpython

1 0