Mailman 3 July 2013 - Python-checkins

cpython (2.7): Issue #17273: Clarify that pool methods can only be used by parent process.
by richard.oudkerk July 2, 2013

July 2, 2013

http://hg.python.org/cpython/rev/389788ba6bcb changeset: 84422:389788ba6bcb branch: 2.7 parent: 84413:bc34fe4a0d58 user: Richard Oudkerk <shibturn(a)gmail.com> date: Tue Jul 02 12:31:50 2013 +0100 summary: Issue #17273: Clarify that pool methods can only be used by parent process. files: Doc/library/multiprocessing.rst | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Doc/library/multiprocessing.rst b/Doc/library/multiprocessing.rst --- a/Doc/library/multiprocessing.rst +++ b/Doc/library/multiprocessing.rst @@ -287,6 +287,9 @@ print result.get(timeout=1) # prints "100" unless your computer is *very* slow print pool.map(f, range(10)) # prints "[0, 1, 4,..., 81]" +Note that the methods of a pool should only ever be used by the +process which created it. + Reference --------- @@ -1599,6 +1602,9 @@ *initializer* is not ``None`` then each worker process will call ``initializer(*initargs)`` when it starts. + Note that the methods of the pool object should only be called by + the process which created the pool. + .. versionadded:: 2.7 *maxtasksperchild* is the number of tasks a worker process can complete before it will exit and be replaced with a fresh worker process, to enable -- Repository URL: http://hg.python.org/cpython

1 0

Daily reference leaks (74b7ff20e0e4): sum=0
by solipsis＠pitrou.net July 2, 2013

July 2, 2013

results for 74b7ff20e0e4 on branch "default" -------------------------------------------- Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', '3:3:/home/antoine/cpython/refleaks/reflogheinsp', '-x']

1 0

cpython (merge 3.3 -> default): (Merge 3.3) Issue #18343: faulthandler.register() now keeps the previous signal
by victor.stinner July 1, 2013

July 1, 2013

http://hg.python.org/cpython/rev/74b7ff20e0e4 changeset: 84421:74b7ff20e0e4 parent: 84419:ebe064e542ef parent: 84420:229dde749ed6 user: Victor Stinner <victor.stinner(a)gmail.com> date: Tue Jul 02 00:17:14 2013 +0200 summary: (Merge 3.3) Issue #18343: faulthandler.register() now keeps the previous signal handler when the function is called twice, so faulthandler.unregister() restores correctly the original signal handler. files: Misc/NEWS | 4 ++++ Modules/faulthandler.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -138,6 +138,10 @@ Library ------- +- Issue #18343: faulthandler.register() now keeps the previous signal handler + when the function is called twice, so faulthandler.unregister() restores + correctly the original signal handler. + - Issue #17097: Make multiprocessing ignore EINTR. - Issue #18339: Negative ints keys in unpickler.memo dict no longer cause a diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c --- a/Modules/faulthandler.c +++ b/Modules/faulthandler.c @@ -741,6 +741,8 @@ PyErr_SetFromErrno(PyExc_OSError); return NULL; } + + user->previous = previous; } Py_XDECREF(user->file); @@ -749,7 +751,6 @@ user->fd = fd; user->all_threads = all_threads; user->chain = chain; - user->previous = previous; user->interp = tstate->interp; user->enabled = 1; -- Repository URL: http://hg.python.org/cpython

1 0

cpython (3.3): Issue #18343: faulthandler.register() now keeps the previous signal handler
by victor.stinner July 1, 2013

July 1, 2013

http://hg.python.org/cpython/rev/229dde749ed6 changeset: 84420:229dde749ed6 branch: 3.3 parent: 84418:ff30bf84b378 user: Victor Stinner <victor.stinner(a)gmail.com> date: Tue Jul 02 00:14:56 2013 +0200 summary: Issue #18343: faulthandler.register() now keeps the previous signal handler when the function is called twice, so faulthandler.unregister() restores correctly the original signal handler. files: Misc/NEWS | 4 ++++ Modules/faulthandler.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -41,6 +41,10 @@ Library ------- +- Issue #18343: faulthandler.register() now keeps the previous signal handler + when the function is called twice, so faulthandler.unregister() restores + correctly the original signal handler. + - Issue #17097: Make multiprocessing ignore EINTR. - Issue #18339: Negative ints keys in unpickler.memo dict no longer cause a diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c --- a/Modules/faulthandler.c +++ b/Modules/faulthandler.c @@ -742,6 +742,8 @@ PyErr_SetFromErrno(PyExc_OSError); return NULL; } + + user->previous = previous; } Py_XDECREF(user->file); @@ -750,7 +752,6 @@ user->fd = fd; user->all_threads = all_threads; user->chain = chain; - user->previous = previous; user->interp = tstate->interp; user->enabled = 1; -- Repository URL: http://hg.python.org/cpython

1 0

cpython (merge 3.3 -> default): Issue #18328: Reorder ops in PyThreadState_Delete*() functions. Now the
by christian.heimes July 1, 2013

July 1, 2013

http://hg.python.org/cpython/rev/ebe064e542ef changeset: 84419:ebe064e542ef parent: 84417:de44cd866bb0 parent: 84418:ff30bf84b378 user: Christian Heimes <christian(a)cheimes.de> date: Mon Jul 01 23:43:09 2013 +0200 summary: Issue #18328: Reorder ops in PyThreadState_Delete*() functions. Now the tstate is first removed from TLS and then deallocated. CID 1019639 (#1 of 1): Use after free (USE_AFTER_FREE) use_after_free: Using freed pointer tstate. files: Misc/NEWS | 3 +++ Python/pystate.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -10,6 +10,9 @@ Core and Builtins ----------------- +- Issue #18328: Reorder ops in PyThreadState_Delete*() functions. Now the + tstate is first removed from TLS and then deallocated. + - Issue #13483: Use VirtualAlloc in obmalloc on Windows. - Issue #18184: PyUnicode_FromFormat() and PyUnicode_FromFormatV() now raise diff --git a/Python/pystate.c b/Python/pystate.c --- a/Python/pystate.c +++ b/Python/pystate.c @@ -374,11 +374,11 @@ { if (tstate == _Py_atomic_load_relaxed(&_PyThreadState_Current)) Py_FatalError("PyThreadState_Delete: tstate is still current"); - tstate_delete_common(tstate); #ifdef WITH_THREAD if (autoInterpreterState && PyThread_get_key_value(autoTLSkey) == tstate) PyThread_delete_key_value(autoTLSkey); #endif /* WITH_THREAD */ + tstate_delete_common(tstate); } @@ -392,9 +392,9 @@ Py_FatalError( "PyThreadState_DeleteCurrent: no current tstate"); _Py_atomic_store_relaxed(&_PyThreadState_Current, NULL); - tstate_delete_common(tstate); if (autoInterpreterState && PyThread_get_key_value(autoTLSkey) == tstate) PyThread_delete_key_value(autoTLSkey); + tstate_delete_common(tstate); PyEval_ReleaseLock(); } #endif /* WITH_THREAD */ -- Repository URL: http://hg.python.org/cpython

1 0

cpython (3.3): Issue #18328: Reorder ops in PyThreadState_Delete*() functions. Now the
by christian.heimes July 1, 2013

July 1, 2013

http://hg.python.org/cpython/rev/ff30bf84b378 changeset: 84418:ff30bf84b378 branch: 3.3 parent: 84416:fa0a03afe359 user: Christian Heimes <christian(a)cheimes.de> date: Mon Jul 01 23:42:28 2013 +0200 summary: Issue #18328: Reorder ops in PyThreadState_Delete*() functions. Now the tstate is first removed from TLS and then deallocated. CID 1019639 (#1 of 1): Use after free (USE_AFTER_FREE) use_after_free: Using freed pointer tstate. files: Misc/NEWS | 3 +++ Python/pystate.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -12,6 +12,9 @@ Core and Builtins ----------------- +- Issue #18328: Reorder ops in PyThreadState_Delete*() functions. Now the + tstate is first removed from TLS and then deallocated. + - Issue #18184: PyUnicode_FromFormat() and PyUnicode_FromFormatV() now raise OverflowError when an argument of %c format is out of range. diff --git a/Python/pystate.c b/Python/pystate.c --- a/Python/pystate.c +++ b/Python/pystate.c @@ -388,11 +388,11 @@ { if (tstate == _Py_atomic_load_relaxed(&_PyThreadState_Current)) Py_FatalError("PyThreadState_Delete: tstate is still current"); - tstate_delete_common(tstate); #ifdef WITH_THREAD if (autoInterpreterState && PyThread_get_key_value(autoTLSkey) == tstate) PyThread_delete_key_value(autoTLSkey); #endif /* WITH_THREAD */ + tstate_delete_common(tstate); } @@ -406,9 +406,9 @@ Py_FatalError( "PyThreadState_DeleteCurrent: no current tstate"); _Py_atomic_store_relaxed(&_PyThreadState_Current, NULL); - tstate_delete_common(tstate); if (autoInterpreterState && PyThread_get_key_value(autoTLSkey) == tstate) PyThread_delete_key_value(autoTLSkey); + tstate_delete_common(tstate); PyEval_ReleaseLock(); } #endif /* WITH_THREAD */ -- Repository URL: http://hg.python.org/cpython

1 0

peps: PEP 445: explain why External Libraries and Memory Allocators sections are
by victor.stinner July 1, 2013

July 1, 2013

http://hg.python.org/peps/rev/358aa763611a changeset: 4971:358aa763611a user: Victor Stinner <victor.stinner(a)gmail.com> date: Mon Jul 01 23:15:45 2013 +0200 summary: PEP 445: explain why External Libraries and Memory Allocators sections are present files: pep-0445.txt | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/pep-0445.txt b/pep-0445.txt --- a/pep-0445.txt +++ b/pep-0445.txt @@ -639,9 +639,11 @@ In C++, the context can be used to pass *this*. -External libraries +External Libraries ================== +Examples of API used to customize memory allocators. + Libraries used by Python: * OpenSSL: `CRYPTO_set_mem_functions() @@ -672,11 +674,15 @@ <http://docs.oracle.com/cd/B10501_01/appdev.920/a96584/oci15re4.htm>`_, pass an opaque pointer +The new *ctx* parameter of this PEP was inspired by the API of zlib and +Oracle's OCI libraries. + See also the `GNU libc: Memory Allocation Hooks -<http://www.gnu.org/software/libc/manual/html_node/Hooks-for-Malloc.html>`_. +<http://www.gnu.org/software/libc/manual/html_node/Hooks-for-Malloc.html>`_ +which uses a different approach to hook memory allocators. -Memory allocators +Memory Allocators ================= The C standard library provides the well known ``malloc()`` function. @@ -727,6 +733,10 @@ <https://developer.gnome.org/glib/unstable/glib-Memory-Slices.html>`_: efficient way to allocate groups of equal-sized chunks of memory +This PEP permits to choose exactly which memory allocator is used for your +application depending on its usage of the memory (number of allocation, size of +allocations, lifetime of objects, etc.). + Links ===== -- Repository URL: http://hg.python.org/peps

1 0

cpython (merge 3.3 -> default): Issue #18339: use with self.assertRaises() to make test case more readable
by christian.heimes July 1, 2013

July 1, 2013

http://hg.python.org/cpython/rev/de44cd866bb0 changeset: 84417:de44cd866bb0 parent: 84415:035577781505 parent: 84416:fa0a03afe359 user: Christian Heimes <christian(a)cheimes.de> date: Mon Jul 01 23:00:22 2013 +0200 summary: Issue #18339: use with self.assertRaises() to make test case more readable files: Lib/test/test_pickle.py | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_pickle.py b/Lib/test/test_pickle.py --- a/Lib/test/test_pickle.py +++ b/Lib/test/test_pickle.py @@ -117,9 +117,11 @@ def test_issue18339(self): unpickler = self.unpickler_class(io.BytesIO()) - self.assertRaises(TypeError, setattr, unpickler, "memo", object) + with self.assertRaises(TypeError): + unpickler.memo = object # used to cause a segfault - self.assertRaises(ValueError, setattr, unpickler, "memo", {-1: None}) + with self.assertRaises(ValueError): + unpickler.memo = {-1: None} unpickler.memo = {1: None} class CDispatchTableTests(AbstractDispatchTableTests): -- Repository URL: http://hg.python.org/cpython

1 0

cpython (3.3): Issue #18339: use with self.assertRaises() to make test case more readable
by christian.heimes July 1, 2013

July 1, 2013

http://hg.python.org/cpython/rev/fa0a03afe359 changeset: 84416:fa0a03afe359 branch: 3.3 parent: 84414:3ec5267f51ff user: Christian Heimes <christian(a)cheimes.de> date: Mon Jul 01 23:00:13 2013 +0200 summary: Issue #18339: use with self.assertRaises() to make test case more readable files: Lib/test/test_pickle.py | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_pickle.py b/Lib/test/test_pickle.py --- a/Lib/test/test_pickle.py +++ b/Lib/test/test_pickle.py @@ -117,9 +117,11 @@ def test_issue18339(self): unpickler = self.unpickler_class(io.BytesIO()) - self.assertRaises(TypeError, setattr, unpickler, "memo", object) + with self.assertRaises(TypeError): + unpickler.memo = object # used to cause a segfault - self.assertRaises(ValueError, setattr, unpickler, "memo", {-1: None}) + with self.assertRaises(ValueError): + unpickler.memo = {-1: None} unpickler.memo = {1: None} class CDispatchTableTests(AbstractDispatchTableTests): -- Repository URL: http://hg.python.org/cpython

1 0

peps: PEP 445: rephrase abstract
by victor.stinner July 1, 2013

July 1, 2013

http://hg.python.org/peps/rev/f3032259c28e changeset: 4970:f3032259c28e user: Victor Stinner <victor.stinner(a)gmail.com> date: Mon Jul 01 22:44:48 2013 +0200 summary: PEP 445: rephrase abstract Remove also a wrong sentence: using the same prototypes than external libraries is not a must-have. In fact, it was neither a guideline for this PEP, but just an inspiration. files: pep-0445.txt | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/pep-0445.txt b/pep-0445.txt --- a/pep-0445.txt +++ b/pep-0445.txt @@ -12,8 +12,8 @@ Abstract ======== -Add new Application Programming Interfaces (API) to customize Python -memory allocators. +This PEP proposes new Application Programming Interfaces (API) to customize +Python memory allocators. Rationale @@ -642,9 +642,6 @@ External libraries ================== -Python should try to reuse the same prototypes for allocator functions -than other libraries. - Libraries used by Python: * OpenSSL: `CRYPTO_set_mem_functions() -- Repository URL: http://hg.python.org/peps

1 0