Mailman 3 January 2014 - Python-checkins

cpython: inspect.test.getfullargspec: Add a unittest to ensure correct annotations
by yury.selivanov 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/0fa2750c7241 changeset: 88813:0fa2750c7241 user: Yury Selivanov <yselivanov(a)sprymix.com> date: Wed Jan 29 11:54:12 2014 -0500 summary: inspect.test.getfullargspec: Add a unittest to ensure correct annotations handling #17481 files: Lib/test/test_inspect.py | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -586,6 +586,15 @@ self.assertFullArgSpecEquals(test, args_e=['spam'], formatted='(spam)') + def test_getfullargspec_signature_annos(self): + def test(a:'spam') -> 'ham': pass + spec = inspect.getfullargspec(test) + self.assertEqual(test.__annotations__, spec.annotations) + + def test(): pass + spec = inspect.getfullargspec(test) + self.assertEqual(test.__annotations__, spec.annotations) + @unittest.skipIf(MISSING_C_DOCSTRINGS, "Signature information for builtins requires docstrings") def test_getfullargspec_builtin_methods(self): -- Repository URL: http://hg.python.org/cpython

1 0

cpython: inspect.getfullargspec: Use inspect.signature API behind the scenes #17481
by yury.selivanov 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/6d1e8162e855 changeset: 88812:6d1e8162e855 user: Yury Selivanov <yselivanov(a)sprymix.com> date: Wed Jan 29 11:24:39 2014 -0500 summary: inspect.getfullargspec: Use inspect.signature API behind the scenes #17481 files: Doc/whatsnew/3.4.rst | 7 + Lib/inspect.py | 111 +++++++++++++++++++++++++- Lib/test/test_inspect.py | 42 +++++++++- Misc/NEWS | 2 + 4 files changed, 155 insertions(+), 7 deletions(-) diff --git a/Doc/whatsnew/3.4.rst b/Doc/whatsnew/3.4.rst --- a/Doc/whatsnew/3.4.rst +++ b/Doc/whatsnew/3.4.rst @@ -786,6 +786,13 @@ metaclasses (Contributed by Ethan Furman in :issue:`18929` and :issue:`19030`) +:func:`~inspect.getfullargspec` and :func:`~inspect.getargspec` +now use the :func:`~inspect.signature` API. This allows them to +support much broader range of functions, including some builtins and +callables that follow ``__signature__`` protocol. It is still +recommended to update your code to use :func:`~inspect.signature` +directly. (Contributed by Yury Selivanov in :issue:`17481`) + logging ------- diff --git a/Lib/inspect.py b/Lib/inspect.py --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -934,7 +934,7 @@ 'args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults, annotations') def getfullargspec(func): - """Get the names and default values of a function's arguments. + """Get the names and default values of a callable object's arguments. A tuple of seven things is returned: (args, varargs, varkw, defaults, kwonlyargs, kwonlydefaults annotations). @@ -948,13 +948,90 @@ The first four items in the tuple correspond to getargspec(). """ + builtin_method_param = None + if ismethod(func): + # There is a notable difference in behaviour between getfullargspec + # and Signature: the former always returns 'self' parameter for bound + # methods, whereas the Signature always shows the actual calling + # signature of the passed object. + # + # To simulate this behaviour, we "unbind" bound methods, to trick + # inspect.signature to always return their first parameter ("self", + # usually) func = func.__func__ - if not isfunction(func): - raise TypeError('{!r} is not a Python function'.format(func)) - args, varargs, kwonlyargs, varkw = _getfullargs(func.__code__) - return FullArgSpec(args, varargs, varkw, func.__defaults__, - kwonlyargs, func.__kwdefaults__, func.__annotations__) + + elif isbuiltin(func): + # We have a builtin function or method. For that, we check the + # special '__text_signature__' attribute, provided by the + # Argument Clinic. If it's a method, we'll need to make sure + # that its first parameter (usually "self") is always returned + # (see the previous comment). + text_signature = getattr(func, '__text_signature__', None) + if text_signature and text_signature.startswith('($'): + builtin_method_param = _signature_get_bound_param(text_signature) + + try: + sig = signature(func) + except Exception as ex: + # Most of the times 'signature' will raise ValueError. + # But, it can also raise AttributeError, and, maybe something + # else. So to be fully backwards compatible, we catch all + # possible exceptions here, and reraise a TypeError. + raise TypeError('unsupported callable') from ex + + args = [] + varargs = None + varkw = None + kwonlyargs = [] + defaults = () + annotations = {} + defaults = () + kwdefaults = {} + + if sig.return_annotation is not sig.empty: + annotations['return'] = sig.return_annotation + + for param in sig.parameters.values(): + kind = param.kind + name = param.name + + if kind is _POSITIONAL_ONLY: + args.append(name) + elif kind is _POSITIONAL_OR_KEYWORD: + args.append(name) + if param.default is not param.empty: + defaults += (param.default,) + elif kind is _VAR_POSITIONAL: + varargs = name + elif kind is _KEYWORD_ONLY: + kwonlyargs.append(name) + if param.default is not param.empty: + kwdefaults[name] = param.default + elif kind is _VAR_KEYWORD: + varkw = name + + if param.annotation is not param.empty: + annotations[name] = param.annotation + + if not kwdefaults: + # compatibility with 'func.__kwdefaults__' + kwdefaults = None + + if not defaults: + # compatibility with 'func.__defaults__' + defaults = None + + if builtin_method_param and (not args or args[0] != builtin_method_param): + # `func` is a method, and we always need to return its + # first parameter -- usually "self" (to be backwards + # compatible with the previous implementation of + # getfullargspec) + args.insert(0, builtin_method_param) + + return FullArgSpec(args, varargs, varkw, defaults, + kwonlyargs, kwdefaults, annotations) + ArgInfo = namedtuple('ArgInfo', 'args varargs keywords locals') @@ -1524,6 +1601,28 @@ obj in (type, object)) +def _signature_get_bound_param(spec): + # Internal helper to get first parameter name from a + # __text_signature__ of a builtin method, which should + # be in the following format: '($param1, ...)'. + # Assumptions are that the first argument won't have + # a default value or an annotation. + + assert spec.startswith('($') + + pos = spec.find(',') + if pos == -1: + pos = spec.find(')') + + cpos = spec.find(':') + assert cpos == -1 or cpos > pos + + cpos = spec.find('=') + assert cpos == -1 or cpos > pos + + return spec[2:pos] + + def signature(obj): '''Get a signature object for the passed callable.''' diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -578,6 +578,36 @@ kwonlyargs_e=['arg'], formatted='(*, arg)') + def test_getfullargspec_signature_attr(self): + def test(): + pass + spam_param = inspect.Parameter('spam', inspect.Parameter.POSITIONAL_ONLY) + test.__signature__ = inspect.Signature(parameters=(spam_param,)) + + self.assertFullArgSpecEquals(test, args_e=['spam'], formatted='(spam)') + + @unittest.skipIf(MISSING_C_DOCSTRINGS, + "Signature information for builtins requires docstrings") + def test_getfullargspec_builtin_methods(self): + self.assertFullArgSpecEquals(_pickle.Pickler.dump, + args_e=['self', 'obj'], formatted='(self, obj)') + + self.assertFullArgSpecEquals(_pickle.Pickler(io.BytesIO()).dump, + args_e=['self', 'obj'], formatted='(self, obj)') + + @unittest.skipIf(MISSING_C_DOCSTRINGS, + "Signature information for builtins requires docstrings") + def test_getfullagrspec_builtin_func(self): + builtin = _testcapi.docstring_with_signature_with_defaults + spec = inspect.getfullargspec(builtin) + self.assertEqual(spec.defaults[0], 'avocado') + + @unittest.skipIf(MISSING_C_DOCSTRINGS, + "Signature information for builtins requires docstrings") + def test_getfullagrspec_builtin_func_no_signature(self): + builtin = _testcapi.docstring_no_signature + with self.assertRaises(TypeError): + inspect.getfullargspec(builtin) def test_getargspec_method(self): class A(object): @@ -2614,6 +2644,15 @@ self.assertNotEqual(ba, ba4) +class TestSignaturePrivateHelpers(unittest.TestCase): + def test_signature_get_bound_param(self): + getter = inspect._signature_get_bound_param + + self.assertEqual(getter('($self)'), 'self') + self.assertEqual(getter('($self, obj)'), 'self') + self.assertEqual(getter('($cls, /, obj)'), 'cls') + + class TestUnwrap(unittest.TestCase): def test_unwrap_one(self): @@ -2719,7 +2758,8 @@ TestGetcallargsFunctions, TestGetcallargsMethods, TestGetcallargsUnboundMethods, TestGetattrStatic, TestGetGeneratorState, TestNoEOL, TestSignatureObject, TestSignatureBind, TestParameterObject, - TestBoundArguments, TestGetClosureVars, TestUnwrap, TestMain + TestBoundArguments, TestSignaturePrivateHelpers, TestGetClosureVars, + TestUnwrap, TestMain ) if __name__ == "__main__": diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -47,6 +47,8 @@ - Issue #20105: the codec exception chaining now correctly sets the traceback of the original exception as its __traceback__ attribute. +- Issue #17481: inspect.getfullargspec() now uses inspect.signature() API. + IDLE ---- -- Repository URL: http://hg.python.org/cpython

1 0

cpython: inspect.Signature: ensure that non-default params don't follow default ones
by yury.selivanov 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/ca974997280d changeset: 88811:ca974997280d user: Yury Selivanov <yselivanov(a)sprymix.com> date: Wed Jan 29 10:58:16 2014 -0500 summary: inspect.Signature: ensure that non-default params don't follow default ones #20427 files: Lib/inspect.py | 21 ++++++++++++++++++++- Lib/test/test_inspect.py | 13 ++++++++++++- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/Lib/inspect.py b/Lib/inspect.py --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1924,6 +1924,7 @@ if __validate_parameters__: params = OrderedDict() top_kind = _POSITIONAL_ONLY + kind_defaults = False for idx, param in enumerate(parameters): kind = param.kind @@ -1933,9 +1934,27 @@ msg = 'wrong parameter order: {} before {}' msg = msg.format(top_kind, kind) raise ValueError(msg) - else: + elif kind > top_kind: + kind_defaults = False top_kind = kind + if (kind in (_POSITIONAL_ONLY, _POSITIONAL_OR_KEYWORD) and + not param._partial_kwarg): + # If we have a positional-only or positional-or-keyword + # parameter, that does not have its default value set + # by 'functools.partial' or other "partial" signature: + if param.default is _empty: + if kind_defaults: + # No default for this parameter, but the + # previous parameter of the same kind had + # a default + msg = 'non-default argument follows default ' \ + 'argument' + raise ValueError(msg) + else: + # There is a default for this parameter. + kind_defaults = True + if name in params: msg = 'duplicate parameter name: {!r}'.format(name) raise ValueError(msg) diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -1522,11 +1522,13 @@ self.assertEqual(str(S()), '()') - def test(po, pk, *args, ko, **kwargs): + def test(po, pk, pod=42, pkd=100, *args, ko, **kwargs): pass sig = inspect.signature(test) po = sig.parameters['po'].replace(kind=P.POSITIONAL_ONLY) + pod = sig.parameters['pod'].replace(kind=P.POSITIONAL_ONLY) pk = sig.parameters['pk'] + pkd = sig.parameters['pkd'] args = sig.parameters['args'] ko = sig.parameters['ko'] kwargs = sig.parameters['kwargs'] @@ -1549,6 +1551,15 @@ with self.assertRaisesRegex(ValueError, 'duplicate parameter name'): S((po, pk, args, kwargs2, ko)) + with self.assertRaisesRegex(ValueError, 'follows default argument'): + S((pod, po)) + + with self.assertRaisesRegex(ValueError, 'follows default argument'): + S((po, pkd, pk)) + + with self.assertRaisesRegex(ValueError, 'follows default argument'): + S((pkd, pk)) + def test_signature_immutability(self): def test(a): pass -- Repository URL: http://hg.python.org/cpython

1 0

cpython: inspect.signature: Add support for decorated (wrapped) builtins #20425
by yury.selivanov 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/a9fedabb69e5 changeset: 88810:a9fedabb69e5 user: Yury Selivanov <yselivanov(a)sprymix.com> date: Wed Jan 29 10:52:57 2014 -0500 summary: inspect.signature: Add support for decorated (wrapped) builtins #20425 files: Lib/inspect.py | 6 +++--- Lib/test/test_inspect.py | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/Lib/inspect.py b/Lib/inspect.py --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1530,9 +1530,6 @@ if not callable(obj): raise TypeError('{!r} is not a callable object'.format(obj)) - if _signature_is_builtin(obj): - return Signature.from_builtin(obj) - if isinstance(obj, types.MethodType): # In this case we skip the first parameter of the underlying # function (usually `self` or `cls`). @@ -1570,6 +1567,9 @@ return sig.replace(parameters=new_params) + if _signature_is_builtin(obj): + return Signature.from_builtin(obj) + if isinstance(obj, types.FunctionType): return Signature.from_function(obj) diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -1655,6 +1655,21 @@ __call__ = type test_callable(ThisWorksNow()) + @unittest.skipIf(MISSING_C_DOCSTRINGS, + "Signature information for builtins requires docstrings") + def test_signature_on_decorated_builtins(self): + func = _testcapi.docstring_with_signature_with_defaults + + def decorator(func): + @functools.wraps(func) + def wrapper(*args, **kwargs) -> int: + return func(*args, **kwargs) + return wrapper + + decorated_func = decorator(func) + + self.assertEqual(inspect.signature(func), + inspect.signature(decorated_func)) def test_signature_on_builtins_no_signature(self): with self.assertRaisesRegex(ValueError, 'no signature found for builtin'): -- Repository URL: http://hg.python.org/cpython

1 0

cpython: inspect.Signature: Make from_builtin to raise an exception if no signature can
by yury.selivanov 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/9433b380ad33 changeset: 88809:9433b380ad33 parent: 88807:483096ef1cf6 user: Yury Selivanov <yselivanov(a)sprymix.com> date: Wed Jan 29 10:46:14 2014 -0500 summary: inspect.Signature: Make from_builtin to raise an exception if no signature can be provided #20422 files: Lib/inspect.py | 30 ++++++++++++++++++--------- Lib/test/test_inspect.py | 4 +++ 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/Lib/inspect.py b/Lib/inspect.py --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1514,18 +1514,24 @@ return sig.replace(parameters=params) +def _signature_is_builtin(obj): + # Internal helper to test if `obj` is a callable that might + # support Argument Clinic's __text_signature__ protocol. + return (isinstance(obj, _NonUserDefinedCallables) or + ismethoddescriptor(obj) or + # Can't test 'isinstance(type)' here, as it would + # also be True for regular python classes + obj in (type, object)) + + def signature(obj): '''Get a signature object for the passed callable.''' if not callable(obj): raise TypeError('{!r} is not a callable object'.format(obj)) - if (isinstance(obj, _NonUserDefinedCallables) or - ismethoddescriptor(obj) or - isinstance(obj, type)): - sig = Signature.from_builtin(obj) - if sig: - return sig + if _signature_is_builtin(obj): + return Signature.from_builtin(obj) if isinstance(obj, types.MethodType): # In this case we skip the first parameter of the underlying @@ -2017,9 +2023,13 @@ @classmethod def from_builtin(cls, func): + if not _signature_is_builtin(func): + raise TypeError("{!r} is not a Python builtin " + "function".format(func)) + s = getattr(func, "__text_signature__", None) if not s: - return None + raise ValueError("no signature found for builtin {!r}".format(func)) Parameter = cls._parameter_cls @@ -2038,9 +2048,10 @@ try: module = ast.parse(s) except SyntaxError: - return None + module = None + if not isinstance(module, ast.Module): - return None + raise ValueError("{!r} builtin has invalid signature".format(func)) f = module.body[0] @@ -2149,7 +2160,6 @@ return cls(parameters, return_annotation=cls.empty) - @property def parameters(self): return self._parameters diff --git a/Lib/test/test_inspect.py b/Lib/test/test_inspect.py --- a/Lib/test/test_inspect.py +++ b/Lib/test/test_inspect.py @@ -1667,6 +1667,10 @@ with self.assertRaisesRegex(TypeError, 'is not a Python function'): inspect.Signature.from_function(42) + def test_signature_from_builtin_errors(self): + with self.assertRaisesRegex(TypeError, 'is not a Python builtin'): + inspect.Signature.from_builtin(42) + def test_signature_on_method(self): class Test: def __init__(*args): -- Repository URL: http://hg.python.org/cpython

1 0

peps: Improve PEP 427 FAQ formatting
by nick.coghlan 29 Jan '14

29 Jan '14

http://hg.python.org/peps/rev/c1118d37ed3a changeset: 5366:c1118d37ed3a user: Nick Coghlan <ncoghlan(a)gmail.com> date: Wed Jan 29 23:50:14 2014 +1000 summary: Improve PEP 427 FAQ formatting files: pep-0427.txt | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/pep-0427.txt b/pep-0427.txt --- a/pep-0427.txt +++ b/pep-0427.txt @@ -339,7 +339,10 @@ FAQ === + Wheel defines a .data directory. Should I put all my data there? +----------------------------------------------------------------- + This specification does not have an opinion on how you should organize your code. The .data directory is just a place for any files that are not normally installed inside ``site-packages`` or on the PYTHONPATH. @@ -347,26 +350,38 @@ resource)`` even though *those* files will usually not be distributed in *wheel's* ``.data`` directory. + Why does wheel include attached signatures? +------------------------------------------- + Attached signatures are more convenient than detached signatures because they travel with the archive. Since only the individual files are signed, the archive can be recompressed without invalidating the signature or individual files can be verified without having to download the whole archive. + Why does wheel allow JWS signatures? +------------------------------------ + The JOSE specifications of which JWS is a part are designed to be easy to implement, a feature that is also one of wheel's primary design goals. JWS yields a useful, concise pure-Python implementation. + Why does wheel also allow S/MIME signatures? +-------------------------------------------- + S/MIME signatures are allowed for users who need or want to use existing public key infrastructure with wheel. Signed packages are only a basic building block in a secure package update system. Wheel only provides the building block. + What's the deal with "purelib" vs. "platlib"? +--------------------------------------------- + Wheel preserves the "purelib" vs. "platlib" distinction, which is significant on some platforms. For example, Fedora installs pure Python packages to '/usr/lib/pythonX.Y/site-packages' and platform @@ -381,7 +396,10 @@ depending on whether it is pure Python or not and those files should be at the root with the appropriate setting given for "Root-is-purelib". + Is it possible to import Python code directly from a wheel file? +---------------------------------------------------------------- + Yes, the wheel format is deliberately designed to be compatible with Python's support for importing from zip files, ensuring that it provides a superset of the functionality provided by the preceding -- Repository URL: http://hg.python.org/peps

1 0

peps: PEP 427: Make it clear that supported != recommended
by nick.coghlan 29 Jan '14

29 Jan '14

http://hg.python.org/peps/rev/301db11cbb48 changeset: 5365:301db11cbb48 user: Nick Coghlan <ncoghlan(a)gmail.com> date: Wed Jan 29 23:06:29 2014 +1000 summary: PEP 427: Make it clear that supported != recommended files: pep-0427.txt | 20 ++++++++++++++++---- 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/pep-0427.txt b/pep-0427.txt --- a/pep-0427.txt +++ b/pep-0427.txt @@ -383,10 +383,22 @@ Is it possible to import Python code directly from a wheel file? Yes, the wheel format is deliberately designed to be compatible with - Python's support for importing from zip files. While not all wheels - will support being used that way (for example, if they include C - extensions), most pure Python wheels can be used that way just by - placing their name on ``sys.path``. + Python's support for importing from zip files, ensuring that it + provides a superset of the functionality provided by the preceding + egg format. + + However, this is generally not a *recommended* approach to using wheel + files, as importing from a zip file rather than an ordinary filesystem + directory imposes a number of additional constraints that will often + break the assumptions of Python developers (for example, C extensions + cannot be imported directly from a zip archive, and the ``__file__`` + attribute no longer refers to an ordinary filesystem path, but to + a combination path that includes both the location of the zip archive + on the filesystem and the relative path to the module inside the + archive). + + Like metaclasses and metapath importers, if you're not sure if you need + to take advantage of this feature, you almost certainly don't need it. References -- Repository URL: http://hg.python.org/peps

1 0

cpython (2.7): Backported a test for lone surrogates support in io.StringIO.
by serhiy.storchaka 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/3971e1b07af4 changeset: 88808:3971e1b07af4 branch: 2.7 parent: 88804:cbf5d415212a user: Serhiy Storchaka <storchaka(a)gmail.com> date: Wed Jan 29 11:49:13 2014 +0200 summary: Backported a test for lone surrogates support in io.StringIO. files: Lib/test/test_memoryio.py | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/Lib/test/test_memoryio.py b/Lib/test/test_memoryio.py --- a/Lib/test/test_memoryio.py +++ b/Lib/test/test_memoryio.py @@ -588,6 +588,16 @@ UnsupportedOperation = pyio.UnsupportedOperation EOF = "" + def test_lone_surrogates(self): + # Issue #20424 + surrogate = unichr(0xd800) + memio = self.ioclass(surrogate) + self.assertEqual(memio.read(), surrogate) + + memio = self.ioclass() + memio.write(surrogate) + self.assertEqual(memio.getvalue(), surrogate) + class PyStringIOPickleTest(TextIOTestMixin, unittest.TestCase): """Test if pickle restores properly the internal state of StringIO. -- Repository URL: http://hg.python.org/cpython

1 0

cpython (merge 3.3 -> default): Issue #20424: Python implementation of io.StringIO now supports lone surrogates.
by serhiy.storchaka 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/483096ef1cf6 changeset: 88807:483096ef1cf6 parent: 88806:0cd7be67f225 parent: 88805:6ca9ba9eb76b user: Serhiy Storchaka <storchaka(a)gmail.com> date: Wed Jan 29 11:45:31 2014 +0200 summary: Issue #20424: Python implementation of io.StringIO now supports lone surrogates. files: Lib/_pyio.py | 2 +- Lib/test/test_memoryio.py | 9 +++++++++ Misc/NEWS | 2 ++ 3 files changed, 12 insertions(+), 1 deletions(-) diff --git a/Lib/_pyio.py b/Lib/_pyio.py --- a/Lib/_pyio.py +++ b/Lib/_pyio.py @@ -2052,7 +2052,7 @@ def __init__(self, initial_value="", newline="\n"): super(StringIO, self).__init__(BytesIO(), encoding="utf-8", - errors="strict", + errors="surrogatepass", newline=newline) # Issue #5645: make universal newlines semantics the same as in the # C version, even under Windows. diff --git a/Lib/test/test_memoryio.py b/Lib/test/test_memoryio.py --- a/Lib/test/test_memoryio.py +++ b/Lib/test/test_memoryio.py @@ -609,6 +609,15 @@ UnsupportedOperation = pyio.UnsupportedOperation EOF = "" + def test_lone_surrogates(self): + # Issue #20424 + memio = self.ioclass('\ud800') + self.assertEqual(memio.read(), '\ud800') + + memio = self.ioclass() + memio.write('\ud800') + self.assertEqual(memio.getvalue(), '\ud800') + class PyStringIOPickleTest(TextIOTestMixin, unittest.TestCase): """Test if pickle restores properly the internal state of StringIO. diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -13,6 +13,8 @@ Library ------- +- Issue #20424: Python implementation of io.StringIO now supports lone surrogates. + - Issue #20308: inspect.signature now works on classes without user-defined __init__ or __new__ methods. -- Repository URL: http://hg.python.org/cpython

1 0

cpython: Move Misc/NEWS entries committed after releasing 3.4.0b3 to correct places.
by serhiy.storchaka 29 Jan '14

29 Jan '14

http://hg.python.org/cpython/rev/0cd7be67f225 changeset: 88806:0cd7be67f225 parent: 88803:664d83a17710 user: Serhiy Storchaka <storchaka(a)gmail.com> date: Wed Jan 29 11:44:25 2014 +0200 summary: Move Misc/NEWS entries committed after releasing 3.4.0b3 to correct places. files: Misc/NEWS | 77 ++++++++++++++++++++++++------------------ 1 files changed, 43 insertions(+), 34 deletions(-) diff --git a/Misc/NEWS b/Misc/NEWS --- a/Misc/NEWS +++ b/Misc/NEWS @@ -26,6 +26,49 @@ - Issue #20223: inspect.signature now supports methods defined with functools.partialmethods. +- Issue #19456: ntpath.join() now joins relative paths correctly when a drive + is present. + +- Issue #19077: tempfile.TemporaryDirectory cleanup no longer fails when + called during shutdown. Emitting resource warning in __del__ no longer fails. + Original patch by Antoine Pitrou. + +- Issue #20394: Silence Coverity warning in audioop module. + +- Issue #20367: Fix behavior of concurrent.futures.as_completed() for + duplicate arguments. Patch by Glenn Langford. + +- Issue #8260: The read(), readline() and readlines() methods of + codecs.StreamReader returned incomplete data when were called after + readline() or read(size). Based on patch by Amaury Forgeot d'Arc. + +- Issue #20105: the codec exception chaining now correctly sets the + traceback of the original exception as its __traceback__ attribute. + +IDLE +---- + +- Issue #17721: Remove non-functional configuration dialog help button until we + make it actually gives some help when clicked. Patch by Guilherme Simões. + +Tests +----- + +- Issue #19990: Added tests for the imghdr module. Based on patch by + Claudiu Popa. + +Tools/Demos +----------- + +- Issue #20326: Argument Clinic now uses a simple, unique signature to + annotate text signatures in docstrings, resulting in fewer false + positives. "self" parameters are also explicitly marked, allowing + inspect.Signature() to authoritatively detect (and skip) said parameters. + +- Issue #20326: Argument Clinic now generates separate checksums for the + input and output sections of the block, allowing external tools to verify + that the input has not changed (and thus the output is not out-of-date). + What's New in Python 3.4.0 Beta 3? ================================== @@ -61,25 +104,6 @@ Library ------- -- Issue #19456: ntpath.join() now joins relative paths correctly when a drive - is present. - -- Issue #19077: tempfile.TemporaryDirectory cleanup no longer fails when - called during shutdown. Emitting resource warning in __del__ no longer fails. - Original patch by Antoine Pitrou. - -- Issue #20394: Silence Coverity warning in audioop module. - -- Issue #20367: Fix behavior of concurrent.futures.as_completed() for - duplicate arguments. Patch by Glenn Langford. - -- Issue #8260: The read(), readline() and readlines() methods of - codecs.StreamReader returned incomplete data when were called after - readline() or read(size). Based on patch by Amaury Forgeot d'Arc. - -- Issue #20105: the codec exception chaining now correctly sets the - traceback of the original exception as its __traceback__ attribute. - - asyncio: Various improvements and small changes not all covered by issues listed below. E.g. wait_for() now cancels the inner task if the timeout occcurs; tweaked the set of exported symbols; renamed @@ -177,9 +201,6 @@ IDLE ---- -- Issue #17721: Remove non-functional configuration dialog help button until we - make it actually gives some help when clicked. Patch by Guilherme Simões. - - Issue #17390: Add Python version to Idle editor window title bar. Original patches by Edmond Burnett and Kent Johnson. @@ -189,9 +210,6 @@ Tests ----- -- Issue #19990: Added tests for the imghdr module. Based on patch by - Claudiu Popa. - - Issue #20358: Tests for curses.window.overlay and curses.window.overwrite no longer specify min{row,col} > max{row,col}. @@ -203,15 +221,6 @@ Tools/Demos ----------- -- Issue #20326: Argument Clinic now uses a simple, unique signature to - annotate text signatures in docstrings, resulting in fewer false - positives. "self" parameters are also explicitly marked, allowing - inspect.Signature() to authoritatively detect (and skip) said parameters. - -- Issue #20326: Argument Clinic now generates separate checksums for the - input and output sections of the block, allowing external tools to verify - that the input has not changed (and thus the output is not out-of-date). - - Issue #20390: Argument Clinic's "file" output preset now defaults to "{dirname}/clinic/{basename}.h". -- Repository URL: http://hg.python.org/cpython

1 0