Mailman 3 January 2019 - Python-checkins

Daily reference leaks (4243df51fe43): sum=3
by solipsis＠pitrou.net Jan. 19, 2019

Jan. 19, 2019

results for 4243df51fe43 on branch "default" -------------------------------------------- test_functools leaked [0, 3, 1] memory blocks, sum=4 test_multiprocessing_forkserver leaked [-2, 2, -1] memory blocks, sum=-1 Command line was: ['./python', '-m', 'test.regrtest', '-uall', '-R', '3:3:/home/psf-users/antoine/refleaks/reflogOPkOdZ', '--timeout', '7200']

1 0

bpo-35770: Fix off-by-1 error. (GH-11618)
by Miss Islington (bot) Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/47290e7642dd41d94437dd0e2c0f6bfceb… commit: 47290e7642dd41d94437dd0e2c0f6bfceb0281b5 branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2019-01-18T14:23:51-08:00 summary: bpo-35770: Fix off-by-1 error. (GH-11618) (cherry picked from commit 2cf1ddaff4c869780d9e796b21ef3e506f8ad321) Co-authored-by: Terry Jan Reedy <tjreedy(a)udel.edu> files: M Lib/idlelib/macosx.py diff --git a/Lib/idlelib/macosx.py b/Lib/idlelib/macosx.py index d6a1b376a1c2..eeaab59ae802 100644 --- a/Lib/idlelib/macosx.py +++ b/Lib/idlelib/macosx.py @@ -178,7 +178,7 @@ def overrideRootMenu(root, flist): del mainmenu.menudefs[-1][1][0:2] # Remove the 'Configure Idle' entry from the options menu, it is in the # application menu as 'Preferences' - del mainmenu.menudefs[-3][1][0:1] + del mainmenu.menudefs[-3][1][0:2] menubar = Menu(root) root.configure(menu=menubar) menudict = {}

1 0

bpo-35770: Fix off-by-1 error. (#11618)
by Terry Jan Reedy Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/2cf1ddaff4c869780d9e796b21ef3e506f… commit: 2cf1ddaff4c869780d9e796b21ef3e506f8ad321 branch: master author: Terry Jan Reedy <tjreedy(a)udel.edu> committer: GitHub <noreply(a)github.com> date: 2019-01-18T17:05:40-05:00 summary: bpo-35770: Fix off-by-1 error. (#11618) files: M Lib/idlelib/macosx.py diff --git a/Lib/idlelib/macosx.py b/Lib/idlelib/macosx.py index d6a1b376a1c2..eeaab59ae802 100644 --- a/Lib/idlelib/macosx.py +++ b/Lib/idlelib/macosx.py @@ -178,7 +178,7 @@ def overrideRootMenu(root, flist): del mainmenu.menudefs[-1][1][0:2] # Remove the 'Configure Idle' entry from the options menu, it is in the # application menu as 'Preferences' - del mainmenu.menudefs[-3][1][0:1] + del mainmenu.menudefs[-3][1][0:2] menubar = Menu(root) root.configure(menu=menubar) menudict = {}

1 0

bpo-35733: Make isinstance(ast.Constant(boolean), ast.Num) be false. (GH-11547)
by Serhiy Storchaka Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/74176226179ed56ad1c910bec5c4100e72… commit: 74176226179ed56ad1c910bec5c4100e72ab4e84 branch: master author: Anthony Sottile <asottile(a)umich.edu> committer: Serhiy Storchaka <storchaka(a)gmail.com> date: 2019-01-18T21:30:28+02:00 summary: bpo-35733: Make isinstance(ast.Constant(boolean), ast.Num) be false. (GH-11547) files: A Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst M Lib/ast.py M Lib/test/test_ast.py diff --git a/Lib/ast.py b/Lib/ast.py index 4c8c7795ff82..03b8a1b16b7a 100644 --- a/Lib/ast.py +++ b/Lib/ast.py @@ -346,7 +346,10 @@ def __instancecheck__(cls, inst): except AttributeError: return False else: - return isinstance(value, _const_types[cls]) + return ( + isinstance(value, _const_types[cls]) and + not isinstance(value, _const_types_not.get(cls, ())) + ) return type.__instancecheck__(cls, inst) def _new(cls, *args, **kwargs): @@ -384,3 +387,6 @@ def __new__(cls, *args, **kwargs): NameConstant: (type(None), bool), Ellipsis: (type(...),), } +_const_types_not = { + Num: (bool,), +} diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py index 897e705a42ca..4bf77ff046e1 100644 --- a/Lib/test/test_ast.py +++ b/Lib/test/test_ast.py @@ -411,12 +411,16 @@ def test_isinstance(self): self.assertFalse(isinstance(ast.Str('42'), ast.Bytes)) self.assertFalse(isinstance(ast.Num(42), ast.NameConstant)) self.assertFalse(isinstance(ast.Num(42), ast.Ellipsis)) + self.assertFalse(isinstance(ast.NameConstant(True), ast.Num)) + self.assertFalse(isinstance(ast.NameConstant(False), ast.Num)) self.assertFalse(isinstance(ast.Constant('42'), ast.Num)) self.assertFalse(isinstance(ast.Constant(42), ast.Str)) self.assertFalse(isinstance(ast.Constant('42'), ast.Bytes)) self.assertFalse(isinstance(ast.Constant(42), ast.NameConstant)) self.assertFalse(isinstance(ast.Constant(42), ast.Ellipsis)) + self.assertFalse(isinstance(ast.Constant(True), ast.Num)) + self.assertFalse(isinstance(ast.Constant(False), ast.Num)) self.assertFalse(isinstance(ast.Constant(), ast.Num)) self.assertFalse(isinstance(ast.Constant(), ast.Str)) diff --git a/Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst b/Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst new file mode 100644 index 000000000000..8e5ef9b84178 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst @@ -0,0 +1,2 @@ +``ast.Constant(boolean)`` no longer an instance of :class:`ast.Num`. Patch by Anthony +Sottile.

1 0

bpo-35770: IDLE macosx deletes Options => Configure IDLE. (GH-11614)
by Miss Islington (bot) Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/a01e23559fd77083a2c6c59692b70d7896… commit: a01e23559fd77083a2c6c59692b70d7896e5f59a branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2019-01-18T11:16:01-08:00 summary: bpo-35770: IDLE macosx deletes Options => Configure IDLE. (GH-11614) It previously deleted Window => Zoom Height by mistake. (Zoom Height is now on the Options menu). On Mac, the settings dialog is accessed via Preferences on the IDLE menu. (cherry picked from commit 39ed289a3511d2e9bf0950a9d5dc53c8194f61b9) Co-authored-by: Terry Jan Reedy <tjreedy(a)udel.edu> files: A Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst M Lib/idlelib/NEWS.txt M Lib/idlelib/macosx.py diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index a1964def362b..4d3da19ac372 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,6 +3,11 @@ Released on 2019-??-?? ====================================== +bpo-35770: IDLE macosx deletes Options => Configure IDLE. +It previously deleted Window => Zoom Height by mistake. +(Zoom Height is now on the Options menu). On Mac, the settings +dialog is accessed via Preferences on the IDLE menu. + bpo-35769: Change new file name from 'Untitled' to 'untitled'. bpo-35660: Fix imports in window module. diff --git a/Lib/idlelib/macosx.py b/Lib/idlelib/macosx.py index 9be4ed2ec411..d6a1b376a1c2 100644 --- a/Lib/idlelib/macosx.py +++ b/Lib/idlelib/macosx.py @@ -178,7 +178,7 @@ def overrideRootMenu(root, flist): del mainmenu.menudefs[-1][1][0:2] # Remove the 'Configure Idle' entry from the options menu, it is in the # application menu as 'Preferences' - del mainmenu.menudefs[-2][1][0] + del mainmenu.menudefs[-3][1][0:1] menubar = Menu(root) root.configure(menu=menubar) menudict = {} diff --git a/Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst b/Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst new file mode 100644 index 000000000000..89e4bdef83ef --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst @@ -0,0 +1,3 @@ +IDLE macosx deletes Options => Configure IDLE. It previously deleted Window +=> Zoom Height by mistake. (Zoom Height is now on the Options menu). On +Mac, the settings dialog is accessed via Preferences on the IDLE menu.

1 0

bpo-35770: IDLE macosx deletes Options => Configure IDLE. (GH-11614)
by Terry Jan Reedy Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/39ed289a3511d2e9bf0950a9d5dc53c819… commit: 39ed289a3511d2e9bf0950a9d5dc53c8194f61b9 branch: master author: Terry Jan Reedy <tjreedy(a)udel.edu> committer: GitHub <noreply(a)github.com> date: 2019-01-18T14:00:45-05:00 summary: bpo-35770: IDLE macosx deletes Options => Configure IDLE. (GH-11614) It previously deleted Window => Zoom Height by mistake. (Zoom Height is now on the Options menu). On Mac, the settings dialog is accessed via Preferences on the IDLE menu. files: A Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst M Lib/idlelib/NEWS.txt M Lib/idlelib/macosx.py diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 222f18710a74..61457e93d238 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,6 +3,11 @@ Released on 2019-10-20? ====================================== +bpo-35770: IDLE macosx deletes Options => Configure IDLE. +It previously deleted Window => Zoom Height by mistake. +(Zoom Height is now on the Options menu). On Mac, the settings +dialog is accessed via Preferences on the IDLE menu. + bpo-35769: Change new file name from 'Untitled' to 'untitled'. bpo-35660: Fix imports in window module. diff --git a/Lib/idlelib/macosx.py b/Lib/idlelib/macosx.py index 9be4ed2ec411..d6a1b376a1c2 100644 --- a/Lib/idlelib/macosx.py +++ b/Lib/idlelib/macosx.py @@ -178,7 +178,7 @@ def overrideRootMenu(root, flist): del mainmenu.menudefs[-1][1][0:2] # Remove the 'Configure Idle' entry from the options menu, it is in the # application menu as 'Preferences' - del mainmenu.menudefs[-2][1][0] + del mainmenu.menudefs[-3][1][0:1] menubar = Menu(root) root.configure(menu=menubar) menudict = {} diff --git a/Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst b/Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst new file mode 100644 index 000000000000..89e4bdef83ef --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-01-18-13-04-30.bpo-35770.2LxJGu.rst @@ -0,0 +1,3 @@ +IDLE macosx deletes Options => Configure IDLE. It previously deleted Window +=> Zoom Height by mistake. (Zoom Height is now on the Options menu). On +Mac, the settings dialog is accessed via Preferences on the IDLE menu.

1 0

bpo-21257: document http.client.parse_headers (GH-11443)
by Brian Curtin Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/478f8291327a3e3ab17b5857699565df43… commit: 478f8291327a3e3ab17b5857699565df43a9e952 branch: master author: Ashwin Ramaswami <aramaswamis(a)gmail.com> committer: Brian Curtin <brian(a)python.org> date: 2019-01-18T08:49:16-07:00 summary: bpo-21257: document http.client.parse_headers (GH-11443) Document http.client.parse_headers files: A Misc/NEWS.d/next/Documentation/2019-01-15-21-45-27.bpo-21257.U9LKkx.rst M Doc/library/http.client.rst diff --git a/Doc/library/http.client.rst b/Doc/library/http.client.rst index 3408c103e2f3..beaa720d732b 100644 --- a/Doc/library/http.client.rst +++ b/Doc/library/http.client.rst @@ -115,6 +115,25 @@ The module provides the following classes: The *strict* parameter was removed. HTTP 0.9 style "Simple Responses" are no longer supported. +This module provides the following function: + +.. function:: parse_headers(fp) + + Parse the headers from a file pointer *fp* representing a HTTP + request/response. The file has to be a :class:`BufferedIOBase` reader + (i.e. not text) and must provide a valid :rfc:`2822` style header. + + This function returns an instance of :class:`http.client.HTTPMessage` + that holds the header fields, but no payload + (the same as :attr:`HTTPResponse.msg` + and :attr:`http.server.BaseHTTPRequestHandler.headers`). + After returning, the file pointer *fp* is ready to read the HTTP body. + + .. note:: + :meth:`parse_headers` does not parse the start-line of a HTTP message; + it only parses the ``Name: value`` lines. The file has to be ready to + read these field lines, so the first line should already be consumed + before calling the function. The following exceptions are raised as appropriate: diff --git a/Misc/NEWS.d/next/Documentation/2019-01-15-21-45-27.bpo-21257.U9LKkx.rst b/Misc/NEWS.d/next/Documentation/2019-01-15-21-45-27.bpo-21257.U9LKkx.rst new file mode 100644 index 000000000000..ad035e95b51c --- /dev/null +++ b/Misc/NEWS.d/next/Documentation/2019-01-15-21-45-27.bpo-21257.U9LKkx.rst @@ -0,0 +1 @@ +Document :func:`http.client.parse_headers`.

1 0

bpo-35045: Accept TLSv1 default in min max test (GH-11510)
by Miss Islington (bot) Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/6ca7183b3549d3eaa8a0c3b73255eeac24… commit: 6ca7183b3549d3eaa8a0c3b73255eeac24d7974d branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2019-01-18T07:29:08-08:00 summary: bpo-35045: Accept TLSv1 default in min max test (GH-11510) Make ssl tests less strict and also accept TLSv1 as system default. The changes unbreaks test_min_max_version on Fedora 29. Signed-off-by: Christian Heimes <christian(a)python.org> (cherry picked from commit 34de2d312b3687994ddbc29adb66e88f672034c7) Co-authored-by: Christian Heimes <christian(a)python.org> files: A Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst M Lib/test/test_ssl.py diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py index b6794ce3a817..38ecddd07d98 100644 --- a/Lib/test/test_ssl.py +++ b/Lib/test/test_ssl.py @@ -1108,8 +1108,11 @@ def test_hostname_checks_common_name(self): "required OpenSSL 1.1.0g") def test_min_max_version(self): ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER) - self.assertEqual( - ctx.minimum_version, ssl.TLSVersion.MINIMUM_SUPPORTED + # OpenSSL default is MINIMUM_SUPPORTED, however some vendors like + # Fedora override the setting to TLS 1.0. + self.assertIn( + ctx.minimum_version, + {ssl.TLSVersion.MINIMUM_SUPPORTED, ssl.TLSVersion.TLSv1} ) self.assertEqual( ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED diff --git a/Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst b/Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst new file mode 100644 index 000000000000..630a22d77868 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst @@ -0,0 +1,2 @@ +Make ssl tests less strict and also accept TLSv1 as system default. The +changes unbreaks test_min_max_version on Fedora 29.

1 0

bpo-35045: Accept TLSv1 default in min max test (GH-11510)
by Victor Stinner Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/34de2d312b3687994ddbc29adb66e88f67… commit: 34de2d312b3687994ddbc29adb66e88f672034c7 branch: master author: Christian Heimes <christian(a)python.org> committer: Victor Stinner <vstinner(a)redhat.com> date: 2019-01-18T16:09:30+01:00 summary: bpo-35045: Accept TLSv1 default in min max test (GH-11510) Make ssl tests less strict and also accept TLSv1 as system default. The changes unbreaks test_min_max_version on Fedora 29. Signed-off-by: Christian Heimes <christian(a)python.org> files: A Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst M Lib/test/test_ssl.py diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py index 1fc657f4d867..9e571cc78e4b 100644 --- a/Lib/test/test_ssl.py +++ b/Lib/test/test_ssl.py @@ -1088,8 +1088,11 @@ def test_hostname_checks_common_name(self): "required OpenSSL 1.1.0g") def test_min_max_version(self): ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER) - self.assertEqual( - ctx.minimum_version, ssl.TLSVersion.MINIMUM_SUPPORTED + # OpenSSL default is MINIMUM_SUPPORTED, however some vendors like + # Fedora override the setting to TLS 1.0. + self.assertIn( + ctx.minimum_version, + {ssl.TLSVersion.MINIMUM_SUPPORTED, ssl.TLSVersion.TLSv1} ) self.assertEqual( ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED diff --git a/Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst b/Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst new file mode 100644 index 000000000000..630a22d77868 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-01-10-18-35-42.bpo-35045.qdd6d9.rst @@ -0,0 +1,2 @@ +Make ssl tests less strict and also accept TLSv1 as system default. The +changes unbreaks test_min_max_version on Fedora 29.

1 0

bpo-35283: Add pending deprecation warning for Thread.isAlive (GH-11604)
by Victor Stinner Jan. 18, 2019

Jan. 18, 2019

https://github.com/python/cpython/commit/c2647f2e45d2741fc44fd621966e05d15f… commit: c2647f2e45d2741fc44fd621966e05d15f2cd26a branch: 3.7 author: Dong-hee Na <donghee.na92(a)gmail.com> committer: Victor Stinner <vstinner(a)redhat.com> date: 2019-01-18T15:09:43+01:00 summary: bpo-35283: Add pending deprecation warning for Thread.isAlive (GH-11604) Add a pending deprecated warning for the threading.Thread.isAlive() method. files: A Misc/NEWS.d/next/Library/2019-01-07-17-17-16.bpo-35283.WClosC.rst M Lib/test/support/__init__.py M Lib/test/test_threading.py M Lib/threading.py diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py index 25c05edad340..a9cfa2a39540 100644 --- a/Lib/test/support/__init__.py +++ b/Lib/test/support/__init__.py @@ -2224,14 +2224,14 @@ def start_threads(threads, unlock=None): endtime += 60 for t in started: t.join(max(endtime - time.monotonic(), 0.01)) - started = [t for t in started if t.isAlive()] + started = [t for t in started if t.is_alive()] if not started: break if verbose: print('Unable to join %d threads during a period of ' '%d minutes' % (len(started), timeout)) finally: - started = [t for t in started if t.isAlive()] + started = [t for t in started if t.is_alive()] if started: faulthandler.dump_traceback(sys.stdout) raise AssertionError('Unable to join %d threads' % len(started)) diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index 8160a5af0064..27f328dbe63c 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -415,7 +415,8 @@ def test_old_threading_api(self): t.setDaemon(True) t.getName() t.setName("name") - t.isAlive() + with self.assertWarnsRegex(PendingDeprecationWarning, 'use is_alive()'): + t.isAlive() e = threading.Event() e.isSet() threading.activeCount() diff --git a/Lib/threading.py b/Lib/threading.py index bb41456fb141..f260a7cceca4 100644 --- a/Lib/threading.py +++ b/Lib/threading.py @@ -1007,7 +1007,7 @@ def join(self, timeout=None): When the timeout argument is present and not None, it should be a floating point number specifying a timeout for the operation in seconds (or fractions thereof). As join() always returns None, you must call - isAlive() after join() to decide whether a timeout happened -- if the + is_alive() after join() to decide whether a timeout happened -- if the thread is still alive, the join() call timed out. When the timeout argument is not present or None, the operation will @@ -1091,7 +1091,15 @@ def is_alive(self): self._wait_for_tstate_lock(False) return not self._is_stopped - isAlive = is_alive + def isAlive(self): + """Return whether the thread is alive. + + This method is deprecated, use is_alive() instead. + """ + import warnings + warnings.warn('isAlive() is deprecated, use is_alive() instead', + PendingDeprecationWarning, stacklevel=2) + return self.is_alive() @property def daemon(self): diff --git a/Misc/NEWS.d/next/Library/2019-01-07-17-17-16.bpo-35283.WClosC.rst b/Misc/NEWS.d/next/Library/2019-01-07-17-17-16.bpo-35283.WClosC.rst new file mode 100644 index 000000000000..99544f4cf4ff --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-01-07-17-17-16.bpo-35283.WClosC.rst @@ -0,0 +1,2 @@ +Add a pending deprecated warning for the :meth:`threading.Thread.isAlive` method. +Patch by Dong-hee Na.

1 0