Python-checkins

Download

python-checkins@python.org

August 2019

3 participants
442 discussions

bpo-36302: Sort list of sources (GH-12341)
by Victor Stinner Aug. 1, 2019

Aug. 1, 2019

https://github.com/python/cpython/commit/0d30ae1a03102de07758650af9243fd312… commit: 0d30ae1a03102de07758650af9243fd31211325a branch: master author: Bernhard M. Wiedemann <bwiedemann(a)suse.de> committer: Victor Stinner <vstinner(a)redhat.com> date: 2019-08-01T15:18:03+02:00 summary: bpo-36302: Sort list of sources (GH-12341) When building packages (e.g. for openSUSE Linux) (random) filesystem order of input files influences ordering of functions in the output .so files. Thus … [View More]

1 0

bpo-18049: Sync thread stack size to main thread size on macOS (GH-14748)
by Ronald Oussoren Aug. 1, 2019

Aug. 1, 2019

https://github.com/python/cpython/commit/1a057bab0f18d6ad843ce321d1d77a4819… commit: 1a057bab0f18d6ad843ce321d1d77a4819497ae4 branch: master author: Ronald Oussoren <ronaldoussoren(a)mac.com> committer: GitHub <noreply(a)github.com> date: 2019-08-01T07:43:07+02:00 summary: bpo-18049: Sync thread stack size to main thread size on macOS (GH-14748) This changeset increases the default size of the stack for threads on macOS to the size of the stack of the main thread and reenables the … [View More]relevant recursion test. files: A Misc/NEWS.d/next/macOS/2019-07-13-15-58-18.bpo-18049.MklhQQ.rst M Lib/test/test_threading.py M Python/thread_pthread.h M configure M configure.ac diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py index a99b8eca2be7..1466d25e9482 100644 --- a/Lib/test/test_threading.py +++ b/Lib/test/test_threading.py @@ -1057,8 +1057,6 @@ def test_releasing_unacquired_lock(self): lock = threading.Lock() self.assertRaises(RuntimeError, lock.release) - @unittest.skipUnless(sys.platform == 'darwin' and test.support.python_is_optimized(), - 'test macosx problem') def test_recursion_limit(self): # Issue 9670 # test that excessive recursion within a non-main thread causes diff --git a/Misc/NEWS.d/next/macOS/2019-07-13-15-58-18.bpo-18049.MklhQQ.rst b/Misc/NEWS.d/next/macOS/2019-07-13-15-58-18.bpo-18049.MklhQQ.rst new file mode 100644 index 000000000000..5af07cdb4119 --- /dev/null +++ b/Misc/NEWS.d/next/macOS/2019-07-13-15-58-18.bpo-18049.MklhQQ.rst @@ -0,0 +1,3 @@ +Increase the default stack size of threads from 5MB to 16MB on macOS, to +match the stack size of the main thread. This avoids crashes on deep recursion +in threads. diff --git a/Python/thread_pthread.h b/Python/thread_pthread.h index a36d16c19ead..994e35b2cc08 100644 --- a/Python/thread_pthread.h +++ b/Python/thread_pthread.h @@ -40,7 +40,8 @@ */ #if defined(__APPLE__) && defined(THREAD_STACK_SIZE) && THREAD_STACK_SIZE == 0 #undef THREAD_STACK_SIZE -#define THREAD_STACK_SIZE 0x500000 +/* Note: This matches the value of -Wl,-stack_size in configure.ac */ +#define THREAD_STACK_SIZE 0x1000000 #endif #if defined(__FreeBSD__) && defined(THREAD_STACK_SIZE) && THREAD_STACK_SIZE == 0 #undef THREAD_STACK_SIZE diff --git a/configure b/configure index 4cea98e36528..bffb849b797b 100755 --- a/configure +++ b/configure @@ -9542,6 +9542,8 @@ then # Issue #18075: the default maximum stack size (8MBytes) is too # small for the default recursion limit. Increase the stack size # to ensure that tests don't crash + # Note: This matches the value of THREAD_STACK_SIZE in + # thread_pthread.h LINKFORSHARED="-Wl,-stack_size,1000000 $LINKFORSHARED" if test "$enable_framework" diff --git a/configure.ac b/configure.ac index b9759e12f89f..8566d4338469 100644 --- a/configure.ac +++ b/configure.ac @@ -2694,6 +2694,8 @@ then # Issue #18075: the default maximum stack size (8MBytes) is too # small for the default recursion limit. Increase the stack size # to ensure that tests don't crash + # Note: This matches the value of THREAD_STACK_SIZE in + # thread_pthread.h LINKFORSHARED="-Wl,-stack_size,1000000 $LINKFORSHARED" if test "$enable_framework" [View Less]

1 0

Jump to page: