https://github.com/python/cpython/commit/089835469d5efbea4793cd611b43cb8387f... commit: 089835469d5efbea4793cd611b43cb8387f2e7e5 branch: main author: Vinay Sajip <vinay_sajip@yahoo.co.uk> committer: vsajip <vinay_sajip@yahoo.co.uk> date: 2024-07-02T18:57:34+01:00 summary: gh-121035: Further improve logging flow diagram with respect to dark/light modes. (GH-121265) files: M Doc/howto/logging.rst M Doc/howto/logging_flow.svg diff --git a/Doc/howto/logging.rst b/Doc/howto/logging.rst index 9c55233e910f17..cbfe93319ddaa4 100644 --- a/Doc/howto/logging.rst +++ b/Doc/howto/logging.rst @@ -403,11 +403,13 @@ following diagram. function updateBody(theme) { let elem = document.body; + elem.classList.remove('dark-theme'); + elem.classList.remove('light-theme'); if (theme === 'dark') { elem.classList.add('dark-theme'); } - else { - elem.classList.remove('dark-theme'); + else if (theme === 'light') { + elem.classList.add('light-theme'); } } diff --git a/Doc/howto/logging_flow.svg b/Doc/howto/logging_flow.svg index 9807323b7190d6..4974994ac6b400 100644 --- a/Doc/howto/logging_flow.svg +++ b/Doc/howto/logging_flow.svg @@ -46,6 +46,7 @@ filter: invert(100%) hue-rotate(180deg) saturate(1.25); } } + /* These rules are for when the theme selector is used, perhaps in contrast to the browser theme. */ body.dark-theme polygon, body.dark-theme rect, body.dark-theme polyline, body.dark-theme line { stroke: #ffffff; } @@ -55,6 +56,15 @@ body.dark-theme text { fill: #ffffff; } + body.light-theme polygon, body.light-theme rect, body.light-theme polyline, body.light-theme line { + stroke: #000000; + } + body.light-theme polygon.filled { + fill: #000000; + } + body.light-theme text { + fill: #000000; + } </style> <defs />