gh-111277: In summarize_stats.py, don't fail fast on invalid ratios (#111278)
https://github.com/python/cpython/commit/9495bcaf599e0961b45447b8fab7f844694... commit: 9495bcaf599e0961b45447b8fab7f8446945ba1a branch: main author: Michael Droettboom <mdboom@gmail.com> committer: gvanrossum <gvanrossum@gmail.com> date: 2023-10-30T17:10:07-07:00 summary: gh-111277: In summarize_stats.py, don't fail fast on invalid ratios (#111278) files: M Tools/scripts/summarize_stats.py diff --git a/Tools/scripts/summarize_stats.py b/Tools/scripts/summarize_stats.py index 0527d4bebfb86..360b7c720bd1f 100644 --- a/Tools/scripts/summarize_stats.py +++ b/Tools/scripts/summarize_stats.py @@ -421,8 +421,6 @@ def __init__(self, num: int, den: int | None, percentage: bool = True): self.num = num self.den = den self.percentage = percentage - if den == 0 and num != 0: - raise ValueError("Invalid denominator") def __float__(self): if self.den == 0: @@ -433,7 +431,11 @@ def __float__(self): return self.num / self.den def markdown(self) -> str: - if self.den == 0 or self.den is None: + if self.den is None: + return "" + elif self.den == 0: + if self.num != 0: + return f"{self.num:,} / 0 !!" return "" elif self.percentage: return f"{self.num / self.den:,.01%}"
participants (1)
-
gvanrossum