r53190 - in python/branches/release25-maint: Lib/test/test_array.py Misc/ACKS Modules/arraymodule.c
Author: thomas.wouters Date: Fri Dec 29 15:42:17 2006 New Revision: 53190 Modified: python/branches/release25-maint/Lib/test/test_array.py python/branches/release25-maint/Misc/ACKS python/branches/release25-maint/Modules/arraymodule.c Log: Backport trunk checkin r51565: Fix SF bug #1545837: array.array borks on deepcopy. array.__deepcopy__() needs to take an argument, even if it doesn't actually use it. Modified: python/branches/release25-maint/Lib/test/test_array.py ============================================================================== --- python/branches/release25-maint/Lib/test/test_array.py (original) +++ python/branches/release25-maint/Lib/test/test_array.py Fri Dec 29 15:42:17 2006 @@ -85,6 +85,13 @@ self.assertNotEqual(id(a), id(b)) self.assertEqual(a, b) + def test_deepcopy(self): + import copy + a = array.array(self.typecode, self.example) + b = copy.deepcopy(a) + self.assertNotEqual(id(a), id(b)) + self.assertEqual(a, b) + def test_pickle(self): for protocol in (0, 1, 2): a = array.array(self.typecode, self.example) Modified: python/branches/release25-maint/Misc/ACKS ============================================================================== --- python/branches/release25-maint/Misc/ACKS (original) +++ python/branches/release25-maint/Misc/ACKS Fri Dec 29 15:42:17 2006 @@ -242,6 +242,7 @@ Michael Guravage Lars Gust�bel Barry Haddow +V�clav Haisman Paul ten Hagen Rasmus Hahn Peter Haight Modified: python/branches/release25-maint/Modules/arraymodule.c ============================================================================== --- python/branches/release25-maint/Modules/arraymodule.c (original) +++ python/branches/release25-maint/Modules/arraymodule.c Fri Dec 29 15:42:17 2006 @@ -1495,7 +1495,7 @@ copy_doc}, {"count", (PyCFunction)array_count, METH_O, count_doc}, - {"__deepcopy__",(PyCFunction)array_copy, METH_NOARGS, + {"__deepcopy__",(PyCFunction)array_copy, METH_O, copy_doc}, {"extend", (PyCFunction)array_extend, METH_O, extend_doc},
Is there a policy for ACKS? I rarely see people touch it so I've just left it alone. On Fri, Dec 29, 2006 at 03:42:17PM +0100, thomas.wouters wrote:
Author: thomas.wouters Date: Fri Dec 29 15:42:17 2006 New Revision: 53190
Modified: python/branches/release25-maint/Lib/test/test_array.py python/branches/release25-maint/Misc/ACKS python/branches/release25-maint/Modules/arraymodule.c Log:
Backport trunk checkin r51565:
Fix SF bug #1545837: array.array borks on deepcopy. array.__deepcopy__() needs to take an argument, even if it doesn't actually use it.
[snip]
Modified: python/branches/release25-maint/Misc/ACKS ============================================================================== --- python/branches/release25-maint/Misc/ACKS (original) +++ python/branches/release25-maint/Misc/ACKS Fri Dec 29 15:42:17 2006 @@ -242,6 +242,7 @@ Michael Guravage Lars Gust?bel Barry Haddow +V?clav Haisman Paul ten Hagen Rasmus Hahn Peter Haight
On 12/29/06, Jack Diederich <jackdied@jackdied.com> wrote:
Is there a policy for ACKS? I rarely see people touch it so I've just left it alone.
Not exactly. I try to check the name if I don't recognize it and the OP provides a moderate size patch or equivalent. Moderate to me is generally at least 20 lines or so. 'Equivalent' could be if they suggest wording for doc, but not an actual patch. We should try to keep ACKs up to date. n
Jack Diederich schrieb:
Is there a policy for ACKS? I rarely see people touch it so I've just left it alone.
I think the agreement is that "significant" contributions should be acknowledged; obvious fixes for bugs, typos etc. don't need to. What a significant contributions is determines the committer; I usually add people with their second contribution (unless I find the first one already deserves listing in ACKS - the contribution can be traced, of course, to the SF tracker to find out who the submitter was). Regards, Martin
participants (4)
-
"Martin v. Löwis"
-
Jack Diederich
-
Neal Norwitz
-
thomas.wouters