https://github.com/python/cpython/commit/3473ca424142cb8f1453ba802ba642060b5... commit: 3473ca424142cb8f1453ba802ba642060b5ce779 branch: 3.6 author: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> committer: GitHub <noreply@github.com> date: 2018-11-29T23:59:41-08:00 summary: bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808) (cherry picked from commit a2e3585e79c93b2372dbad46a744e28fcc6dad6d) Co-authored-by: Zackery Spytz <zspytz@gmail.com> files: M Modules/nismodule.c diff --git a/Modules/nismodule.c b/Modules/nismodule.c index a9028bbfe54c..11df679b745b 100644 --- a/Modules/nismodule.c +++ b/Modules/nismodule.c @@ -412,6 +412,7 @@ nis_maps (PyObject *self, PyObject *args, PyObject *kwdict) PyObject *str = PyUnicode_FromString(maps->map); if (!str || PyList_Append(list, str) < 0) { + Py_XDECREF(str); Py_DECREF(list); list = NULL; break;