https://github.com/python/cpython/commit/f574ce79729ecb01f1f5b3e1a34c8aa7480... commit: f574ce79729ecb01f1f5b3e1a34c8aa7480b79e8 branch: 3.6 author: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> committer: Ned Deily <nad@python.org> date: 2018-11-04T16:40:25-05:00 summary: bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318) (GH-10326) (cherry picked from commit 59668aa8b7f174b59304eab833c1c1181886c3c6) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com> files: A Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst M Lib/test/test_gdb.py M Misc/ACKS diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py index b33d007acbdf..9c15fca43293 100644 --- a/Lib/test/test_gdb.py +++ b/Lib/test/test_gdb.py @@ -5,6 +5,7 @@ import locale import os +import platform import re import subprocess import sys @@ -54,6 +55,10 @@ def get_gdb_version(): if not sysconfig.is_python_build(): raise unittest.SkipTest("test_gdb only works on source builds at the moment.") +if 'Clang' in platform.python_compiler() and sys.platform == 'darwin': + raise unittest.SkipTest("test_gdb doesn't work correctly when python is" + " built with LLVM clang") + # Location of custom hooks file in a repository checkout. checkout_hook_path = os.path.join(os.path.dirname(sys.executable), 'python-gdb.py') diff --git a/Misc/ACKS b/Misc/ACKS index 94731b493c51..c78df75f0dcb 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -1107,6 +1107,7 @@ Samuel Nicolary Jonathan Niehof Gustavo Niemeyer Oscar Nierstrasz +Lysandros Nikolaou Hrvoje Nikšić Gregory Nofi Jesse Noller diff --git a/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst new file mode 100644 index 000000000000..9c6b4ef90706 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst @@ -0,0 +1,4 @@ +After several reports that test_gdb does not work properly on macOS and +since gdb is not shipped by default anymore, test_gdb is now skipped on +macOS when LLVM Clang has been used to compile Python. Patch by +Lysandros Nikolaou