![](https://secure.gravatar.com/avatar/8ac615df352a970211b0e3d94a307c6d.jpg?s=120&d=mm&r=g)
Author: ezio.melotti Date: Fri Jul 30 15:28:06 2010 New Revision: 83280 Log: #279: Removing a message sends an empty changenote to nosy users. Modified: tracker/instances/python-dev/detectors/sendmail.py Modified: tracker/instances/python-dev/detectors/sendmail.py ============================================================================== --- tracker/instances/python-dev/detectors/sendmail.py (original) +++ tracker/instances/python-dev/detectors/sendmail.py Fri Jul 30 15:28:06 2010 @@ -61,7 +61,7 @@ pass # New submission? - if None == oldvalues: + if oldvalues == None: changenote = cl.generateCreateNote(nodeid) try: # Add triage addresses @@ -71,7 +71,8 @@ oldfiles = [] else: changenote = cl.generateChangeNote(nodeid, oldvalues) - oldfiles = oldvalues.get('files', []) + oldfiles = oldvalues.get('files', []) + oldmsglist = oldvalues.get('messages', []) # Silence nosy_count/message_count lines = changenote.splitlines() @@ -89,9 +90,14 @@ changenote+="\nAdded file: %s" % url for fid in removed: url = db.config.TRACKER_WEB + "file%s/%s" % \ - (fid, db.file.get(fid, "name")) + (fid, db.file.get(fid, "name")) changenote+="\nRemoved file: %s" % url + # detect if any of the messages has been removed + newmsglist = db.issue.get(nodeid, 'messages', []) + for msgid in set(oldmsglist)-set(newmsglist): + url = db.config.TRACKER_WEB + "msg%s" % msgid + changenote += "\nRemoved message: %s" % url authid = db.getuid()
participants (1)
-
ezio.melotti